This run took 25 seconds.
From 4d9f1f96023a70ef18583e5857224c6f046debae Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sun, 10 Nov 2024 03:53:45 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Usage.NullableType.ExplicitNullableTypes
Change-Id: Id2ff0d2ffbc8e7e8ac0f069f8207e43dd8572f57
---
.phpcs.xml | 4 +++-
composer.json | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index b8ec41c..4e63994 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,6 +1,8 @@
<?xml version="1.0"?>
<ruleset>
- <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
+ <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude name="MediaWiki.Usage.NullableType.ExplicitNullableTypes" />
+ </rule>
<!--
Code such as this:
diff --git a/composer.json b/composer.json
index 8825a52..305cfef 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/mediawiki-phan-config": "0.14.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
--
2.39.2
$ date
--- stdout ---
Sun Nov 10 03:53:28 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-DiscussionTools.git repo --depth=1 -b REL1_43
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/REL1_43
--- stdout ---
c5f122c62686820301f6b8bc3d02db6c15cdc719 refs/heads/REL1_43
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 426,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 426
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 38 installs, 0 updates, 0 removals
- Locking composer/pcre (3.3.1)
- Locking composer/semver (3.4.2)
- Locking composer/spdx-licenses (1.5.8)
- Locking composer/xdebug-handler (3.0.5)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking doctrine/deprecations (1.1.3)
- Locking felixfbecker/advanced-json-rpc (v3.2.1)
- Locking mediawiki/mediawiki-codesniffer (v44.0.0)
- Locking mediawiki/mediawiki-phan-config (0.14.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking mediawiki/phan-taint-check-plugin (6.0.0)
- Locking microsoft/tolerant-php-parser (v0.1.2)
- Locking netresearch/jsonmapper (v4.5.0)
- Locking phan/phan (5.4.3)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.11)
- Locking phpdocumentor/reflection-common (2.2.0)
- Locking phpdocumentor/reflection-docblock (5.5.1)
- Locking phpdocumentor/type-resolver (1.10.0)
- Locking phpstan/phpdoc-parser (1.33.0)
- Locking psr/container (2.0.2)
- Locking psr/log (3.0.2)
- Locking sabre/event (5.1.7)
- Locking squizlabs/php_codesniffer (3.9.0)
- Locking symfony/console (v7.1.7)
- Locking symfony/deprecation-contracts (v3.5.0)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-intl-grapheme (v1.31.0)
- Locking symfony/polyfill-intl-normalizer (v1.31.0)
- Locking symfony/polyfill-mbstring (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking symfony/service-contracts (v3.5.0)
- Locking symfony/string (v7.1.6)
- Locking tysonandre/var_representation_polyfill (0.1.3)
- Locking webmozart/assert (1.11.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 38 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing squizlabs/php_codesniffer (3.9.0): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing composer/pcre (3.3.1): Extracting archive
- Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.11): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.2): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v44.0.0): Extracting archive
- Installing tysonandre/var_representation_polyfill (0.1.3): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
- Installing symfony/string (v7.1.6): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.0): Extracting archive
- Installing symfony/console (v7.1.7): Extracting archive
- Installing sabre/event (5.1.7): Extracting archive
- Installing netresearch/jsonmapper (v4.5.0): Extracting archive
- Installing microsoft/tolerant-php-parser (v0.1.2): Extracting archive
- Installing webmozart/assert (1.11.0): Extracting archive
- Installing phpstan/phpdoc-parser (1.33.0): Extracting archive
- Installing phpdocumentor/reflection-common (2.2.0): Extracting archive
- Installing doctrine/deprecations (1.1.3): Extracting archive
- Installing phpdocumentor/type-resolver (1.10.0): Extracting archive
- Installing phpdocumentor/reflection-docblock (5.5.1): Extracting archive
- Installing felixfbecker/advanced-json-rpc (v3.2.1): Extracting archive
- Installing psr/log (3.0.2): Extracting archive
- Installing composer/xdebug-handler (3.0.5): Extracting archive
- Installing phan/phan (5.4.3): Extracting archive
- Installing mediawiki/phan-taint-check-plugin (6.0.0): Extracting archive
- Installing mediawiki/mediawiki-phan-config (0.14.0): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/36 [>---------------------------] 0%
25/36 [===================>--------] 69%
35/36 [===========================>] 97%
36/36 [============================] 100%
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 44.0.0 -> 45.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 4 updates, 0 removals
- Upgrading composer/semver (3.4.2 => 3.4.3)
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0)
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12)
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 4 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12): Extracting archive
- Upgrading composer/semver (3.4.2 => 3.4.3): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0): Extracting archive
0/4 [>---------------------------] 0%
3/4 [=====================>------] 75%
4/4 [============================] 100%
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: set()
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":4,"warnings":0,"fixable":4},"files":{"\/src\/repo\/includes\/ButtonMenuSelectWidget.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PageNeverHadThreadsException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/HeadingItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/CommentItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/DiscussionTools.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/DiscussionToolsAddOverflowMenuItemsHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiDiscussionToolsGetSubscriptions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/RegistrationHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/DatabaseHeadingItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/InstallerHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/ThreadItemTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SubscriptionItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/DatabaseThreadItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/FixTrailingWhitespaceIds.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ContentThreadItemSet.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/ApiHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/DatabaseThreadItemSet.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/CommentItemTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiDiscussionToolsSubscribe.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/ContentHeadingItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/HookRunner.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/BetaPreferenceHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/DatabaseCommentItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiDiscussionToolsThank.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/HeadingItemTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Actions\/SubscribeAction.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/DiscussionToolsHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/DataUpdatesHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/DiscussionToolsTermsOfUseMessagesHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/TagHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiDiscussionToolsPreview.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/NodeFilter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/EchoHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/OverflowMenuItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SpecialGoToComment.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/EnhancedEchoEditUserTalkPresentationModel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/NewTopicOptOutActiveUsers.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SpecialFindComment.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/ContentCommentItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SpecialDiscussionToolsDebug.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/PlaintextEchoPresentationModelSection.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/IntegrationTestCase.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/AddedTopicPresentationModel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItemFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/HookRunnerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/ThreadItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiDiscussionToolsCompare.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Actions\/UnsubscribeAction.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ServiceWiringTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/LanguageDataTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/MockEventDispatcher.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/persistRevisionThreadItems.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/MockLanguageData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SpecialTopicSubscriptions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SubscriptionStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/CommentThanksPresentationModel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ApiDiscussionToolsCompareTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/DiscussionTools.magic.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/PreferenceHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/DomImpl.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiDiscussionToolsFindComment.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/DiscussionToolsEventTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ApiParseDiscussionToolsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/MockSubscriptionStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/RemovedTopicPresentationModel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/EnhancedEchoMentionPresentationModel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/ContentThreadItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ApiDiscussionToolsPageInfoTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/CommentFormatterTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/LanguageData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/CommentModifierTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/TopicSubscriptionsPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ThreadItemStoreTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/CommentUtilsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/SubscribedNewCommentPresentationModel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/CommentUtilsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ContentThreadItemTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/MockCommentFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/EventDispatcherTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiDiscussionToolsTrait.php":{"errors":2,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?int $oldid = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":158,"column":37},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $etag = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":158,"column":56}]},"\/src\/repo\/includes\/Hooks\/PageHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/EventDispatcher.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/TestUtils.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/CommentParserTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/ParserHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ImmutableRange.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/HookUtils.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiDiscussionToolsEdit.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItemStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/CommentParser.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItemSet.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/TreeWalker.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/CommentModifier.php":{"errors":2,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $signature = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":655,"column":56},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $signature = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":673,"column":52}]},"\/src\/repo\/includes\/ApiDiscussionToolsPageInfo.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/CommentUtils.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ResourceLoaderData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/CommentFormatter.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":4,"warnings":0,"fixable":4},"files":{"\/src\/repo\/includes\/PageNeverHadThreadsException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/HeadingItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ButtonMenuSelectWidget.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/DiscussionTools.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/CommentItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/DiscussionToolsAddOverflowMenuItemsHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/RegistrationHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/ThreadItemTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiDiscussionToolsGetSubscriptions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/InstallerHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/ApiHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SubscriptionItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/BetaPreferenceHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/DatabaseHeadingItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/FixTrailingWhitespaceIds.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/CommentItemTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/DatabaseThreadItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiDiscussionToolsSubscribe.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/ContentHeadingItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiDiscussionToolsThank.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/DatabaseCommentItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/DataUpdatesHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/DiscussionToolsTermsOfUseMessagesHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/HookRunner.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ContentThreadItemSet.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/HeadingItemTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/DiscussionToolsHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Actions\/SubscribeAction.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/DatabaseThreadItemSet.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/TagHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/NodeFilter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiDiscussionToolsPreview.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SpecialGoToComment.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/EchoHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/EnhancedEchoEditUserTalkPresentationModel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SpecialDiscussionToolsDebug.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/PlaintextEchoPresentationModelSection.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/AddedTopicPresentationModel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/ContentCommentItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/OverflowMenuItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/IntegrationTestCase.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/HookRunnerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ServiceWiringTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/ThreadItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SpecialFindComment.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/CommentThanksPresentationModel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/MockEventDispatcher.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItemFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/persistRevisionThreadItems.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/NewTopicOptOutActiveUsers.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiDiscussionToolsCompare.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Actions\/UnsubscribeAction.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SpecialTopicSubscriptions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/RemovedTopicPresentationModel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/DiscussionTools.magic.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/EnhancedEchoMentionPresentationModel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/LanguageDataTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/MockLanguageData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SubscriptionStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/DomImpl.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ApiDiscussionToolsCompareTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/MockSubscriptionStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ApiDiscussionToolsPageInfoTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ApiParseDiscussionToolsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/DiscussionToolsEventTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiDiscussionToolsFindComment.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/PreferenceHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/LanguageData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/SubscribedNewCommentPresentationModel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItem\/ContentThreadItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ThreadItemStoreTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/CommentUtilsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/TopicSubscriptionsPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/CommentFormatterTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ContentThreadItemTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/MockCommentFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/CommentModifierTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/CommentUtilsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/EventDispatcherTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/PageHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiDiscussionToolsTrait.php":{"errors":2,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?int $oldid = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":158,"column":37},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $etag = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":158,"column":56}]},"\/src\/repo\/tests\/phpunit\/CommentParserTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/TestUtils.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/ParserHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiDiscussionToolsEdit.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/CommentUtils.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/EventDispatcher.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ImmutableRange.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/HookUtils.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ThreadItemStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/CommentModifier.php":{"errors":2,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $signature = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":655,"column":56},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $signature = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":673,"column":52}]},"\/src\/repo\/includes\/ThreadItemSet.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ResourceLoaderData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiDiscussionToolsPageInfo.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/CommentFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/CommentParser.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/TreeWalker.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
* sniff MediaWiki.Usage.NullableType.ExplicitNullableTypes is now failing
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> phpcs -sp --cache
> minus-x check .
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
............................................................ 60/99 ( 60%)
....................................... 99/99 (100%)
Checked 99 files in 0.4 seconds
No syntax error found
.................................................. 50 / 50 (100%)
Time: 425ms; Memory: 12MB
MinusX
======
Processing /src/repo...
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
..........................
All good!
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 426,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 426
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Usage.NullableType.ExplicitNullableTypes
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpjd5g40c1
--- stdout ---
[REL1_43 4d9f1f9] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
2 files changed, 4 insertions(+), 2 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 4d9f1f96023a70ef18583e5857224c6f046debae Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sun, 10 Nov 2024 03:53:45 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Usage.NullableType.ExplicitNullableTypes
Change-Id: Id2ff0d2ffbc8e7e8ac0f069f8207e43dd8572f57
---
.phpcs.xml | 4 +++-
composer.json | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index b8ec41c..4e63994 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,6 +1,8 @@
<?xml version="1.0"?>
<ruleset>
- <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
+ <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude name="MediaWiki.Usage.NullableType.ExplicitNullableTypes" />
+ </rule>
<!--
Code such as this:
diff --git a/composer.json b/composer.json
index 8825a52..305cfef 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/mediawiki-phan-config": "0.14.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
--
2.39.2
--- end ---