This run took 15 seconds.
From 6d795cfc9294ec5250d3147d13cfceac1c6b1e77 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Mon, 11 Nov 2024 01:55:30 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
Change-Id: I0cef642b1ea3c1b11ff9b8b615c5bbe3493ba03f
---
composer.json | 2 +-
src/Helper.php | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/composer.json b/composer.json
index ff072ab..12e5c5c 100644
--- a/composer.json
+++ b/composer.json
@@ -6,7 +6,7 @@
"composer/installers": "~1.0"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0"
diff --git a/src/Helper.php b/src/Helper.php
index bd6645a..0505489 100644
--- a/src/Helper.php
+++ b/src/Helper.php
@@ -16,7 +16,7 @@ class Helper {
* @param \Title|null $oTitle
* @return \Status
*/
- public static function isValidTitle( \Title $oTitle = null ) {
+ public static function isValidTitle( ?\Title $oTitle = null ) {
if ( !$oTitle ) {
return \Status::newFatal( 'mlm-error-title-invalid' );
}
@@ -137,7 +137,7 @@ class Helper {
* @return array
*/
public static function getAvailableLanguageCodes(
- \MultiLanguageManager\MultiLanguageTranslation $oTranslation = null,
+ ?\MultiLanguageManager\MultiLanguageTranslation $oTranslation = null,
$bNoSysLang = true
) {
$sSystemLang = static::getSystemLanguageCode();
--
2.39.2
$ date
--- stdout ---
Mon Nov 11 01:55:21 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-MultiLanguageManager.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
ed9e2f424e1baa08c40941b13c720b580f9732b2 refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 419,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 419
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 22 installs, 0 updates, 0 removals
- Locking composer/installers (v1.12.0)
- Locking composer/semver (3.4.2)
- Locking composer/spdx-licenses (1.5.8)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking mediawiki/mediawiki-codesniffer (v44.0.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.11)
- Locking psr/container (2.0.2)
- Locking squizlabs/php_codesniffer (3.9.0)
- Locking symfony/console (v7.1.7)
- Locking symfony/deprecation-contracts (v3.5.0)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-intl-grapheme (v1.31.0)
- Locking symfony/polyfill-intl-normalizer (v1.31.0)
- Locking symfony/polyfill-mbstring (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking symfony/service-contracts (v3.5.0)
- Locking symfony/string (v7.1.6)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 22 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing composer/installers (v1.12.0): Extracting archive
- Installing squizlabs/php_codesniffer (3.9.0): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.11): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.2): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v44.0.0): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
- Installing symfony/string (v7.1.6): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.0): Extracting archive
- Installing symfony/console (v7.1.7): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/19 [>---------------------------] 0%
19/19 [============================] 100%
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 44.0.0 -> 45.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 4 updates, 0 removals
- Upgrading composer/semver (3.4.2 => 3.4.3)
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0)
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12)
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 4 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12): Extracting archive
- Upgrading composer/semver (3.4.2 => 3.4.3): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0): Extracting archive
0/4 [>---------------------------] 0%
3/4 [=====================>------] 75%
4/4 [============================] 100%
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: {'PSR12.Properties.ConstantVisibility.NotFound', 'MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected', 'MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName', 'Generic.CodeAnalysis.AssignmentInCondition.Found', 'MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage'}
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":19,"warnings":19,"fixable":2},"files":{"\/src\/repo\/src\/Config.php":{"errors":0,"warnings":6,"messages":[{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":7,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":8,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":9,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":10,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":11,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":12,"column":5}]},"\/src\/repo\/MultiLanguageManager.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/BeforePageDisplay.php":{"errors":0,"warnings":1,"messages":[{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.Found","severity":5,"fixable":false,"type":"WARNING","line":70,"column":26}]},"\/src\/repo\/src\/Hooks\/ArticleDelete.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/UserGetLanguageObject.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/SkinBuildSidebar.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":31,"column":15}]},"\/src\/repo\/src\/DataProvider.php":{"errors":2,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":69,"column":22},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":99,"column":22}]},"\/src\/repo\/src\/Hooks\/SkinTemplateContentActions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Helper.php":{"errors":2,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?\\Title $oTitle = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":19,"column":42},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?\\MultiLanguageManager\\MultiLanguageTranslation $oTranslation = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":140,"column":9}]},"\/src\/repo\/src\/Setup.php":{"errors":1,"warnings":1,"messages":[{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":6,"column":5},{"message":"Method name \"onSkinTemplateNavigation_Universal\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":59,"column":19}]},"\/src\/repo\/src\/Api\/Tasks.php":{"errors":7,"warnings":1,"messages":[{"message":"Method name \"task_save\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":33,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":33,"column":15},{"message":"Method name \"task_delete\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":120,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":120,"column":15},{"message":"Method name \"task_get\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":156,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":156,"column":15},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":206,"column":36},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":248,"column":15}]},"\/src\/repo\/src\/MultiLanguageTranslation.php":{"errors":0,"warnings":1,"messages":[{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.Found","severity":5,"fixable":false,"type":"WARNING","line":61,"column":39}]},"\/src\/repo\/src\/Specials\/MultiLanguageManager.php":{"errors":6,"warnings":9,"messages":[{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.Found","severity":5,"fixable":false,"type":"WARNING","line":65,"column":29},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":84,"column":15},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":100,"column":17},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":111,"column":17},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":121,"column":21},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":151,"column":21},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":164,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":190,"column":15},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":207,"column":13},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":220,"column":15},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":225,"column":13},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":273,"column":15},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":283,"column":17},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":290,"column":17},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":311,"column":15}]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcbf
--- stdout ---
PHPCBF RESULT SUMMARY
----------------------------------------------------------------------
FILE FIXED REMAINING
----------------------------------------------------------------------
/src/repo/src/Helper.php 2 0
----------------------------------------------------------------------
A TOTAL OF 2 ERRORS WERE FIXED IN 1 FILE
----------------------------------------------------------------------
Time: 317ms; Memory: 6MB
--- end ---
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":17,"warnings":19,"fixable":0},"files":{"\/src\/repo\/src\/Config.php":{"errors":0,"warnings":6,"messages":[{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":7,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":8,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":9,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":10,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":11,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":12,"column":5}]},"\/src\/repo\/MultiLanguageManager.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/ArticleDelete.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/SkinTemplateContentActions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/BeforePageDisplay.php":{"errors":0,"warnings":1,"messages":[{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.Found","severity":5,"fixable":false,"type":"WARNING","line":70,"column":26}]},"\/src\/repo\/src\/Hooks\/SkinBuildSidebar.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":31,"column":15}]},"\/src\/repo\/src\/Setup.php":{"errors":1,"warnings":1,"messages":[{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":6,"column":5},{"message":"Method name \"onSkinTemplateNavigation_Universal\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":59,"column":19}]},"\/src\/repo\/src\/Hooks\/UserGetLanguageObject.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/DataProvider.php":{"errors":2,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":69,"column":22},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":99,"column":22}]},"\/src\/repo\/src\/Helper.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/Tasks.php":{"errors":7,"warnings":1,"messages":[{"message":"Method name \"task_save\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":33,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":33,"column":15},{"message":"Method name \"task_delete\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":120,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":120,"column":15},{"message":"Method name \"task_get\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":156,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":156,"column":15},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":206,"column":36},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":248,"column":15}]},"\/src\/repo\/src\/MultiLanguageTranslation.php":{"errors":0,"warnings":1,"messages":[{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.Found","severity":5,"fixable":false,"type":"WARNING","line":61,"column":39}]},"\/src\/repo\/src\/Specials\/MultiLanguageManager.php":{"errors":6,"warnings":9,"messages":[{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.Found","severity":5,"fixable":false,"type":"WARNING","line":65,"column":29},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":84,"column":15},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":100,"column":17},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":111,"column":17},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":121,"column":21},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":151,"column":21},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":164,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":190,"column":15},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":207,"column":13},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":220,"column":15},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":225,"column":13},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":273,"column":15},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":283,"column":17},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":290,"column":17},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":311,"column":15}]}}}
--- end ---
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> phpcs -sp --cache
> minus-x check .
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
............. 13/13 (100%)
Checked 13 files in 0.1 seconds
No syntax error found
............. 13 / 13 (100%)
Time: 139ms; Memory: 8MB
MinusX
======
Processing /src/repo...
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
...............................................
All good!
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 419,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 419
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpyyyd7b_a
--- stdout ---
[master 6d795cf] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
2 files changed, 3 insertions(+), 3 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 6d795cfc9294ec5250d3147d13cfceac1c6b1e77 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Mon, 11 Nov 2024 01:55:30 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
Change-Id: I0cef642b1ea3c1b11ff9b8b615c5bbe3493ba03f
---
composer.json | 2 +-
src/Helper.php | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/composer.json b/composer.json
index ff072ab..12e5c5c 100644
--- a/composer.json
+++ b/composer.json
@@ -6,7 +6,7 @@
"composer/installers": "~1.0"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0"
diff --git a/src/Helper.php b/src/Helper.php
index bd6645a..0505489 100644
--- a/src/Helper.php
+++ b/src/Helper.php
@@ -16,7 +16,7 @@ class Helper {
* @param \Title|null $oTitle
* @return \Status
*/
- public static function isValidTitle( \Title $oTitle = null ) {
+ public static function isValidTitle( ?\Title $oTitle = null ) {
if ( !$oTitle ) {
return \Status::newFatal( 'mlm-error-title-invalid' );
}
@@ -137,7 +137,7 @@ class Helper {
* @return array
*/
public static function getAvailableLanguageCodes(
- \MultiLanguageManager\MultiLanguageTranslation $oTranslation = null,
+ ?\MultiLanguageManager\MultiLanguageTranslation $oTranslation = null,
$bNoSysLang = true
) {
$sSystemLang = static::getSystemLanguageCode();
--
2.39.2
--- end ---