log #1602825

$ date
--- stdout ---
Wed Nov 13 01:07:14 UTC 2024

--- end ---
$ git clone file:///srv/git/mediawiki-extensions-EmailNotifications.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---

--- end ---
$ git config user.name libraryupgrader
--- stdout ---

--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---

--- end ---
$ git submodule update --init
--- stdout ---

--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.

--- end ---
$ git show-ref refs/heads/master
--- stdout ---
457e3c5240efdc74cde0d37a87a257542c49add0 refs/heads/master

--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
  "auditReportVersion": 2,
  "vulnerabilities": {},
  "metadata": {
    "vulnerabilities": {
      "info": 0,
      "low": 0,
      "moderate": 0,
      "high": 0,
      "critical": 0,
      "total": 0
    },
    "dependencies": {
      "prod": 1,
      "dev": 422,
      "optional": 0,
      "peer": 1,
      "peerOptional": 0,
      "total": 422
    }
  }
}

--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 47 installs, 0 updates, 0 removals
  - Locking async-aws/core (1.22.1)
  - Locking async-aws/ses (1.8.2)
  - Locking composer/semver (3.4.2)
  - Locking composer/spdx-licenses (1.5.8)
  - Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
  - Locking doctrine/lexer (3.0.1)
  - Locking dragonmantank/cron-expression (v3.4.0)
  - Locking egulias/email-validator (4.0.2)
  - Locking html2text/html2text (4.3.2)
  - Locking mediawiki/mediawiki-codesniffer (v44.0.0)
  - Locking mediawiki/minus-x (1.1.3)
  - Locking php-parallel-lint/php-console-color (v1.0.1)
  - Locking php-parallel-lint/php-console-highlighter (v1.0.0)
  - Locking php-parallel-lint/php-parallel-lint (v1.4.0)
  - Locking phpcsstandards/phpcsextra (1.2.1)
  - Locking phpcsstandards/phpcsutils (1.0.11)
  - Locking psr/cache (3.0.0)
  - Locking psr/container (2.0.2)
  - Locking psr/event-dispatcher (1.0.0)
  - Locking psr/log (1.1.4)
  - Locking squizlabs/php_codesniffer (3.9.0)
  - Locking symfony/amazon-mailer (v5.4.45)
  - Locking symfony/console (v7.1.7)
  - Locking symfony/deprecation-contracts (v3.5.0)
  - Locking symfony/event-dispatcher (v6.4.13)
  - Locking symfony/event-dispatcher-contracts (v3.5.0)
  - Locking symfony/google-mailer (v5.4.45)
  - Locking symfony/http-client (v7.1.7)
  - Locking symfony/http-client-contracts (v3.5.0)
  - Locking symfony/mailchimp-mailer (v5.4.45)
  - Locking symfony/mailer (v5.4.45)
  - Locking symfony/mailgun-mailer (v5.4.45)
  - Locking symfony/mailjet-mailer (v5.4.45)
  - Locking symfony/mime (v6.4.13)
  - Locking symfony/oh-my-smtp-mailer (v5.4.45)
  - Locking symfony/polyfill-ctype (v1.31.0)
  - Locking symfony/polyfill-intl-grapheme (v1.31.0)
  - Locking symfony/polyfill-intl-idn (v1.31.0)
  - Locking symfony/polyfill-intl-normalizer (v1.31.0)
  - Locking symfony/polyfill-mbstring (v1.31.0)
  - Locking symfony/polyfill-php80 (v1.31.0)
  - Locking symfony/postmark-mailer (v5.4.45)
  - Locking symfony/sendgrid-mailer (v5.4.45)
  - Locking symfony/sendinblue-mailer (v5.4.45)
  - Locking symfony/service-contracts (v3.5.0)
  - Locking symfony/string (v7.1.6)
  - Locking webmozart/assert (1.11.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 47 installs, 0 updates, 0 removals
    0 [>---------------------------]    0 [->--------------------------]
  - Installing squizlabs/php_codesniffer (3.9.0): Extracting archive
  - Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
  - Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
  - Installing psr/container (2.0.2): Extracting archive
  - Installing symfony/service-contracts (v3.5.0): Extracting archive
  - Installing symfony/http-client-contracts (v3.5.0): Extracting archive
  - Installing psr/log (1.1.4): Extracting archive
  - Installing symfony/http-client (v7.1.7): Extracting archive
  - Installing psr/cache (3.0.0): Extracting archive
  - Installing async-aws/core (1.22.1): Extracting archive
  - Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
  - Installing webmozart/assert (1.11.0): Extracting archive
  - Installing dragonmantank/cron-expression (v3.4.0): Extracting archive
  - Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
  - Installing symfony/polyfill-intl-idn (v1.31.0): Extracting archive
  - Installing doctrine/lexer (3.0.1): Extracting archive
  - Installing egulias/email-validator (4.0.2): Extracting archive
  - Installing html2text/html2text (4.3.2): Extracting archive
  - Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
  - Installing phpcsstandards/phpcsutils (1.0.11): Extracting archive
  - Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
  - Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
  - Installing composer/spdx-licenses (1.5.8): Extracting archive
  - Installing composer/semver (3.4.2): Extracting archive
  - Installing mediawiki/mediawiki-codesniffer (v44.0.0): Extracting archive
  - Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
  - Installing symfony/string (v7.1.6): Extracting archive
  - Installing symfony/console (v7.1.7): Extracting archive
  - Installing mediawiki/minus-x (1.1.3): Extracting archive
  - Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
  - Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
  - Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
  - Installing symfony/mime (v6.4.13): Extracting archive
  - Installing psr/event-dispatcher (1.0.0): Extracting archive
  - Installing symfony/event-dispatcher-contracts (v3.5.0): Extracting archive
  - Installing symfony/event-dispatcher (v6.4.13): Extracting archive
  - Installing symfony/mailer (v5.4.45): Extracting archive
  - Installing async-aws/ses (1.8.2): Extracting archive
  - Installing symfony/amazon-mailer (v5.4.45): Extracting archive
  - Installing symfony/google-mailer (v5.4.45): Extracting archive
  - Installing symfony/mailchimp-mailer (v5.4.45): Extracting archive
  - Installing symfony/mailgun-mailer (v5.4.45): Extracting archive
  - Installing symfony/mailjet-mailer (v5.4.45): Extracting archive
  - Installing symfony/oh-my-smtp-mailer (v5.4.45): Extracting archive
  - Installing symfony/postmark-mailer (v5.4.45): Extracting archive
  - Installing symfony/sendgrid-mailer (v5.4.45): Extracting archive
  - Installing symfony/sendinblue-mailer (v5.4.45): Extracting archive
  0/45 [>---------------------------]   0%
 20/45 [============>---------------]  44%
 32/45 [===================>--------]  71%
 45/45 [============================] 100%
Package symfony/oh-my-smtp-mailer is abandoned, you should avoid using it. Use symfony/mail-pace-mailer instead.
Generating autoload files
35 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils

--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 44.0.0 -> 45.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 4 updates, 0 removals
  - Upgrading composer/semver (3.4.2 => 3.4.3)
  - Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0)
  - Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12)
  - Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 4 updates, 0 removals
    0 [>---------------------------]    0 [->--------------------------]
  - Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3): Extracting archive
  - Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12): Extracting archive
  - Upgrading composer/semver (3.4.2 => 3.4.3): Extracting archive
  - Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0): Extracting archive
 0/4 [>---------------------------]   0%
 3/4 [=====================>------]  75%
 4/4 [============================] 100%
Package symfony/oh-my-smtp-mailer is abandoned, you should avoid using it. Use symfony/mail-pace-mailer instead.
Generating autoload files
35 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils

--- end ---
Previously failing phpcs rules: set()
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":1,"warnings":0,"fixable":1},"files":{"\/src\/repo\/EmailNotifications.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/EmailNotificationsMagic.i18n.magic.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/classes\/Widgets\/MenuTagMultiselectWidget.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/EmailNotificationsHooks.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?DatabaseUpdater $updater = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":58,"column":58}]},"\/src\/repo\/maintenance\/sendNotifications.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/EmailNotificationsApiCheckLatestVersion.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/classes\/Widgets\/TagMultiselectWidget.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/EmailNotificationsForm.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/SpecialEmailNotificationsActivity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/classes\/Widgets\/HTMLMenuTagMultiselectField.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/pagers\/Activity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/SpecialEmailNotificationsEvents.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/pagers\/Sent.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/pagers\/Notifications.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/classes\/Mailer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/SpecialEmailNotifications.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/EmailNotifications.php":{"errors":0,"warnings":0,"messages":[]}}}

--- end ---
PHPCS run failed
$ vendor/bin/phpcbf
--- stdout ---

PHPCBF RESULT SUMMARY
----------------------------------------------------------------------
FILE                                                  FIXED  REMAINING
----------------------------------------------------------------------
/src/repo/includes/EmailNotificationsHooks.php        1      0
----------------------------------------------------------------------
A TOTAL OF 1 ERROR WERE FIXED IN 1 FILE
----------------------------------------------------------------------

Time: 407ms; Memory: 8MB



--- end ---
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":0,"warnings":0,"fixable":0},"files":{"\/src\/repo\/EmailNotifications.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/classes\/Widgets\/MenuTagMultiselectWidget.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/EmailNotificationsForm.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/EmailNotificationsMagic.i18n.magic.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/SpecialEmailNotificationsEvents.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/sendNotifications.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/pagers\/Sent.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/EmailNotificationsApiCheckLatestVersion.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/pagers\/Activity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/classes\/Widgets\/TagMultiselectWidget.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/classes\/Widgets\/HTMLMenuTagMultiselectField.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/EmailNotificationsHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/classes\/Mailer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/SpecialEmailNotificationsActivity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/pagers\/Notifications.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/SpecialEmailNotifications.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/EmailNotifications.php":{"errors":0,"warnings":0,"messages":[]}}}

--- end ---
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---

--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Package symfony/oh-my-smtp-mailer is abandoned, you should avoid using it. Use symfony/mail-pace-mailer instead.
Generating autoload files
35 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---

--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> minus-x check .
> phpcs -sp --cache
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
.................                                            17/17 (100%)


Checked 17 files in 0.1 seconds
No syntax error found
MinusX
======
Processing /src/repo...
...............................................
All good!
................. 17 / 17 (100%)


Time: 154ms; Memory: 8MB


--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
  "auditReportVersion": 2,
  "vulnerabilities": {},
  "metadata": {
    "vulnerabilities": {
      "info": 0,
      "low": 0,
      "moderate": 0,
      "high": 0,
      "critical": 0,
      "total": 0
    },
    "dependencies": {
      "prod": 1,
      "dev": 422,
      "optional": 0,
      "peer": 1,
      "peerOptional": 0,
      "total": 422
    }
  }
}

--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json

--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 45.0.0

$ git add .
--- stdout ---

--- end ---
$ git commit -F /tmp/tmptkclt6mf
--- stdout ---
[master 096a46a] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
 2 files changed, 2 insertions(+), 2 deletions(-)

--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 096a46a0b34714fbc18237fe7a0d41ac74019293 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Wed, 13 Nov 2024 01:07:24 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0

Change-Id: Ib79c7bdc246e8045616aa0f90d6bdc7cc07cc32f
---
 composer.json                        | 2 +-
 includes/EmailNotificationsHooks.php | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/composer.json b/composer.json
index 53aff37..f3f650f 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
 {
 	"require-dev": {
-		"mediawiki/mediawiki-codesniffer": "44.0.0",
+		"mediawiki/mediawiki-codesniffer": "45.0.0",
 		"mediawiki/minus-x": "1.1.3",
 		"php-parallel-lint/php-console-highlighter": "1.0.0",
 		"php-parallel-lint/php-parallel-lint": "1.4.0"
diff --git a/includes/EmailNotificationsHooks.php b/includes/EmailNotificationsHooks.php
index f1dee60..ada6623 100644
--- a/includes/EmailNotificationsHooks.php
+++ b/includes/EmailNotificationsHooks.php
@@ -55,7 +55,7 @@ class EmailNotificationsHooks {
 	 * @param DatabaseUpdater|null $updater
 	 * @return void
 	 */
-	public static function onLoadExtensionSchemaUpdates( DatabaseUpdater $updater = null ) {
+	public static function onLoadExtensionSchemaUpdates( ?DatabaseUpdater $updater = null ) {
 		$base = __DIR__;
 		$dbType = $updater->getDB()->getType();
 		$tables = [
-- 
2.39.2


--- end ---
mediawiki/extensions/EmailNotifications: main (log #1602825)
