This run took 16 seconds.
From 8d6d95fd23172fb12852eaac1f49d495c211d8b6 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Thu, 8 May 2025 09:27:41 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 47.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName
The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment.WrongStyle
Change-Id: I5620a54f0ca78a6374a6dca9c464839b22228db7
---
.phpcs.xml | 2 +-
composer.json | 2 +-
tests/integration/MementoTest.php | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index ef19566..9938667 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -3,13 +3,13 @@
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="Generic.Files.LineLength.TooLong" />
<exclude name="MediaWiki.Commenting.MissingCovers.MissingCovers" />
+ <exclude name="MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName" />
<exclude name="MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic" />
<exclude name="Generic.PHP.BacktickOperator.Found" />
<exclude name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName" />
<exclude name="MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix" />
<exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
- <exclude name="MediaWiki.Commenting.FunctionComment.WrongStyle" />
<exclude name="MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix" />
<exclude name="MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage" />
<exclude name="MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage" />
diff --git a/composer.json b/composer.json
index ed04483..f3733fa 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "46.0.0",
+ "mediawiki/mediawiki-codesniffer": "47.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0"
diff --git a/tests/integration/MementoTest.php b/tests/integration/MementoTest.php
index 2b52857..e0378d0 100644
--- a/tests/integration/MementoTest.php
+++ b/tests/integration/MementoTest.php
@@ -544,7 +544,7 @@ class MementoTest extends PHPUnit\Framework\TestCase {
/**
* @group all
*
- * @dataProvider acquireDiffUrls()
+ * @dataProvider acquireDiffUrls
*/
public function testDiffPage( $URIR ) {
global $sessionCookieString;
--
2.39.5
$ date
--- stdout ---
Thu May 8 09:27:29 UTC 2025
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-Memento.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
dd9a52e23c069312d15ad25c98ea206a8cb17c12 refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 315,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 315
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 21 installs, 0 updates, 0 removals
- Locking composer/semver (3.4.3)
- Locking composer/spdx-licenses (1.5.8)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking mediawiki/mediawiki-codesniffer (v46.0.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.12)
- Locking psr/container (2.0.2)
- Locking squizlabs/php_codesniffer (3.11.3)
- Locking symfony/console (v7.2.6)
- Locking symfony/deprecation-contracts (v3.5.1)
- Locking symfony/polyfill-ctype (v1.32.0)
- Locking symfony/polyfill-intl-grapheme (v1.32.0)
- Locking symfony/polyfill-intl-normalizer (v1.32.0)
- Locking symfony/polyfill-mbstring (v1.32.0)
- Locking symfony/polyfill-php80 (v1.32.0)
- Locking symfony/service-contracts (v3.5.1)
- Locking symfony/string (v7.2.6)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 21 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing squizlabs/php_codesniffer (3.11.3): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing symfony/polyfill-php80 (v1.32.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.12): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.32.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.3): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v46.0.0): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.32.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.32.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.32.0): Extracting archive
- Installing symfony/string (v7.2.6): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.1): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.1): Extracting archive
- Installing symfony/console (v7.2.6): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/19 [>---------------------------] 0%
19/19 [============================] 100%
Generating autoload files
14 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 46.0.0 -> 47.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 2 updates, 0 removals
- Upgrading mediawiki/mediawiki-codesniffer (v46.0.0 => v47.0.0)
- Upgrading squizlabs/php_codesniffer (3.11.3 => 3.12.2)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 2 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.11.3 => 3.12.2): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v46.0.0 => v47.0.0): Extracting archive
0/2 [>---------------------------] 0%
1/2 [==============>-------------] 50%
2/2 [============================] 100%
Generating autoload files
14 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: {'MediaWiki.Commenting.FunctionComment.WrongStyle', 'MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic', 'MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic', 'MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment', 'MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage', 'MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName', 'Generic.PHP.BacktickOperator.Found', 'MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix', 'MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix', 'MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage', 'MediaWiki.Commenting.MissingCovers.MissingCovers', 'Generic.Files.LineLength.TooLong', 'MediaWiki.Usage.ForbiddenFunctions.eval'}
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":85,"warnings":60,"fixable":1},"files":{"\/src\/repo\/Memento\/includes\/TimeGateResourceFrom302TimeNegotiation.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/data\/local-demo-wiki\/authentication-data.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/Memento\/includes\/Memento.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/Memento\/Memento.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/Memento\/includes\/TimeMapPivotAscendingResource.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/Memento\/includes\/TimeMapPivotDescendingResource.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/Memento\/includes\/TimeMapFullResource.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/scripts\/CLI-GenerateCookieString.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/Memento\/includes\/TimeGate.php":{"errors":0,"warnings":8,"messages":[{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":45,"column":25},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":46,"column":17},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":47,"column":19},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":48,"column":20},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":49,"column":24},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":50,"column":19},{"message":"Should use function $this->getConfig()->get() rather than global $wgMementoIncludeNamespaces","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":63,"column":16},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":69,"column":28}]},"\/src\/repo\/Memento\/includes\/OriginalResourceDirectlyAccessed.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/Memento\/includes\/TimeMap.php":{"errors":0,"warnings":8,"messages":[{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":45,"column":24},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":46,"column":17},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":47,"column":19},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":48,"column":20},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":49,"column":24},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":50,"column":19},{"message":"Should use function $this->getConfig()->get() rather than global $wgMementoIncludeNamespaces","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":62,"column":16},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":68,"column":28}]},"\/src\/repo\/Memento\/includes\/MementoResourceDirectlyAccessed.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/integration\/SimpleTest.php":{"errors":1,"warnings":1,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":7,"column":19},{"message":"The testSimpleLittleTests test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":12,"column":12}]},"\/src\/repo\/tests\/docker-image\/LocalSettings-1.27.5.php":{"errors":0,"warnings":4,"messages":[{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":44,"column":28},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":49,"column":28},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":50,"column":29},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":109,"column":21}]},"\/src\/repo\/tests\/lib\/MementoParse.php":{"errors":3,"warnings":0,"messages":[{"message":"Global function \"extractItemsFromLink()\" is lacking a valid prefix ('wf'). It should be wfExtractItemsFromLink().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":19,"column":1},{"message":"Global function \"extractItemsFromVary()\" is lacking a valid prefix ('wf'). It should be wfExtractItemsFromVary().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":69,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":69,"column":1}]},"\/src\/repo\/tests\/docker-image\/LocalSettings.php":{"errors":0,"warnings":4,"messages":[{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":44,"column":28},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":49,"column":28},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":50,"column":29},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":109,"column":21}]},"\/src\/repo\/Memento\/includes\/TimeNegotiator.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/integration\/TimeMapTest.php":{"errors":11,"warnings":3,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":10,"column":19},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":13,"column":9},{"message":"The testSimpleTimeMap test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":34,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":35,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":52,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":52,"column":67},{"message":"The testSimpleIncreasingTimeMap test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":67,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":68,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":85,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":85,"column":67},{"message":"The testSimpleDecreasingTimeMap test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":100,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":101,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":118,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":118,"column":67}]},"\/src\/repo\/tests\/lib\/TestSupport.php":{"errors":10,"warnings":1,"messages":[{"message":"Global function \"acquireLinesFromFile()\" is lacking a valid prefix ('wf'). It should be wfAcquireLinesFromFile().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":3,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":3,"column":1},{"message":"Global function \"acquireCSVDataFromFile()\" is lacking a valid prefix ('wf'). It should be wfAcquireCSVDataFromFile().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":21,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":21,"column":1},{"message":"Global function \"objectToArray()\" is lacking a valid prefix ('wf'). It should be wfObjectToArray().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":47,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":47,"column":1},{"message":"Global function \"acquireFormattedI18NString()\" is lacking a valid prefix ('wf'). It should be wfAcquireFormattedI18NString().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":69,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":69,"column":1},{"message":"Global function \"diffStrings()\" is lacking a valid prefix ('wf'). It should be wfDiffStrings().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":92,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":92,"column":1},{"message":"eval should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.eval","severity":5,"fixable":false,"type":"WARNING","line":117,"column":55}]},"\/src\/repo\/tests\/lib\/HTTPFetch.php":{"errors":21,"warnings":0,"messages":[{"message":"Global function \"extractHeadersFromResponse()\" is lacking a valid prefix ('wf'). It should be wfExtractHeadersFromResponse().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":11,"column":1},{"message":"Global function \"extractStatuslineFromResponse()\" is lacking a valid prefix ('wf'). It should be wfExtractStatuslineFromResponse().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":40,"column":1},{"message":"Global function \"extractEntityFromResponse()\" is lacking a valid prefix ('wf'). It should be wfExtractEntityFromResponse().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":68,"column":1},{"message":"Global function \"extractCookiesSetInResponse()\" is lacking a valid prefix ('wf'). It should be wfExtractCookiesSetInResponse().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":80,"column":1},{"message":"Global function \"authenticateWithMediawiki()\" is lacking a valid prefix ('wf'). It should be wfAuthenticateWithMediawiki().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":108,"column":1},{"message":"Global variable \"$mwLoginFormUrl\" is lacking an allowed prefix ('wg'). Should be \"$wgMwLoginFormUrl\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":109,"column":9},{"message":"Global variable \"$mwLoginActionUrl\" is lacking an allowed prefix ('wg'). Should be \"$wgMwLoginActionUrl\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":110,"column":9},{"message":"Global variable \"$wpName\" is lacking an allowed prefix ('wg'). Should be \"$wgWpName\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":111,"column":9},{"message":"Global variable \"$wpPassword\" is lacking an allowed prefix ('wg'). Should be \"$wgWpPassword\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":112,"column":9},{"message":"Global variable \"$wpLoginToken\" is lacking an allowed prefix ('wg'). Should be \"$wgWpLoginToken\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":113,"column":9},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":114,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":118,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":118,"column":72},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":138,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":138,"column":153},{"message":"Global function \"logOutOfMediawiki()\" is lacking a valid prefix ('wf'). It should be wfLogOutOfMediawiki().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":165,"column":1},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":166,"column":9},{"message":"Global variable \"$mwLogoutActionUrl\" is lacking an allowed prefix ('wg'). Should be \"$wgMwLogoutActionUrl\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":167,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":171,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":171,"column":101},{"message":"Global function \"extractHeadersStringFromResponse()\" is lacking a valid prefix ('wf'). It should be wfExtractHeadersStringFromResponse().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":179,"column":1}]},"\/src\/repo\/tests\/integration\/ErrorStateTest.php":{"errors":14,"warnings":8,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":10,"column":19},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":13,"column":9},{"message":"Method name \"Status400TimeGateErrorResponseCommonTests\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":30,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":33,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":39,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":39,"column":64},{"message":"Method name \"Status404TimeMapErrorResponseCommonTests\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":69,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":72,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":77,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":77,"column":64},{"message":"Method name \"Status400TimeMapErrorResponseCommonTests\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":98,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":101,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":106,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":106,"column":64},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":131,"column":8},{"message":"The test400TimeGateTraditionalError test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":133,"column":12},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":156,"column":8},{"message":"The test400TimeGateFriendlyError test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":158,"column":12},{"message":"The data provider function \"acquireTimeMap404Urls\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":181,"column":8},{"message":"The test404TimeMapTraditionalError test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":183,"column":12},{"message":"The data provider function \"acquireTimeMap404Urls\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":194,"column":8},{"message":"The test404TimeMapFriendlyError test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":196,"column":12}]},"\/src\/repo\/Memento\/includes\/MementoResource.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/Memento\/includes\/TimeMapResource.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/integration\/MementoTest.php":{"errors":25,"warnings":23,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":10,"column":19},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":13,"column":9},{"message":"Method name \"StandardEntityTests\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":30,"column":12},{"message":"Method name \"Status302StyleTimeGateResponseCommonTests\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":41,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":56,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":62,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":62,"column":67},{"message":"Method name \"Status200StyleTimeGateMementoResponseCommonTests\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":100,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":115,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":120,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":120,"column":64},{"message":"Method name \"DirectOriginalResourceResponseCommonTests\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":153,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":168,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":174,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":174,"column":67},{"message":"Method name \"DirectMementoResponseCommonTests\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":206,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":221,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":227,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":227,"column":67},{"message":"Line exceeds 179 characters; contains 188 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":270,"column":188},{"message":"Line exceeds 179 characters; contains 186 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":273,"column":186},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":287,"column":8},{"message":"The testDirectMementoResponse test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":289,"column":12},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":315,"column":8},{"message":"The testDirectMementoResponseWithRecommendedHeaders test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":317,"column":12},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":346,"column":8},{"message":"The testDirectOriginalResourceResponse test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":348,"column":12},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":374,"column":8},{"message":"The testDirectOriginalResourceResponseWithRecommendedHeaders test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":376,"column":12},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":405,"column":8},{"message":"The test302StyleTimeGateResponse test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":407,"column":12},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":433,"column":8},{"message":"The test302StyleTimeGateResponseWithRecommendedHeaders test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":435,"column":12},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":464,"column":8},{"message":"The test200StyleTimeGateMementoResponse test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":466,"column":12},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":492,"column":8},{"message":"The test200StyleTimeGateMementoResponseWithRecommendedHeaders test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":494,"column":12},{"message":"The data provider function \"acquireEditUrls\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":523,"column":8},{"message":"The testEditPage test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":525,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":526,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":534,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":534,"column":64},{"message":"The phpunit annotation @dataProvider should not end with punctuation \"()\"","source":"MediaWiki.Commenting.PhpunitAnnotations.NotPunctuationDataProvider","severity":5,"fixable":true,"type":"WARNING","line":547,"column":8},{"message":"The data provider function \"acquireDiffUrls\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":547,"column":8},{"message":"The testDiffPage test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":549,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":550,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":558,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":558,"column":64}]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcbf
--- stdout ---
PHPCBF RESULT SUMMARY
----------------------------------------------------------------------
FILE FIXED REMAINING
----------------------------------------------------------------------
/src/repo/tests/integration/MementoTest.php 1 47
----------------------------------------------------------------------
A TOTAL OF 1 ERROR WERE FIXED IN 1 FILE
----------------------------------------------------------------------
Time: 731ms; Memory: 8MB
--- end ---
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":85,"warnings":59,"fixable":0},"files":{"\/src\/repo\/Memento\/includes\/Memento.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/data\/local-demo-wiki\/authentication-data.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/Memento\/Memento.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/Memento\/includes\/TimeMapPivotDescendingResource.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/Memento\/includes\/TimeGate.php":{"errors":0,"warnings":8,"messages":[{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":45,"column":25},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":46,"column":17},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":47,"column":19},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":48,"column":20},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":49,"column":24},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":50,"column":19},{"message":"Should use function $this->getConfig()->get() rather than global $wgMementoIncludeNamespaces","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":63,"column":16},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":69,"column":28}]},"\/src\/repo\/Memento\/includes\/TimeMapFullResource.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/Memento\/includes\/TimeMap.php":{"errors":0,"warnings":8,"messages":[{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":45,"column":24},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":46,"column":17},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":47,"column":19},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":48,"column":20},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":49,"column":24},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":50,"column":19},{"message":"Should use function $this->getConfig()->get() rather than global $wgMementoIncludeNamespaces","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":62,"column":16},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":68,"column":28}]},"\/src\/repo\/Memento\/includes\/OriginalResourceDirectlyAccessed.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/docker-image\/LocalSettings.php":{"errors":0,"warnings":4,"messages":[{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":44,"column":28},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":49,"column":28},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":50,"column":29},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":109,"column":21}]},"\/src\/repo\/tests\/integration\/SimpleTest.php":{"errors":1,"warnings":1,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":7,"column":19},{"message":"The testSimpleLittleTests test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":12,"column":12}]},"\/src\/repo\/Memento\/includes\/MementoResourceDirectlyAccessed.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/docker-image\/LocalSettings-1.27.5.php":{"errors":0,"warnings":4,"messages":[{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":44,"column":28},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":49,"column":28},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":50,"column":29},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":109,"column":21}]},"\/src\/repo\/Memento\/includes\/TimeGateResourceFrom302TimeNegotiation.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/lib\/MementoParse.php":{"errors":3,"warnings":0,"messages":[{"message":"Global function \"extractItemsFromLink()\" is lacking a valid prefix ('wf'). It should be wfExtractItemsFromLink().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":19,"column":1},{"message":"Global function \"extractItemsFromVary()\" is lacking a valid prefix ('wf'). It should be wfExtractItemsFromVary().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":69,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":69,"column":1}]},"\/src\/repo\/Memento\/includes\/TimeMapPivotAscendingResource.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/scripts\/CLI-GenerateCookieString.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/integration\/TimeMapTest.php":{"errors":11,"warnings":3,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":10,"column":19},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":13,"column":9},{"message":"The testSimpleTimeMap test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":34,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":35,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":52,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":52,"column":67},{"message":"The testSimpleIncreasingTimeMap test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":67,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":68,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":85,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":85,"column":67},{"message":"The testSimpleDecreasingTimeMap test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":100,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":101,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":118,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":118,"column":67}]},"\/src\/repo\/Memento\/includes\/TimeNegotiator.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/lib\/HTTPFetch.php":{"errors":21,"warnings":0,"messages":[{"message":"Global function \"extractHeadersFromResponse()\" is lacking a valid prefix ('wf'). It should be wfExtractHeadersFromResponse().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":11,"column":1},{"message":"Global function \"extractStatuslineFromResponse()\" is lacking a valid prefix ('wf'). It should be wfExtractStatuslineFromResponse().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":40,"column":1},{"message":"Global function \"extractEntityFromResponse()\" is lacking a valid prefix ('wf'). It should be wfExtractEntityFromResponse().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":68,"column":1},{"message":"Global function \"extractCookiesSetInResponse()\" is lacking a valid prefix ('wf'). It should be wfExtractCookiesSetInResponse().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":80,"column":1},{"message":"Global function \"authenticateWithMediawiki()\" is lacking a valid prefix ('wf'). It should be wfAuthenticateWithMediawiki().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":108,"column":1},{"message":"Global variable \"$mwLoginFormUrl\" is lacking an allowed prefix ('wg'). Should be \"$wgMwLoginFormUrl\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":109,"column":9},{"message":"Global variable \"$mwLoginActionUrl\" is lacking an allowed prefix ('wg'). Should be \"$wgMwLoginActionUrl\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":110,"column":9},{"message":"Global variable \"$wpName\" is lacking an allowed prefix ('wg'). Should be \"$wgWpName\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":111,"column":9},{"message":"Global variable \"$wpPassword\" is lacking an allowed prefix ('wg'). Should be \"$wgWpPassword\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":112,"column":9},{"message":"Global variable \"$wpLoginToken\" is lacking an allowed prefix ('wg'). Should be \"$wgWpLoginToken\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":113,"column":9},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":114,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":118,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":118,"column":72},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":138,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":138,"column":153},{"message":"Global function \"logOutOfMediawiki()\" is lacking a valid prefix ('wf'). It should be wfLogOutOfMediawiki().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":165,"column":1},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":166,"column":9},{"message":"Global variable \"$mwLogoutActionUrl\" is lacking an allowed prefix ('wg'). Should be \"$wgMwLogoutActionUrl\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":167,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":171,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":171,"column":101},{"message":"Global function \"extractHeadersStringFromResponse()\" is lacking a valid prefix ('wf'). It should be wfExtractHeadersStringFromResponse().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":179,"column":1}]},"\/src\/repo\/tests\/lib\/TestSupport.php":{"errors":10,"warnings":1,"messages":[{"message":"Global function \"acquireLinesFromFile()\" is lacking a valid prefix ('wf'). It should be wfAcquireLinesFromFile().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":3,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":3,"column":1},{"message":"Global function \"acquireCSVDataFromFile()\" is lacking a valid prefix ('wf'). It should be wfAcquireCSVDataFromFile().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":21,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":21,"column":1},{"message":"Global function \"objectToArray()\" is lacking a valid prefix ('wf'). It should be wfObjectToArray().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":47,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":47,"column":1},{"message":"Global function \"acquireFormattedI18NString()\" is lacking a valid prefix ('wf'). It should be wfAcquireFormattedI18NString().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":69,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":69,"column":1},{"message":"Global function \"diffStrings()\" is lacking a valid prefix ('wf'). It should be wfDiffStrings().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":92,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":92,"column":1},{"message":"eval should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.eval","severity":5,"fixable":false,"type":"WARNING","line":117,"column":55}]},"\/src\/repo\/tests\/integration\/ErrorStateTest.php":{"errors":14,"warnings":8,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":10,"column":19},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":13,"column":9},{"message":"Method name \"Status400TimeGateErrorResponseCommonTests\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":30,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":33,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":39,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":39,"column":64},{"message":"Method name \"Status404TimeMapErrorResponseCommonTests\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":69,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":72,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":77,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":77,"column":64},{"message":"Method name \"Status400TimeMapErrorResponseCommonTests\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":98,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":101,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":106,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":106,"column":64},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":131,"column":8},{"message":"The test400TimeGateTraditionalError test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":133,"column":12},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":156,"column":8},{"message":"The test400TimeGateFriendlyError test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":158,"column":12},{"message":"The data provider function \"acquireTimeMap404Urls\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":181,"column":8},{"message":"The test404TimeMapTraditionalError test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":183,"column":12},{"message":"The data provider function \"acquireTimeMap404Urls\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":194,"column":8},{"message":"The test404TimeMapFriendlyError test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":196,"column":12}]},"\/src\/repo\/Memento\/includes\/MementoResource.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/Memento\/includes\/TimeMapResource.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/integration\/MementoTest.php":{"errors":25,"warnings":22,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":10,"column":19},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":13,"column":9},{"message":"Method name \"StandardEntityTests\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":30,"column":12},{"message":"Method name \"Status302StyleTimeGateResponseCommonTests\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":41,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":56,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":62,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":62,"column":67},{"message":"Method name \"Status200StyleTimeGateMementoResponseCommonTests\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":100,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":115,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":120,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":120,"column":64},{"message":"Method name \"DirectOriginalResourceResponseCommonTests\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":153,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":168,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":174,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":174,"column":67},{"message":"Method name \"DirectMementoResponseCommonTests\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":206,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":221,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":227,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":227,"column":67},{"message":"Line exceeds 179 characters; contains 188 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":270,"column":188},{"message":"Line exceeds 179 characters; contains 186 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":273,"column":186},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":287,"column":8},{"message":"The testDirectMementoResponse test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":289,"column":12},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":315,"column":8},{"message":"The testDirectMementoResponseWithRecommendedHeaders test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":317,"column":12},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":346,"column":8},{"message":"The testDirectOriginalResourceResponse test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":348,"column":12},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":374,"column":8},{"message":"The testDirectOriginalResourceResponseWithRecommendedHeaders test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":376,"column":12},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":405,"column":8},{"message":"The test302StyleTimeGateResponse test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":407,"column":12},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":433,"column":8},{"message":"The test302StyleTimeGateResponseWithRecommendedHeaders test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":435,"column":12},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":464,"column":8},{"message":"The test200StyleTimeGateMementoResponse test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":466,"column":12},{"message":"The data provider function \"acquireTimeNegotiationData\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":492,"column":8},{"message":"The test200StyleTimeGateMementoResponseWithRecommendedHeaders test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":494,"column":12},{"message":"The data provider function \"acquireEditUrls\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":523,"column":8},{"message":"The testEditPage test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":525,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":526,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":534,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":534,"column":64},{"message":"The data provider function \"acquireDiffUrls\" should start with \"provide\" or end with \"Provider\".","source":"MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName","severity":5,"fixable":false,"type":"WARNING","line":547,"column":8},{"message":"The testDiffPage test method has no @covers tags","source":"MediaWiki.Commenting.MissingCovers.MissingCovers","severity":5,"fixable":false,"type":"WARNING","line":549,"column":12},{"message":"Global variable \"$sessionCookieString\" is lacking an allowed prefix ('wg'). Should be \"$wgSessionCookieString\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":550,"column":9},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":558,"column":21},{"message":"Use of the backtick operator is forbidden","source":"Generic.PHP.BacktickOperator.Found","severity":5,"fixable":false,"type":"ERROR","line":558,"column":64}]}}}
--- end ---
* sniff MediaWiki.Commenting.FunctionComment.WrongStyle is no longer failing
* sniff MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName is now failing
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
14 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> composer lint
> parallel-lint . --exclude vendor --exclude node_modules
> composer phpcs
> phpcs -p -s
> minus-x check .
--- stdout ---
PHP 8.2.28 | 10 parallel jobs
........................ 24/24 (100%)
Checked 24 files in 0.1 seconds
No syntax error found
........................ 24 / 24 (100%)
Time: 503ms; Memory: 8MB
MinusX
======
Processing /src/repo...
.............................................................
..
All good!
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 315,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 315
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 47.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName
The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment.WrongStyle
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpfy_jr7h9
--- stdout ---
[master 8d6d95f] build: Updating mediawiki/mediawiki-codesniffer to 47.0.0
3 files changed, 3 insertions(+), 3 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 8d6d95fd23172fb12852eaac1f49d495c211d8b6 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Thu, 8 May 2025 09:27:41 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 47.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName
The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment.WrongStyle
Change-Id: I5620a54f0ca78a6374a6dca9c464839b22228db7
---
.phpcs.xml | 2 +-
composer.json | 2 +-
tests/integration/MementoTest.php | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index ef19566..9938667 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -3,13 +3,13 @@
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="Generic.Files.LineLength.TooLong" />
<exclude name="MediaWiki.Commenting.MissingCovers.MissingCovers" />
+ <exclude name="MediaWiki.Commenting.PhpunitAnnotations.WrongDataProviderName" />
<exclude name="MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic" />
<exclude name="Generic.PHP.BacktickOperator.Found" />
<exclude name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName" />
<exclude name="MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix" />
<exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
- <exclude name="MediaWiki.Commenting.FunctionComment.WrongStyle" />
<exclude name="MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix" />
<exclude name="MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage" />
<exclude name="MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage" />
diff --git a/composer.json b/composer.json
index ed04483..f3733fa 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "46.0.0",
+ "mediawiki/mediawiki-codesniffer": "47.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0"
diff --git a/tests/integration/MementoTest.php b/tests/integration/MementoTest.php
index 2b52857..e0378d0 100644
--- a/tests/integration/MementoTest.php
+++ b/tests/integration/MementoTest.php
@@ -544,7 +544,7 @@ class MementoTest extends PHPUnit\Framework\TestCase {
/**
* @group all
*
- * @dataProvider acquireDiffUrls()
+ * @dataProvider acquireDiffUrls
*/
public function testDiffPage( $URIR ) {
global $sessionCookieString;
--
2.39.5
--- end ---