This run took 30 seconds.
From 1283a236c36fa21f1cdd4bf1706e45ad2b9a749c Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Mon, 8 Sep 2025 04:11:10 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation
* MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter
Change-Id: I4b86de05bb6c4f2c726d84ff594c4c12709e4441
---
.phpcs.xml | 2 ++
composer.json | 2 +-
src/Control/ConsumerAcceptanceSubmitControl.php | 2 +-
src/Control/ConsumerSubmitControl.php | 2 +-
src/Rest/Handler/ListClients.php | 1 -
5 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index a144921..2a636ca 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,6 +1,8 @@
<?xml version="1.0"?>
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude name="MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation" />
+ <exclude name="MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter" />
<exclude name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName" />
</rule>
<file>.</file>
diff --git a/composer.json b/composer.json
index 5a906c3..a11a085 100644
--- a/composer.json
+++ b/composer.json
@@ -18,7 +18,7 @@
},
"require-dev": {
"ext-curl": "*",
- "mediawiki/mediawiki-codesniffer": "47.0.0",
+ "mediawiki/mediawiki-codesniffer": "48.0.0",
"mediawiki/mediawiki-phan-config": "0.17.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
diff --git a/src/Control/ConsumerAcceptanceSubmitControl.php b/src/Control/ConsumerAcceptanceSubmitControl.php
index 62b6a4c..c0c6716 100644
--- a/src/Control/ConsumerAcceptanceSubmitControl.php
+++ b/src/Control/ConsumerAcceptanceSubmitControl.php
@@ -39,7 +39,7 @@ use Wikimedia\Rdbms\IDatabase;
*
* This control can be used on any wiki, not just the management one
*
- * @TODO: improve error messages
+ * @todo improve error messages
*/
class ConsumerAcceptanceSubmitControl extends SubmitControl {
/** @var IDatabase */
diff --git a/src/Control/ConsumerSubmitControl.php b/src/Control/ConsumerSubmitControl.php
index 5725a75..94fd644 100644
--- a/src/Control/ConsumerSubmitControl.php
+++ b/src/Control/ConsumerSubmitControl.php
@@ -56,7 +56,7 @@ use Wikimedia\Rdbms\SelectQueryBuilder;
*
* This control can only be used on the management wiki
*
- * @TODO: improve error messages
+ * @todo improve error messages
*/
class ConsumerSubmitControl extends SubmitControl {
/**
diff --git a/src/Rest/Handler/ListClients.php b/src/Rest/Handler/ListClients.php
index 89f5c39..671aa38 100644
--- a/src/Rest/Handler/ListClients.php
+++ b/src/Rest/Handler/ListClients.php
@@ -50,7 +50,6 @@ class ListClients extends SimpleHandler {
];
/**
- *
* @var ILoadBalancer
*/
private $loadBalancer;
--
2.39.5
$ date
--- stdout ---
Mon Sep 8 04:10:46 UTC 2025
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-OAuth.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
afa1f40b268b02d5f4b3d9f0fc8a993d96518fc0 refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 455,
"optional": 4,
"peer": 5,
"peerOptional": 0,
"total": 455
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 50 installs, 0 updates, 0 removals
- Locking composer/pcre (3.3.2)
- Locking composer/semver (3.4.3)
- Locking composer/spdx-licenses (1.5.9)
- Locking composer/xdebug-handler (3.0.5)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.1.2)
- Locking defuse/php-encryption (v2.4.0)
- Locking doctrine/deprecations (1.1.5)
- Locking felixfbecker/advanced-json-rpc (v3.2.1)
- Locking firebase/php-jwt (v6.11.1)
- Locking lcobucci/clock (2.3.0)
- Locking lcobucci/jwt (4.1.5)
- Locking league/event (2.3.0)
- Locking league/oauth2-server (dev-v9.0.0-alpha 61d770d)
- Locking league/uri (6.8.0)
- Locking league/uri-interfaces (2.3.0)
- Locking mediawiki/mediawiki-codesniffer (v47.0.0)
- Locking mediawiki/mediawiki-phan-config (0.17.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking mediawiki/phan-taint-check-plugin (7.0.0)
- Locking microsoft/tolerant-php-parser (v0.1.2)
- Locking netresearch/jsonmapper (v4.5.0)
- Locking paragonie/random_compat (v9.99.100)
- Locking phan/phan (5.5.1)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.12)
- Locking phpdocumentor/reflection-common (2.2.0)
- Locking phpdocumentor/reflection-docblock (5.6.3)
- Locking phpdocumentor/type-resolver (1.10.0)
- Locking phpstan/phpdoc-parser (2.3.0)
- Locking psr/clock (1.0.0)
- Locking psr/container (2.0.2)
- Locking psr/http-message (1.1)
- Locking psr/log (3.0.2)
- Locking sabre/event (5.1.7)
- Locking squizlabs/php_codesniffer (3.12.2)
- Locking stella-maris/clock (0.1.7)
- Locking symfony/console (v7.3.3)
- Locking symfony/deprecation-contracts (v3.6.0)
- Locking symfony/polyfill-ctype (v1.33.0)
- Locking symfony/polyfill-intl-grapheme (v1.33.0)
- Locking symfony/polyfill-intl-normalizer (v1.33.0)
- Locking symfony/polyfill-mbstring (v1.33.0)
- Locking symfony/polyfill-php80 (v1.33.0)
- Locking symfony/service-contracts (v3.6.0)
- Locking symfony/string (v7.3.3)
- Locking tysonandre/var_representation_polyfill (0.1.3)
- Locking webmozart/assert (1.11.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 50 installs, 0 updates, 0 removals
- Downloading league/uri-interfaces (2.3.0)
- Downloading league/uri (6.8.0)
- Downloading league/event (2.3.0)
- Syncing league/oauth2-server (dev-v9.0.0-alpha 61d770d) into cache
0/3 [>---------------------------] 0%
2/3 [==================>---------] 66%
3/3 [============================] 100%
- Installing squizlabs/php_codesniffer (3.12.2): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.1.2): Extracting archive
- Installing composer/pcre (3.3.2): Extracting archive
- Installing firebase/php-jwt (v6.11.1): Extracting archive
- Installing psr/clock (1.0.0): Extracting archive
- Installing stella-maris/clock (0.1.7): Extracting archive
- Installing lcobucci/clock (2.3.0): Extracting archive
- Installing psr/http-message (1.1): Extracting archive
- Installing league/uri-interfaces (2.3.0): Extracting archive
- Installing league/uri (6.8.0): Extracting archive
- Installing league/event (2.3.0): Extracting archive
- Installing symfony/polyfill-mbstring (v1.33.0): Extracting archive
- Installing lcobucci/jwt (4.1.5): Extracting archive
- Installing paragonie/random_compat (v9.99.100): Extracting archive
- Installing defuse/php-encryption (v2.4.0): Extracting archive
- Installing league/oauth2-server (dev-v9.0.0-alpha 61d770d): Cloning 61d770dc28 from cache
- Installing symfony/polyfill-php80 (v1.33.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.12): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing composer/spdx-licenses (1.5.9): Extracting archive
- Installing composer/semver (3.4.3): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v47.0.0): Extracting archive
- Installing tysonandre/var_representation_polyfill (0.1.3): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.33.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.33.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.33.0): Extracting archive
- Installing symfony/string (v7.3.3): Extracting archive
- Installing symfony/deprecation-contracts (v3.6.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.6.0): Extracting archive
- Installing symfony/console (v7.3.3): Extracting archive
- Installing sabre/event (5.1.7): Extracting archive
- Installing netresearch/jsonmapper (v4.5.0): Extracting archive
- Installing microsoft/tolerant-php-parser (v0.1.2): Extracting archive
- Installing webmozart/assert (1.11.0): Extracting archive
- Installing phpstan/phpdoc-parser (2.3.0): Extracting archive
- Installing phpdocumentor/reflection-common (2.2.0): Extracting archive
- Installing doctrine/deprecations (1.1.5): Extracting archive
- Installing phpdocumentor/type-resolver (1.10.0): Extracting archive
- Installing phpdocumentor/reflection-docblock (5.6.3): Extracting archive
- Installing felixfbecker/advanced-json-rpc (v3.2.1): Extracting archive
- Installing psr/log (3.0.2): Extracting archive
- Installing composer/xdebug-handler (3.0.5): Extracting archive
- Installing phan/phan (5.5.1): Extracting archive
- Installing mediawiki/phan-taint-check-plugin (7.0.0): Extracting archive
- Installing mediawiki/mediawiki-phan-config (0.17.0): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/47 [>---------------------------] 0%
21/47 [============>---------------] 44%
33/47 [===================>--------] 70%
46/47 [===========================>] 97%
47/47 [============================] 100%
6 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating autoload files
21 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 47.0.0 -> 48.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 5 updates, 0 removals
- Upgrading composer/semver (3.4.3 => 3.4.4)
- Upgrading mediawiki/mediawiki-codesniffer (v47.0.0 => v48.0.0)
- Upgrading phpcsstandards/phpcsextra (1.2.1 => 1.4.0)
- Upgrading phpcsstandards/phpcsutils (1.0.12 => 1.1.1)
- Upgrading squizlabs/php_codesniffer (3.12.2 => 3.13.2)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 5 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.12.2 => 3.13.2): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.0.12 => 1.1.1): Extracting archive
- Upgrading phpcsstandards/phpcsextra (1.2.1 => 1.4.0): Extracting archive
- Upgrading composer/semver (3.4.3 => 3.4.4): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v47.0.0 => v48.0.0): Extracting archive
0/5 [>---------------------------] 0%
4/5 [======================>-----] 80%
5/5 [============================] 100%
Generating autoload files
21 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: {'MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName'}
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":20,"warnings":3,"fixable":3},"files":{"\/src\/repo\/src\/Repository\/Hook\/OAuthClaimStoreGetClaimsHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/UIUtils.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/MWOAuthSignatureMethodRsaSha1.php":{"errors":2,"warnings":0,"messages":[{"message":"Method name \"fetch_public_cert\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":43,"column":15},{"message":"Method name \"fetch_private_cert\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":55,"column":15}]},"\/src\/repo\/src\/Control\/Workflow.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/MWOA.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthorizationProvider\/Grant\/ClientCredentials.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthorizationProvider\/Grant\/RefreshToken.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/Pagers\/ManageMyGrantsPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Exception\/ClientApprovalDenyException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/Pagers\/ListMyConsumersPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthorizationProvider\/Grant\/AuthorizationCodeAccessTokens.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Repository\/ClaimStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Repository\/CacheRepository.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/UpdaterHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthorizationProvider\/IAuthorizationProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthorizationProvider\/IAccessTokenProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Repository\/AuthCodeRepository.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Control\/ConsumerAcceptanceAccessControl.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Repository\/RefreshTokenRepository.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Repository\/ClientRepository.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Control\/DAOAccessControl.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/HookRunner.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Entity\/UserEntity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Entity\/ClaimEntity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthorizationProvider\/AccessToken.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Repository\/DatabaseRepository.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/Pagers\/ManageConsumersPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Entity\/RefreshTokenEntity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Entity\/MWClientEntityInterface.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthorizationProvider\/Grant\/AuthorizationCodeAuthorization.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/Pagers\/ListConsumersPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/EchoOAuthStageChangePresentationModel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/OAuthLogFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/Hooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Setup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Response.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthorizationProvider\/AuthorizationProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Repository\/ScopeRepository.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthorizationServerFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Control\/ConsumerAccessControl.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/MWOAuthDataStore.php":{"errors":5,"warnings":0,"messages":[{"message":"Method name \"lookup_consumer\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":64,"column":12},{"message":"Method name \"lookup_token\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":77,"column":12},{"message":"Method name \"lookup_nonce\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":148,"column":12},{"message":"Method name \"new_request_token\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":186,"column":12},{"message":"Method name \"new_access_token\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":249,"column":12}]},"\/src\/repo\/src\/Backend\/MWOAuthRequest.php":{"errors":1,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":10,"column":4}]},"\/src\/repo\/tests\/phpunit\/TestHandlerFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/HookRunnerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Repository\/AccessTokenRepository.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Repository\/ScopeRepositoryTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/OAuth1Consumer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/Handler\/AccessToken.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Entity\/ClaimEntityTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Entity\/UserEntityTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/MWOAuthServer.php":{"errors":3,"warnings":0,"messages":[{"message":"Method name \"fetch_request_token\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":34,"column":12},{"message":"Method name \"fetch_access_token\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":241,"column":12},{"message":"Method name \"verify_request\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":305,"column":12}]},"\/src\/repo\/maintenance\/migrateCentralWiki.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Entity\/AccessTokenEntity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Backend\/MWOAuthServerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/ConsumerAcceptance.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Entity\/AuthCodeEntity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/Handler\/ResetClientSecret.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/MWOAuth.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/Handler\/RequestClient.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Entity\/ClientEntity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Backend\/MWOAuthHooksTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/OAuthServices.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/MWOAuthToken.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Entity\/ScopeEntity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Repository\/AuthCodeRepositoryTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Entity\/AccessTokenEntityTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Control\/ConsumerAcceptanceSubmitControl.php":{"errors":0,"warnings":1,"messages":[{"message":"Use @todo annotation instead of @TODO:","source":"MediaWiki.Commenting.ClassAnnotations.NonNormalizedAnnotation","severity":5,"fixable":true,"type":"WARNING","line":42,"column":4}]},"\/src\/repo\/tests\/phpunit\/Entity\/MockClientEntity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/MWOAuthException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Repository\/AccessTokenRepositoryTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/Handler\/AbstractClientHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Backend\/MWOAuthExceptionTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/UserStatementProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/examples\/testClientHeaders.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Rest\/AccessTokenEndpointTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Repository\/ClaimStoreTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Entity\/ClientEntityTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/testOAuthConsumer.php":{"errors":4,"warnings":0,"messages":[{"message":"Method name \"fetch_public_cert\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":96,"column":31},{"message":"Method name \"fetch_public_cert\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":96,"column":31},{"message":"Method name \"fetch_private_cert\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":101,"column":31},{"message":"Method name \"fetch_private_cert\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":101,"column":31}]},"\/src\/repo\/src\/Rest\/Handler\/ListClients.php":{"errors":0,"warnings":1,"messages":[{"message":"Doc comments must not start with multiple empty lines","source":"MediaWiki.Commenting.PropertyDocumentation.EmptyLinesStart","severity":5,"fixable":true,"type":"WARNING","line":52,"column":5}]},"\/src\/repo\/maintenance\/migrateCentralWikiLogs.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/AuthorizationProviderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Rest\/AuthorizationEndpointTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/examples\/testClient.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Control\/WorkflowTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/Handler\/Resource.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/MWOAuthDAO.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Rest\/ResetClientSecretEndpointTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/UserStatementProviderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Control\/SubmitControl.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/Utils.php":{"errors":2,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":23,"column":4},{"message":"There must be at least a blank line between a file-level comment and a class. Make sure you are not mixing file-level comments (like license headers) and class documentation","source":"MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":25,"column":2}]},"\/src\/repo\/src\/Frontend\/UIHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Rest\/EndpointTestBase.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/SessionProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/Handler\/AuthenticationHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Rest\/ListClientsEndpointTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/SpecialPages\/SpecialMWOAuthListConsumers.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/AbuseFilterHookHandler.php":{"errors":3,"warnings":0,"messages":[{"message":"Method name \"onAbuseFilter_builder\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":40,"column":12},{"message":"Method name \"onAbuseFilter_computeVariable\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":46,"column":12},{"message":"Method name \"onAbuseFilter_generateUserVars\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":74,"column":12}]},"\/src\/repo\/tests\/phpunit\/SessionProviderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/createOAuthConsumer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Control\/ConsumerSubmitControlTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ResourceServer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Rest\/RequestClientEndpointTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/SpecialPages\/SpecialMWOAuthManageConsumers.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/Handler\/Authorize.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/SpecialPages\/SpecialMWOAuthManageMyGrants.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/SpecialPages\/SpecialMWOAuth.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/Consumer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Control\/ConsumerSubmitControl.php":{"errors":0,"warnings":1,"messages":[{"message":"Use @todo annotation instead of @TODO:","source":"MediaWiki.Commenting.ClassAnnotations.NonNormalizedAnnotation","severity":5,"fixable":true,"type":"WARNING","line":59,"column":4}]},"\/src\/repo\/src\/Frontend\/SpecialPages\/SpecialMWOAuthConsumerRegistration.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcbf
--- stdout ---
PHPCBF RESULT SUMMARY
------------------------------------------------------------------------------
FILE FIXED REMAINING
------------------------------------------------------------------------------
/src/repo/src/Rest/Handler/ListClients.php 1 0
/src/repo/src/Control/ConsumerAcceptanceSubmitControl.php 1 0
/src/repo/src/Control/ConsumerSubmitControl.php 1 0
------------------------------------------------------------------------------
A TOTAL OF 3 ERRORS WERE FIXED IN 3 FILES
------------------------------------------------------------------------------
Time: 2.04 secs; Memory: 8MB
--- end ---
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":20,"warnings":0,"fixable":0},"files":{"\/src\/repo\/src\/Frontend\/UIUtils.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Repository\/Hook\/OAuthClaimStoreGetClaimsHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Control\/Workflow.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/MWOAuthSignatureMethodRsaSha1.php":{"errors":2,"warnings":0,"messages":[{"message":"Method name \"fetch_public_cert\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":43,"column":15},{"message":"Method name \"fetch_private_cert\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":55,"column":15}]},"\/src\/repo\/src\/AuthorizationProvider\/Grant\/ClientCredentials.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/MWOA.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Exception\/ClientApprovalDenyException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthorizationProvider\/IAccessTokenProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthorizationProvider\/Grant\/RefreshToken.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Repository\/ClaimStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthorizationProvider\/Grant\/AuthorizationCodeAccessTokens.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Repository\/AuthCodeRepository.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthorizationProvider\/IAuthorizationProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/HookRunner.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Repository\/CacheRepository.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/Pagers\/ListMyConsumersPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Repository\/ClientRepository.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/UpdaterHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthorizationProvider\/AccessToken.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Control\/DAOAccessControl.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Control\/ConsumerAcceptanceAccessControl.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/Pagers\/ListConsumersPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Entity\/RefreshTokenEntity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Entity\/MWClientEntityInterface.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Repository\/RefreshTokenRepository.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/Pagers\/ManageMyGrantsPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Repository\/DatabaseRepository.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Entity\/UserEntity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Entity\/ClaimEntity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/EchoOAuthStageChangePresentationModel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthorizationProvider\/Grant\/AuthorizationCodeAuthorization.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Setup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/Hooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/OAuthLogFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Repository\/ScopeRepository.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthorizationServerFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/Pagers\/ManageConsumersPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Control\/ConsumerAccessControl.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Repository\/AccessTokenRepository.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Response.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/HookRunnerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Repository\/ScopeRepositoryTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthorizationProvider\/AuthorizationProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/TestHandlerFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/MWOAuthRequest.php":{"errors":1,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":10,"column":4}]},"\/src\/repo\/src\/Rest\/Handler\/ResetClientSecret.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/MWOAuthDataStore.php":{"errors":5,"warnings":0,"messages":[{"message":"Method name \"lookup_consumer\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":64,"column":12},{"message":"Method name \"lookup_token\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":77,"column":12},{"message":"Method name \"lookup_nonce\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":148,"column":12},{"message":"Method name \"new_request_token\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":186,"column":12},{"message":"Method name \"new_access_token\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":249,"column":12}]},"\/src\/repo\/src\/Entity\/AccessTokenEntity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Repository\/AuthCodeRepositoryTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Control\/ConsumerAcceptanceSubmitControl.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/Handler\/AccessToken.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/OAuthServices.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Backend\/MWOAuthServerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Entity\/AuthCodeEntity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/migrateCentralWiki.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/ConsumerAcceptance.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Repository\/AccessTokenRepositoryTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Entity\/ClaimEntityTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Entity\/MockClientEntity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Entity\/UserEntityTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/Handler\/AbstractClientHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Entity\/ClientEntity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/MWOAuthServer.php":{"errors":3,"warnings":0,"messages":[{"message":"Method name \"fetch_request_token\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":34,"column":12},{"message":"Method name \"fetch_access_token\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":241,"column":12},{"message":"Method name \"verify_request\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":305,"column":12}]},"\/src\/repo\/src\/Entity\/ScopeEntity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Backend\/MWOAuthHooksTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/OAuth1Consumer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/UserStatementProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/MWOAuthToken.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/Handler\/RequestClient.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Entity\/AccessTokenEntityTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Rest\/AccessTokenEndpointTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/MWOAuth.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Repository\/ClaimStoreTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/MWOAuthException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/Handler\/ListClients.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/examples\/testClientHeaders.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/testOAuthConsumer.php":{"errors":4,"warnings":0,"messages":[{"message":"Method name \"fetch_public_cert\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":96,"column":31},{"message":"Method name \"fetch_public_cert\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":96,"column":31},{"message":"Method name \"fetch_private_cert\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":101,"column":31},{"message":"Method name \"fetch_private_cert\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":101,"column":31}]},"\/src\/repo\/tests\/phpunit\/unit\/Control\/WorkflowTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Backend\/MWOAuthExceptionTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Entity\/ClientEntityTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Rest\/AuthorizationEndpointTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/AuthorizationProviderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/UserStatementProviderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Control\/SubmitControl.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/Handler\/Resource.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/UIHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/migrateCentralWikiLogs.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/examples\/testClient.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Rest\/ListClientsEndpointTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/MWOAuthDAO.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/SessionProviderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/Utils.php":{"errors":2,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":23,"column":4},{"message":"There must be at least a blank line between a file-level comment and a class. Make sure you are not mixing file-level comments (like license headers) and class documentation","source":"MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":25,"column":2}]},"\/src\/repo\/src\/SessionProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/AbuseFilterHookHandler.php":{"errors":3,"warnings":0,"messages":[{"message":"Method name \"onAbuseFilter_builder\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":40,"column":12},{"message":"Method name \"onAbuseFilter_computeVariable\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":46,"column":12},{"message":"Method name \"onAbuseFilter_generateUserVars\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":74,"column":12}]},"\/src\/repo\/src\/Rest\/Handler\/AuthenticationHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/SpecialPages\/SpecialMWOAuthListConsumers.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Rest\/RequestClientEndpointTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Rest\/ResetClientSecretEndpointTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/createOAuthConsumer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/SpecialPages\/SpecialMWOAuthManageConsumers.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/Handler\/Authorize.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Control\/ConsumerSubmitControlTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Rest\/EndpointTestBase.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ResourceServer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/SpecialPages\/SpecialMWOAuth.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/SpecialPages\/SpecialMWOAuthManageMyGrants.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Control\/ConsumerSubmitControl.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Frontend\/SpecialPages\/SpecialMWOAuthConsumerRegistration.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Backend\/Consumer.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
* sniff MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter is now failing
* sniff MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation is now failing
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
21 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> phpcs -sp --cache
> minus-x check .
--- stdout ---
PHP 8.2.28 | 10 parallel jobs
............................................................ 60/133 ( 45%)
............................................................ 120/133 ( 90%)
............. 133/133 (100%)
Checked 133 files in 0.5 seconds
No syntax error found
........................................................ 56 / 56 (100%)
Time: 491ms; Memory: 12MB
MinusX
======
Processing /src/repo...
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
..................................
All good!
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 455,
"optional": 4,
"peer": 5,
"peerOptional": 0,
"total": 455
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 48.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation
* MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmprdq3j6wl
--- stdout ---
[master 1283a23] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0
5 files changed, 5 insertions(+), 4 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 1283a236c36fa21f1cdd4bf1706e45ad2b9a749c Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Mon, 8 Sep 2025 04:11:10 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation
* MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter
Change-Id: I4b86de05bb6c4f2c726d84ff594c4c12709e4441
---
.phpcs.xml | 2 ++
composer.json | 2 +-
src/Control/ConsumerAcceptanceSubmitControl.php | 2 +-
src/Control/ConsumerSubmitControl.php | 2 +-
src/Rest/Handler/ListClients.php | 1 -
5 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index a144921..2a636ca 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,6 +1,8 @@
<?xml version="1.0"?>
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude name="MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation" />
+ <exclude name="MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter" />
<exclude name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName" />
</rule>
<file>.</file>
diff --git a/composer.json b/composer.json
index 5a906c3..a11a085 100644
--- a/composer.json
+++ b/composer.json
@@ -18,7 +18,7 @@
},
"require-dev": {
"ext-curl": "*",
- "mediawiki/mediawiki-codesniffer": "47.0.0",
+ "mediawiki/mediawiki-codesniffer": "48.0.0",
"mediawiki/mediawiki-phan-config": "0.17.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
diff --git a/src/Control/ConsumerAcceptanceSubmitControl.php b/src/Control/ConsumerAcceptanceSubmitControl.php
index 62b6a4c..c0c6716 100644
--- a/src/Control/ConsumerAcceptanceSubmitControl.php
+++ b/src/Control/ConsumerAcceptanceSubmitControl.php
@@ -39,7 +39,7 @@ use Wikimedia\Rdbms\IDatabase;
*
* This control can be used on any wiki, not just the management one
*
- * @TODO: improve error messages
+ * @todo improve error messages
*/
class ConsumerAcceptanceSubmitControl extends SubmitControl {
/** @var IDatabase */
diff --git a/src/Control/ConsumerSubmitControl.php b/src/Control/ConsumerSubmitControl.php
index 5725a75..94fd644 100644
--- a/src/Control/ConsumerSubmitControl.php
+++ b/src/Control/ConsumerSubmitControl.php
@@ -56,7 +56,7 @@ use Wikimedia\Rdbms\SelectQueryBuilder;
*
* This control can only be used on the management wiki
*
- * @TODO: improve error messages
+ * @todo improve error messages
*/
class ConsumerSubmitControl extends SubmitControl {
/**
diff --git a/src/Rest/Handler/ListClients.php b/src/Rest/Handler/ListClients.php
index 89f5c39..671aa38 100644
--- a/src/Rest/Handler/ListClients.php
+++ b/src/Rest/Handler/ListClients.php
@@ -50,7 +50,6 @@ class ListClients extends SimpleHandler {
];
/**
- *
* @var ILoadBalancer
*/
private $loadBalancer;
--
2.39.5
--- end ---