This run took 20 seconds.
From 114c13ade6c6ac1edae91523c092657dfd834acb Mon Sep 17 00:00:00 2001 From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org> Date: Wed, 10 Sep 2025 03:05:47 +0000 Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0 The following sniffs are failing and were disabled: * MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation * MediaWiki.Commenting.CommentBeforeClass.SpacingAfter * MediaWiki.Commenting.CommentBeforeClass.StrayStyle Change-Id: I7ae580cf122c7caeca01b32af686a24fbaa83ccf --- .phpcs.xml | 6 +++++- composer.json | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.phpcs.xml b/.phpcs.xml index a9de689..ad35505 100644 --- a/.phpcs.xml +++ b/.phpcs.xml @@ -1,6 +1,10 @@ <?xml version="1.0"?> <ruleset> - <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" /> + <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki"> + <exclude name="MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation" /> + <exclude name="MediaWiki.Commenting.CommentBeforeClass.SpacingAfter" /> + <exclude name="MediaWiki.Commenting.CommentBeforeClass.StrayStyle" /> + </rule> <rule ref="Generic.Files.LineLength"> <exclude-pattern>MassMessage\.alias\.php</exclude-pattern> </rule> diff --git a/composer.json b/composer.json index 60615dd..01e1704 100644 --- a/composer.json +++ b/composer.json @@ -1,6 +1,6 @@ { "require-dev": { - "mediawiki/mediawiki-codesniffer": "47.0.0", + "mediawiki/mediawiki-codesniffer": "48.0.0", "mediawiki/mediawiki-phan-config": "0.17.0", "mediawiki/minus-x": "1.1.3", "php-parallel-lint/php-console-highlighter": "1.0.0", -- 2.39.5
$ date --- stdout --- Wed Sep 10 03:05:34 UTC 2025 --- end --- $ git clone file:///srv/git/mediawiki-extensions-MassMessage.git repo --depth=1 -b master --- stderr --- Cloning into 'repo'... --- stdout --- --- end --- $ git config user.name libraryupgrader --- stdout --- --- end --- $ git config user.email tools.libraryupgrader@tools.wmflabs.org --- stdout --- --- end --- $ git submodule update --init --- stdout --- --- end --- $ grr init --- stdout --- Installed commit-msg hook. --- end --- $ git show-ref refs/heads/master --- stdout --- 9405023a287437dff4ab4480f709104a6bdfac04 refs/heads/master --- end --- $ /usr/bin/npm audit --json --- stdout --- { "auditReportVersion": 2, "vulnerabilities": {}, "metadata": { "vulnerabilities": { "info": 0, "low": 0, "moderate": 0, "high": 0, "critical": 0, "total": 0 }, "dependencies": { "prod": 1, "dev": 455, "optional": 4, "peer": 5, "peerOptional": 0, "total": 455 } } } --- end --- $ /usr/bin/composer install --- stderr --- No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information. Loading composer repositories with package information Updating dependencies Lock file operations: 38 installs, 0 updates, 0 removals - Locking composer/pcre (3.3.2) - Locking composer/semver (3.4.3) - Locking composer/spdx-licenses (1.5.9) - Locking composer/xdebug-handler (3.0.5) - Locking dealerdirect/phpcodesniffer-composer-installer (v1.1.2) - Locking doctrine/deprecations (1.1.5) - Locking felixfbecker/advanced-json-rpc (v3.2.1) - Locking mediawiki/mediawiki-codesniffer (v47.0.0) - Locking mediawiki/mediawiki-phan-config (0.17.0) - Locking mediawiki/minus-x (1.1.3) - Locking mediawiki/phan-taint-check-plugin (7.0.0) - Locking microsoft/tolerant-php-parser (v0.1.2) - Locking netresearch/jsonmapper (v4.5.0) - Locking phan/phan (5.5.1) - Locking php-parallel-lint/php-console-color (v1.0.1) - Locking php-parallel-lint/php-console-highlighter (v1.0.0) - Locking php-parallel-lint/php-parallel-lint (v1.4.0) - Locking phpcsstandards/phpcsextra (1.2.1) - Locking phpcsstandards/phpcsutils (1.0.12) - Locking phpdocumentor/reflection-common (2.2.0) - Locking phpdocumentor/reflection-docblock (5.6.3) - Locking phpdocumentor/type-resolver (1.10.0) - Locking phpstan/phpdoc-parser (2.3.0) - Locking psr/container (2.0.2) - Locking psr/log (3.0.2) - Locking sabre/event (5.1.7) - Locking squizlabs/php_codesniffer (3.12.2) - Locking symfony/console (v7.3.3) - Locking symfony/deprecation-contracts (v3.6.0) - Locking symfony/polyfill-ctype (v1.33.0) - Locking symfony/polyfill-intl-grapheme (v1.33.0) - Locking symfony/polyfill-intl-normalizer (v1.33.0) - Locking symfony/polyfill-mbstring (v1.33.0) - Locking symfony/polyfill-php80 (v1.33.0) - Locking symfony/service-contracts (v3.6.0) - Locking symfony/string (v7.3.3) - Locking tysonandre/var_representation_polyfill (0.1.3) - Locking webmozart/assert (1.11.0) Writing lock file Installing dependencies from lock file (including require-dev) Package operations: 38 installs, 0 updates, 0 removals 0 [>---------------------------] 0 [->--------------------------] - Installing squizlabs/php_codesniffer (3.12.2): Extracting archive - Installing dealerdirect/phpcodesniffer-composer-installer (v1.1.2): Extracting archive - Installing composer/pcre (3.3.2): Extracting archive - Installing symfony/polyfill-php80 (v1.33.0): Extracting archive - Installing phpcsstandards/phpcsutils (1.0.12): Extracting archive - Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive - Installing symfony/polyfill-mbstring (v1.33.0): Extracting archive - Installing composer/spdx-licenses (1.5.9): Extracting archive - Installing composer/semver (3.4.3): Extracting archive - Installing mediawiki/mediawiki-codesniffer (v47.0.0): Extracting archive - Installing tysonandre/var_representation_polyfill (0.1.3): Extracting archive - Installing symfony/polyfill-intl-normalizer (v1.33.0): Extracting archive - Installing symfony/polyfill-intl-grapheme (v1.33.0): Extracting archive - Installing symfony/polyfill-ctype (v1.33.0): Extracting archive - Installing symfony/string (v7.3.3): Extracting archive - Installing symfony/deprecation-contracts (v3.6.0): Extracting archive - Installing psr/container (2.0.2): Extracting archive - Installing symfony/service-contracts (v3.6.0): Extracting archive - Installing symfony/console (v7.3.3): Extracting archive - Installing sabre/event (5.1.7): Extracting archive - Installing netresearch/jsonmapper (v4.5.0): Extracting archive - Installing microsoft/tolerant-php-parser (v0.1.2): Extracting archive - Installing webmozart/assert (1.11.0): Extracting archive - Installing phpstan/phpdoc-parser (2.3.0): Extracting archive - Installing phpdocumentor/reflection-common (2.2.0): Extracting archive - Installing doctrine/deprecations (1.1.5): Extracting archive - Installing phpdocumentor/type-resolver (1.10.0): Extracting archive - Installing phpdocumentor/reflection-docblock (5.6.3): Extracting archive - Installing felixfbecker/advanced-json-rpc (v3.2.1): Extracting archive - Installing psr/log (3.0.2): Extracting archive - Installing composer/xdebug-handler (3.0.5): Extracting archive - Installing phan/phan (5.5.1): Extracting archive - Installing mediawiki/phan-taint-check-plugin (7.0.0): Extracting archive - Installing mediawiki/mediawiki-phan-config (0.17.0): Extracting archive - Installing mediawiki/minus-x (1.1.3): Extracting archive - Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive - Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive - Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive 0/36 [>---------------------------] 0% 20/36 [===============>------------] 55% 35/36 [===========================>] 97% 36/36 [============================] 100% 1 package suggestions were added by new dependencies, use `composer suggest` to see details. Generating autoload files 17 packages you are using are looking for funding. Use the `composer fund` command to find out more! --- stdout --- PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils --- end --- Upgrading c:mediawiki/mediawiki-codesniffer from 47.0.0 -> 48.0.0 $ /usr/bin/composer update --- stderr --- Loading composer repositories with package information Updating dependencies Lock file operations: 0 installs, 5 updates, 0 removals - Upgrading composer/semver (3.4.3 => 3.4.4) - Upgrading mediawiki/mediawiki-codesniffer (v47.0.0 => v48.0.0) - Upgrading phpcsstandards/phpcsextra (1.2.1 => 1.4.0) - Upgrading phpcsstandards/phpcsutils (1.0.12 => 1.1.1) - Upgrading squizlabs/php_codesniffer (3.12.2 => 3.13.2) Writing lock file Installing dependencies from lock file (including require-dev) Package operations: 0 installs, 5 updates, 0 removals 0 [>---------------------------] 0 [->--------------------------] - Upgrading squizlabs/php_codesniffer (3.12.2 => 3.13.2): Extracting archive - Upgrading phpcsstandards/phpcsutils (1.0.12 => 1.1.1): Extracting archive - Upgrading phpcsstandards/phpcsextra (1.2.1 => 1.4.0): Extracting archive - Upgrading composer/semver (3.4.3 => 3.4.4): Extracting archive - Upgrading mediawiki/mediawiki-codesniffer (v47.0.0 => v48.0.0): Extracting archive 0/5 [>---------------------------] 0% 4/5 [======================>-----] 80% 5/5 [============================] 100% Generating autoload files 17 packages you are using are looking for funding. Use the `composer fund` command to find out more! No security vulnerability advisories found --- stdout --- PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils --- end --- $ vendor/bin/phpcs --report=json --- stdout --- {"totals":{"errors":13,"warnings":0,"fixable":0},"files":{"\/src\/repo\/includes\/Job\/Hooks\/MassMessageJobBeforeMessageSentHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Lookup\/CategorySpamlistLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/DedupeHelper.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Lookup\/ListContentSpamlistLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Logging\/MassMessageSendLogFormatter.php":{"errors":1,"warnings":0,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":10,"column":1}]},"\/src\/repo\/includes\/Job\/Hooks\/HookRunner.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/specials\/SpecialMassMessageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/EchoHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PageMessage\/PageMessageBuilderResult.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/UrlHelper.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Logging\/MassMessageSkipLogFormatter.php":{"errors":1,"warnings":0,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":8,"column":1}]},"\/src\/repo\/includes\/Lookup\/DatabaseLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/MassMessageApiTestCase.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Api\/ApiMassMessage.php":{"errors":1,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":13,"column":4}]},"\/src\/repo\/maintenance\/sendMessages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/SuppressMassMessageNotificationsMiddleware.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/MessageContentFetcher\/LocalMessageContentFetcher.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/job\/MassMessageSubmitJobTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/RequestProcessing\/MassMessageRequestParser.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/LanguageAwareText.php":{"errors":1,"warnings":0,"messages":[{"message":"You must use \"\/**\" style comments for a class comment, or add an empty line after stray comments","source":"MediaWiki.Commenting.CommentBeforeClass.StrayStyle","severity":5,"fixable":false,"type":"ERROR","line":9,"column":1}]},"\/src\/repo\/tests\/phpunit\/messagecontentfetcher\/LocalMessageContentFetcherTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/api\/ApiQueryMMContentTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/stub\/RevisionStoreStubFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/MessageContentFetcher\/RemoteMessageContentFetcher.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Lookup\/SpamlistLookup.php":{"errors":1,"warnings":0,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":11,"column":1}]},"\/src\/repo\/includes\/Job\/MassMessageSubmitJob.php":{"errors":1,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":13,"column":4}]},"\/src\/repo\/.phan\/stubs\/LqtDispatch.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/BeforeEchoEventInsertHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Lookup\/ParserFunctionSpamlistLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/Flow.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/MassMessageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/lookup\/ParserFunctionSpamlistLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Content\/MassMessageListContent.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/SuppressMassMessageNotificationsMiddlewareTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/UrlHelperTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/lookup\/DatabaseLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/RequestProcessing\/MassMessageRequest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/MessageSender.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/MessageContentFetcher\/LabeledSectionContentFetcher.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/lookup\/CategorySpamlistLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/MassMessage.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/MassMessage.i18n.magic.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/MessageBuilderUnitTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/Event.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/HookRunnerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/stub\/TitleStubFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Specials\/SpecialCreateMassMessageList.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/lookup\/ListContentSpamlistLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PageMessage\/PageMessageBuilder.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/MassMessageTestCase.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/MessageBuilder.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/api\/ApiEditMassMessageListTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Content\/MassMessageListSlotDiffRenderer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/content\/MassMessageListContentHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/pagemessage\/PageMessageBuilderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/MassMessage.php":{"errors":1,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":25,"column":4}]},"\/src\/repo\/includes\/MassMessageHooks.php":{"errors":1,"warnings":0,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":27,"column":1}]},"\/src\/repo\/tests\/phpunit\/job\/MassMessageJobTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Api\/ApiEditMassMessageList.php":{"errors":1,"warnings":0,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments; if it is a file-level comment, file a task in #MediaWiki-Codesniffer","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":20,"column":1}]},"\/src\/repo\/includes\/Job\/MassMessageJob.php":{"errors":1,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":30,"column":4}]},"\/src\/repo\/tests\/phpunit\/unit\/LabeledSectionContentFetcherUnitTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Job\/MassMessageServerSideJob.php":{"errors":1,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":18,"column":4}]},"\/src\/repo\/includes\/Api\/ApiQueryMMContent.php":{"errors":1,"warnings":0,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments; if it is a file-level comment, file a task in #MediaWiki-Codesniffer","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":11,"column":1}]},"\/src\/repo\/tests\/phpunit\/content\/MassMessageListContentTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/api\/ApiMassMessageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/content\/MassMessageListSlotDiffRendererTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Specials\/SpecialEditMassMessageList.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Specials\/SpecialMassMessage.php":{"errors":1,"warnings":0,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments; if it is a file-level comment, file a task in #MediaWiki-Codesniffer","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":31,"column":1}]},"\/src\/repo\/includes\/Content\/MassMessageListContentHandler.php":{"errors":0,"warnings":0,"messages":[]}}} --- end --- PHPCS run failed $ vendor/bin/phpcs --report=json --- stdout --- {"totals":{"errors":13,"warnings":0,"fixable":0},"files":{"\/src\/repo\/includes\/Job\/Hooks\/MassMessageJobBeforeMessageSentHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Job\/Hooks\/HookRunner.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Notifications\/SuppressMassMessageNotificationsMiddleware.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Lookup\/CategorySpamlistLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/DedupeHelper.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PageMessage\/PageMessageBuilderResult.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/EchoHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Lookup\/ListContentSpamlistLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/UrlHelper.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Logging\/MassMessageSendLogFormatter.php":{"errors":1,"warnings":0,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":10,"column":1}]},"\/src\/repo\/tests\/phpunit\/MassMessageApiTestCase.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Logging\/MassMessageSkipLogFormatter.php":{"errors":1,"warnings":0,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":8,"column":1}]},"\/src\/repo\/maintenance\/sendMessages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Lookup\/DatabaseLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/specials\/SpecialMassMessageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Api\/ApiMassMessage.php":{"errors":1,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":13,"column":4}]},"\/src\/repo\/includes\/MessageContentFetcher\/LocalMessageContentFetcher.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Job\/MassMessageSubmitJob.php":{"errors":1,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":13,"column":4}]},"\/src\/repo\/tests\/phpunit\/api\/ApiQueryMMContentTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/stub\/RevisionStoreStubFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/LanguageAwareText.php":{"errors":1,"warnings":0,"messages":[{"message":"You must use \"\/**\" style comments for a class comment, or add an empty line after stray comments","source":"MediaWiki.Commenting.CommentBeforeClass.StrayStyle","severity":5,"fixable":false,"type":"ERROR","line":9,"column":1}]},"\/src\/repo\/tests\/phpunit\/MassMessageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Lookup\/ParserFunctionSpamlistLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/RequestProcessing\/MassMessageRequestParser.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/job\/MassMessageSubmitJobTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/BeforeEchoEventInsertHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/LqtDispatch.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/Flow.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Content\/MassMessageListContent.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Lookup\/SpamlistLookup.php":{"errors":1,"warnings":0,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":11,"column":1}]},"\/src\/repo\/tests\/phpunit\/integration\/SuppressMassMessageNotificationsMiddlewareTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/messagecontentfetcher\/LocalMessageContentFetcherTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/UrlHelperTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/MessageContentFetcher\/RemoteMessageContentFetcher.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Specials\/SpecialCreateMassMessageList.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/lookup\/CategorySpamlistLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/MassMessage.i18n.magic.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/stub\/TitleStubFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/Event.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/lookup\/ParserFunctionSpamlistLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/MessageSender.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/RequestProcessing\/MassMessageRequest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/lookup\/ListContentSpamlistLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/pagemessage\/PageMessageBuilderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Content\/MassMessageListSlotDiffRenderer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/MessageContentFetcher\/LabeledSectionContentFetcher.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/MassMessage.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/lookup\/DatabaseLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/content\/MassMessageListContentHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/api\/ApiEditMassMessageListTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/MassMessageTestCase.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/MassMessageHooks.php":{"errors":1,"warnings":0,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":27,"column":1}]},"\/src\/repo\/tests\/phpunit\/unit\/LabeledSectionContentFetcherUnitTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PageMessage\/PageMessageBuilder.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/content\/MassMessageListContentTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/MessageBuilderUnitTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/MessageBuilder.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/HookRunnerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/MassMessage.php":{"errors":1,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":25,"column":4}]},"\/src\/repo\/tests\/phpunit\/api\/ApiMassMessageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Api\/ApiEditMassMessageList.php":{"errors":1,"warnings":0,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments; if it is a file-level comment, file a task in #MediaWiki-Codesniffer","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":20,"column":1}]},"\/src\/repo\/includes\/Api\/ApiQueryMMContent.php":{"errors":1,"warnings":0,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments; if it is a file-level comment, file a task in #MediaWiki-Codesniffer","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":11,"column":1}]},"\/src\/repo\/includes\/Specials\/SpecialEditMassMessageList.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Job\/MassMessageJob.php":{"errors":1,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":30,"column":4}]},"\/src\/repo\/tests\/phpunit\/job\/MassMessageJobTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/content\/MassMessageListSlotDiffRendererTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Job\/MassMessageServerSideJob.php":{"errors":1,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":18,"column":4}]},"\/src\/repo\/includes\/Specials\/SpecialMassMessage.php":{"errors":1,"warnings":0,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments; if it is a file-level comment, file a task in #MediaWiki-Codesniffer","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":31,"column":1}]},"\/src\/repo\/includes\/Content\/MassMessageListContentHandler.php":{"errors":0,"warnings":0,"messages":[]}}} --- end --- * sniff MediaWiki.Commenting.CommentBeforeClass.SpacingAfter is now failing * sniff MediaWiki.Commenting.CommentBeforeClass.StrayStyle is now failing * sniff MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation is now failing $ git checkout .phpcs.xml --- stderr --- Updated 0 paths from the index --- stdout --- --- end --- $ /usr/bin/composer install --- stderr --- Installing dependencies from lock file (including require-dev) Verifying lock file contents can be installed on current platform. Nothing to install, update or remove Generating autoload files 17 packages you are using are looking for funding. Use the `composer fund` command to find out more! --- stdout --- --- end --- $ /usr/bin/composer test --- stderr --- > parallel-lint . --exclude vendor --exclude node_modules > phpcs -sp --cache > minus-x check . --- stdout --- PHP 8.2.28 | 10 parallel jobs ............................................................ 60/72 ( 83%) ............ 72/72 (100%) Checked 72 files in 0.3 seconds No syntax error found .................................... 36 / 36 (100%) Time: 263ms; Memory: 10MB MinusX ====== Processing /src/repo... ............................................................. ............................................................. ............................................................. ............................................................. ......................................................... All good! --- end --- $ /usr/bin/npm audit --json --- stdout --- { "auditReportVersion": 2, "vulnerabilities": {}, "metadata": { "vulnerabilities": { "info": 0, "low": 0, "moderate": 0, "high": 0, "critical": 0, "total": 0 }, "dependencies": { "prod": 1, "dev": 455, "optional": 4, "peer": 5, "peerOptional": 0, "total": 455 } } } --- end --- $ package-lock-lint package-lock.json --- stdout --- Checking package-lock.json --- end --- build: Updating mediawiki/mediawiki-codesniffer to 48.0.0 The following sniffs are failing and were disabled: * MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation * MediaWiki.Commenting.CommentBeforeClass.SpacingAfter * MediaWiki.Commenting.CommentBeforeClass.StrayStyle $ git add . --- stdout --- --- end --- $ git commit -F /tmp/tmpjiwkj_3u --- stdout --- [master 114c13a] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0 2 files changed, 6 insertions(+), 2 deletions(-) --- end --- $ git format-patch HEAD~1 --stdout --- stdout --- From 114c13ade6c6ac1edae91523c092657dfd834acb Mon Sep 17 00:00:00 2001 From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org> Date: Wed, 10 Sep 2025 03:05:47 +0000 Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0 The following sniffs are failing and were disabled: * MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation * MediaWiki.Commenting.CommentBeforeClass.SpacingAfter * MediaWiki.Commenting.CommentBeforeClass.StrayStyle Change-Id: I7ae580cf122c7caeca01b32af686a24fbaa83ccf --- .phpcs.xml | 6 +++++- composer.json | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.phpcs.xml b/.phpcs.xml index a9de689..ad35505 100644 --- a/.phpcs.xml +++ b/.phpcs.xml @@ -1,6 +1,10 @@ <?xml version="1.0"?> <ruleset> - <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" /> + <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki"> + <exclude name="MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation" /> + <exclude name="MediaWiki.Commenting.CommentBeforeClass.SpacingAfter" /> + <exclude name="MediaWiki.Commenting.CommentBeforeClass.StrayStyle" /> + </rule> <rule ref="Generic.Files.LineLength"> <exclude-pattern>MassMessage\.alias\.php</exclude-pattern> </rule> diff --git a/composer.json b/composer.json index 60615dd..01e1704 100644 --- a/composer.json +++ b/composer.json @@ -1,6 +1,6 @@ { "require-dev": { - "mediawiki/mediawiki-codesniffer": "47.0.0", + "mediawiki/mediawiki-codesniffer": "48.0.0", "mediawiki/mediawiki-phan-config": "0.17.0", "mediawiki/minus-x": "1.1.3", "php-parallel-lint/php-console-highlighter": "1.0.0", -- 2.39.5 --- end ---