This run took 49 seconds.
From d31ca6d4ef35d97a73d37c0c95cf81bc3757e365 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sun, 10 Nov 2024 07:12:43 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Usage.NullableType.ExplicitNullableTypes
Change-Id: Ie3bab16239acfb9581035031ae601f3b610b49c1
---
.phpcs.xml | 4 +++-
composer.json | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index a175199..9831dc3 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,6 +1,8 @@
<?xml version="1.0"?>
<ruleset>
- <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
+ <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude name="MediaWiki.Usage.NullableType.ExplicitNullableTypes" />
+ </rule>
<rule ref="Generic.Functions.FunctionCallArgumentSpacing.TooMuchSpaceAfterComma">
<severity>5</severity>
diff --git a/composer.json b/composer.json
index a438478..e6bf731 100644
--- a/composer.json
+++ b/composer.json
@@ -3,7 +3,7 @@
"justinrainbow/json-schema": "~5.2"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/mediawiki-phan-config": "0.14.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
--
2.39.2
$ date
--- stdout ---
Sun Nov 10 07:11:57 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-Kartographer.git repo --depth=1 -b REL1_43
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/REL1_43
--- stdout ---
acf6debd29f2fc4d84d161998c5347392d4ffe27 refs/heads/REL1_43
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {
"rollup": {
"name": "rollup",
"severity": "high",
"isDirect": true,
"via": [
{
"source": 1099757,
"name": "rollup",
"dependency": "rollup",
"title": "DOM Clobbering Gadget found in rollup bundled scripts that leads to XSS",
"url": "https://github.com/advisories/GHSA-gcx4-mw62-g8wm",
"severity": "high",
"cwe": [
"CWE-79"
],
"cvss": {
"score": 6.4,
"vectorString": "CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:L/I:L/A:H"
},
"range": "<2.79.2"
}
],
"effects": [],
"range": "<2.79.2",
"nodes": [
"node_modules/rollup"
],
"fixAvailable": {
"name": "rollup",
"version": "4.25.0",
"isSemVerMajor": true
}
}
},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 1,
"critical": 0,
"total": 1
},
"dependencies": {
"prod": 8,
"dev": 634,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 641
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 39 installs, 0 updates, 0 removals
- Locking composer/pcre (3.3.1)
- Locking composer/semver (3.4.2)
- Locking composer/spdx-licenses (1.5.8)
- Locking composer/xdebug-handler (3.0.5)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking doctrine/deprecations (1.1.3)
- Locking felixfbecker/advanced-json-rpc (v3.2.1)
- Locking justinrainbow/json-schema (5.3.0)
- Locking mediawiki/mediawiki-codesniffer (v44.0.0)
- Locking mediawiki/mediawiki-phan-config (0.14.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking mediawiki/phan-taint-check-plugin (6.0.0)
- Locking microsoft/tolerant-php-parser (v0.1.2)
- Locking netresearch/jsonmapper (v4.5.0)
- Locking phan/phan (5.4.3)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.11)
- Locking phpdocumentor/reflection-common (2.2.0)
- Locking phpdocumentor/reflection-docblock (5.5.1)
- Locking phpdocumentor/type-resolver (1.10.0)
- Locking phpstan/phpdoc-parser (1.33.0)
- Locking psr/container (2.0.2)
- Locking psr/log (3.0.2)
- Locking sabre/event (5.1.7)
- Locking squizlabs/php_codesniffer (3.9.0)
- Locking symfony/console (v7.1.7)
- Locking symfony/deprecation-contracts (v3.5.0)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-intl-grapheme (v1.31.0)
- Locking symfony/polyfill-intl-normalizer (v1.31.0)
- Locking symfony/polyfill-mbstring (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking symfony/service-contracts (v3.5.0)
- Locking symfony/string (v7.1.6)
- Locking tysonandre/var_representation_polyfill (0.1.3)
- Locking webmozart/assert (1.11.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 39 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing squizlabs/php_codesniffer (3.9.0): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing composer/pcre (3.3.1): Extracting archive
- Installing justinrainbow/json-schema (5.3.0): Extracting archive
- Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.11): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.2): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v44.0.0): Extracting archive
- Installing tysonandre/var_representation_polyfill (0.1.3): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
- Installing symfony/string (v7.1.6): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.0): Extracting archive
- Installing symfony/console (v7.1.7): Extracting archive
- Installing sabre/event (5.1.7): Extracting archive
- Installing netresearch/jsonmapper (v4.5.0): Extracting archive
- Installing microsoft/tolerant-php-parser (v0.1.2): Extracting archive
- Installing webmozart/assert (1.11.0): Extracting archive
- Installing phpstan/phpdoc-parser (1.33.0): Extracting archive
- Installing phpdocumentor/reflection-common (2.2.0): Extracting archive
- Installing doctrine/deprecations (1.1.3): Extracting archive
- Installing phpdocumentor/type-resolver (1.10.0): Extracting archive
- Installing phpdocumentor/reflection-docblock (5.5.1): Extracting archive
- Installing felixfbecker/advanced-json-rpc (v3.2.1): Extracting archive
- Installing psr/log (3.0.2): Extracting archive
- Installing composer/xdebug-handler (3.0.5): Extracting archive
- Installing phan/phan (5.4.3): Extracting archive
- Installing mediawiki/phan-taint-check-plugin (6.0.0): Extracting archive
- Installing mediawiki/mediawiki-phan-config (0.14.0): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/37 [>---------------------------] 0%
20/37 [===============>------------] 54%
30/37 [======================>-----] 81%
37/37 [============================] 100%
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 44.0.0 -> 45.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 4 updates, 0 removals
- Upgrading composer/semver (3.4.2 => 3.4.3)
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0)
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12)
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 4 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12): Extracting archive
- Upgrading composer/semver (3.4.2 => 3.4.3): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0): Extracting archive
0/4 [>---------------------------] 0%
3/4 [=====================>------] 75%
4/4 [============================] 100%
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: set()
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":12,"warnings":0,"fixable":12},"files":{"\/src\/repo\/Kartographer.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ParsoidWikitextParser.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/LegacyMapLink.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ParserFunctionTracker.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/MediaWikiWikitextParser.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?PPFrame $frame = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":16,"column":50}]},"\/src\/repo\/includes\/Tag\/ParserContext.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/purgeMapPages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/ParsoidKartographerConfig.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/LegacyMapFrame.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/ErrorReporter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ParsoidUtils.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/Tag.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $regexp = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":72,"column":46}]},"\/src\/repo\/includes\/Modules\/ExternalLinksProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Modules\/DataModule.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/MapLinkAttributeGenerator.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Special\/EPSG3857.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/CoordFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/WikitextParser.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/ParsoidMapFrame.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Api\/ApiSanitizeMapData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/ParsoidMapLink.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/ParserFunctionTrackerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PartialWikitextParser.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/LegacyTagHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/MapFrameAttributeGenerator.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/ExternalLinksProviderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/CoordFormatterTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/State.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/ParsoidTagHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/ParsoidDomProcessor.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/ProjectionTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/MapLinkAttributeGeneratorTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/namespaces.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/MapTagArgumentValidator.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/TagTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/DomImpl.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/LegacyTagHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ValidationTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ApiSanitizeMapDataTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/MediaWikiWikitextParserTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/SpecialMapTest.php":{"errors":4,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?float $expectedLat = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":31,"column":22},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?float $expectedLon = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":31,"column":49},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $expectedLang = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":31,"column":76},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?int $zoom = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":101,"column":76}]},"\/src\/repo\/tests\/phpunit\/DataModuleTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/MapFrameAttributeGeneratorTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Api\/ApiQueryMapData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Special\/SpecialMap.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SimpleStyleParser.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?PPFrame $frame = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":35,"column":59}]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/MapTagArgumentValidatorTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ApiQueryMapDataTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/StateTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/SimpleStyleParserTest.php":{"errors":5,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $expected = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":120,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $expectedError = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":121,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $option = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":122,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $expectedFirstMarker = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":254,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $expectedFirstMarker = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":272,"column":9}]},"\/src\/repo\/tests\/phpunit\/KartographerTest.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":12,"warnings":0,"fixable":12},"files":{"\/src\/repo\/Kartographer.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/MediaWikiWikitextParser.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?PPFrame $frame = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":16,"column":50}]},"\/src\/repo\/includes\/ParserFunctionTracker.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ParsoidWikitextParser.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/LegacyMapLink.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/ParserContext.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/purgeMapPages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/ParsoidKartographerConfig.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/ErrorReporter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ParsoidUtils.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Modules\/ExternalLinksProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/LegacyMapFrame.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/MapLinkAttributeGenerator.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/Tag.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $regexp = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":72,"column":46}]},"\/src\/repo\/includes\/Modules\/DataModule.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/WikitextParser.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PartialWikitextParser.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Special\/EPSG3857.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/ParsoidMapLink.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/ParserFunctionTrackerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/ParsoidMapFrame.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Api\/ApiSanitizeMapData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/CoordFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/MapFrameAttributeGenerator.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/MapLinkAttributeGeneratorTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/ParsoidDomProcessor.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/State.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/LegacyTagHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/TagTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/ExternalLinksProviderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/MapTagArgumentValidator.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/CoordFormatterTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/namespaces.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/DomImpl.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/ProjectionTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Tag\/ParsoidTagHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/LegacyTagHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/MediaWikiWikitextParserTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ApiSanitizeMapDataTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/MapFrameAttributeGeneratorTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/SpecialMapTest.php":{"errors":4,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?float $expectedLat = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":31,"column":22},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?float $expectedLon = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":31,"column":49},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $expectedLang = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":31,"column":76},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?int $zoom = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":101,"column":76}]},"\/src\/repo\/includes\/Special\/SpecialMap.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Api\/ApiQueryMapData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/DataModuleTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ValidationTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SimpleStyleParser.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?PPFrame $frame = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":35,"column":59}]},"\/src\/repo\/tests\/phpunit\/ApiQueryMapDataTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/MapTagArgumentValidatorTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/SimpleStyleParserTest.php":{"errors":5,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $expected = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":120,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $expectedError = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":121,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $option = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":122,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $expectedFirstMarker = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":254,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $expectedFirstMarker = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":272,"column":9}]},"\/src\/repo\/tests\/phpunit\/unit\/StateTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/KartographerTest.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
* sniff MediaWiki.Usage.NullableType.ExplicitNullableTypes is now failing
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> phpcs -sp --cache
> minus-x check .
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
..................................................... 53/53 (100%)
Checked 53 files in 0.3 seconds
No syntax error found
..................................................... 53 / 53 (100%)
Time: 362ms; Memory: 8MB
MinusX
======
Processing /src/repo...
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
...........................................
All good!
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {
"rollup": {
"name": "rollup",
"severity": "high",
"isDirect": true,
"via": [
{
"source": 1099757,
"name": "rollup",
"dependency": "rollup",
"title": "DOM Clobbering Gadget found in rollup bundled scripts that leads to XSS",
"url": "https://github.com/advisories/GHSA-gcx4-mw62-g8wm",
"severity": "high",
"cwe": [
"CWE-79"
],
"cvss": {
"score": 6.4,
"vectorString": "CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:L/I:L/A:H"
},
"range": "<2.79.2"
}
],
"effects": [],
"range": "<2.79.2",
"nodes": [
"node_modules/rollup"
],
"fixAvailable": {
"name": "rollup",
"version": "4.25.0",
"isSemVerMajor": true
}
}
},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 1,
"critical": 0,
"total": 1
},
"dependencies": {
"prod": 8,
"dev": 634,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 641
}
}
}
--- end ---
Attempting to npm audit fix
$ /usr/bin/npm audit fix --dry-run --only=dev --json
--- stderr ---
npm WARN invalid config only="dev" set in command line options
npm WARN invalid config Must be one of: null, prod, production
--- stdout ---
{
"added": 641,
"removed": 0,
"changed": 0,
"audited": 642,
"funding": 120,
"audit": {
"auditReportVersion": 2,
"vulnerabilities": {
"rollup": {
"name": "rollup",
"severity": "high",
"isDirect": true,
"via": [
{
"source": 1099757,
"name": "rollup",
"dependency": "rollup",
"title": "DOM Clobbering Gadget found in rollup bundled scripts that leads to XSS",
"url": "https://github.com/advisories/GHSA-gcx4-mw62-g8wm",
"severity": "high",
"cwe": [
"CWE-79"
],
"cvss": {
"score": 6.4,
"vectorString": "CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:L/I:L/A:H"
},
"range": "<2.79.2"
}
],
"effects": [],
"range": "<2.79.2",
"nodes": [
"node_modules/rollup"
],
"fixAvailable": {
"name": "rollup",
"version": "4.25.0",
"isSemVerMajor": true
}
}
},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 1,
"critical": 0,
"total": 1
},
"dependencies": {
"prod": 8,
"dev": 634,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 641
}
}
}
}
--- end ---
{"added": 641, "removed": 0, "changed": 0, "audited": 642, "funding": 120, "audit": {"auditReportVersion": 2, "vulnerabilities": {"rollup": {"name": "rollup", "severity": "high", "isDirect": true, "via": [{"source": 1099757, "name": "rollup", "dependency": "rollup", "title": "DOM Clobbering Gadget found in rollup bundled scripts that leads to XSS", "url": "https://github.com/advisories/GHSA-gcx4-mw62-g8wm", "severity": "high", "cwe": ["CWE-79"], "cvss": {"score": 6.4, "vectorString": "CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:L/I:L/A:H"}, "range": "<2.79.2"}], "effects": [], "range": "<2.79.2", "nodes": ["node_modules/rollup"], "fixAvailable": {"name": "rollup", "version": "4.25.0", "isSemVerMajor": true}}}, "metadata": {"vulnerabilities": {"info": 0, "low": 0, "moderate": 0, "high": 1, "critical": 0, "total": 1}, "dependencies": {"prod": 8, "dev": 634, "optional": 0, "peer": 1, "peerOptional": 0, "total": 641}}}}
$ /usr/bin/npm audit fix --only=dev
--- stderr ---
npm WARN invalid config only="dev" set in command line options
npm WARN invalid config Must be one of: null, prod, production
npm WARN deprecated glob@7.1.7: Glob versions prior to v9 are no longer supported
npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated rollup-plugin-commonjs@5.0.5: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-commonjs.
--- stdout ---
added 641 packages, and audited 642 packages in 6s
120 packages are looking for funding
run `npm fund` for details
# npm audit report
rollup <2.79.2
Severity: high
DOM Clobbering Gadget found in rollup bundled scripts that leads to XSS - https://github.com/advisories/GHSA-gcx4-mw62-g8wm
fix available via `npm audit fix --force`
Will install rollup@4.25.0, which is a breaking change
node_modules/rollup
1 high severity vulnerability
To address all issues (including breaking changes), run:
npm audit fix --force
--- end ---
Verifying that tests still pass
$ /usr/bin/npm ci
--- stderr ---
npm WARN deprecated glob@7.1.7: Glob versions prior to v9 are no longer supported
npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated rollup-plugin-commonjs@5.0.5: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-commonjs.
--- stdout ---
added 641 packages, and audited 642 packages in 8s
120 packages are looking for funding
run `npm fund` for details
1 high severity vulnerability
To address all issues (including breaking changes), run:
npm audit fix --force
Run `npm audit` for details.
--- end ---
$ /usr/bin/npm test
--- stdout ---
> test
> grunt test
Running "eslint:all" (eslint) task
/src/repo/modules/dialog/nearby.js
10:1 warning The type 'ThumbnailProperties' is undefined jsdoc/no-undefined-types
/src/repo/modules/maplink/maplink.js
7:1 warning The type 'Kartograhper' is undefined jsdoc/no-undefined-types
8:1 warning The type 'Kartograhper' is undefined jsdoc/no-undefined-types
/src/repo/modules/wikivoyage/WVMapLayers.js
5:1 warning The type 'Kartograhper' is undefined jsdoc/no-undefined-types
✖ 4 problems (0 errors, 4 warnings)
Running "stylelint:all" (stylelint) task
>> Linted 11 files without errors
Running "banana:Kartographer" (banana) task
>> 3 message directories checked.
Running "libcheck" task
>> Library folder is synchronized with upstream libraries' states.
Done.
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Usage.NullableType.ExplicitNullableTypes
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpao8yz5e6
--- stdout ---
[REL1_43 d31ca6d] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
2 files changed, 4 insertions(+), 2 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From d31ca6d4ef35d97a73d37c0c95cf81bc3757e365 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sun, 10 Nov 2024 07:12:43 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Usage.NullableType.ExplicitNullableTypes
Change-Id: Ie3bab16239acfb9581035031ae601f3b610b49c1
---
.phpcs.xml | 4 +++-
composer.json | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index a175199..9831dc3 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,6 +1,8 @@
<?xml version="1.0"?>
<ruleset>
- <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
+ <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude name="MediaWiki.Usage.NullableType.ExplicitNullableTypes" />
+ </rule>
<rule ref="Generic.Functions.FunctionCallArgumentSpacing.TooMuchSpaceAfterComma">
<severity>5</severity>
diff --git a/composer.json b/composer.json
index a438478..e6bf731 100644
--- a/composer.json
+++ b/composer.json
@@ -3,7 +3,7 @@
"justinrainbow/json-schema": "~5.2"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/mediawiki-phan-config": "0.14.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
--
2.39.2
--- end ---