This run took 19 seconds.
From a2d92408deb017b0eaeba31c85ff5acc13fb2909 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sun, 10 Nov 2024 16:57:19 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Usage.NullableType.ExplicitNullableTypes
Change-Id: I302da4459b23a9bf85d28c56f011e3c7eb7a2ccb
---
.phpcs.xml | 4 +++-
composer.json | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index 9cfb9b3..6d73443 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,7 +2,9 @@
<ruleset>
<!-- START Copied from wikibase-codesniffer T268828 -->
- <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
+ <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude name="MediaWiki.Usage.NullableType.ExplicitNullableTypes" />
+ </rule>
<!-- The function comment sniff is too rigorous about too many details that need
exceptions:
diff --git a/composer.json b/composer.json
index ee16c71..6009b5a 100644
--- a/composer.json
+++ b/composer.json
@@ -24,7 +24,7 @@
"irc": "irc://irc.libera.chat/wikimedia-discovery"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/mediawiki-phan-config": "0.14.0",
"mediawiki/minus-x": "1.1.3",
"php-coveralls/php-coveralls": "^2.0.0",
--
2.39.2
$ date
--- stdout ---
Sun Nov 10 16:57:06 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-WikibaseCirrusSearch.git repo --depth=1 -b REL1_43
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/REL1_43
--- stdout ---
0789cf3b61fdee1233b0280868473c3b68cd4fff refs/heads/REL1_43
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 315,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 315
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 51 installs, 0 updates, 0 removals
- Locking composer/installers (v2.3.0)
- Locking composer/pcre (3.3.1)
- Locking composer/semver (3.4.2)
- Locking composer/spdx-licenses (1.5.8)
- Locking composer/xdebug-handler (3.0.5)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking doctrine/deprecations (1.1.3)
- Locking felixfbecker/advanced-json-rpc (v3.2.1)
- Locking guzzlehttp/guzzle (7.9.2)
- Locking guzzlehttp/promises (2.0.4)
- Locking guzzlehttp/psr7 (2.7.0)
- Locking mediawiki/mediawiki-codesniffer (v44.0.0)
- Locking mediawiki/mediawiki-phan-config (0.14.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking mediawiki/phan-taint-check-plugin (6.0.0)
- Locking microsoft/tolerant-php-parser (v0.1.2)
- Locking netresearch/jsonmapper (v4.5.0)
- Locking phan/phan (5.4.3)
- Locking php-coveralls/php-coveralls (v2.7.0)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.11)
- Locking phpdocumentor/reflection-common (2.2.0)
- Locking phpdocumentor/reflection-docblock (5.5.1)
- Locking phpdocumentor/type-resolver (1.10.0)
- Locking phpstan/phpdoc-parser (1.33.0)
- Locking psr/container (2.0.2)
- Locking psr/http-client (1.0.3)
- Locking psr/http-factory (1.1.0)
- Locking psr/http-message (2.0)
- Locking psr/log (2.0.0)
- Locking ralouphie/getallheaders (3.0.3)
- Locking sabre/event (5.1.7)
- Locking squizlabs/php_codesniffer (3.9.0)
- Locking symfony/config (v7.1.7)
- Locking symfony/console (v7.1.7)
- Locking symfony/deprecation-contracts (v3.5.0)
- Locking symfony/filesystem (v7.1.6)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-intl-grapheme (v1.31.0)
- Locking symfony/polyfill-intl-normalizer (v1.31.0)
- Locking symfony/polyfill-mbstring (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking symfony/service-contracts (v3.5.0)
- Locking symfony/stopwatch (v7.1.6)
- Locking symfony/string (v7.1.6)
- Locking symfony/yaml (v7.1.6)
- Locking tysonandre/var_representation_polyfill (0.1.3)
- Locking webmozart/assert (1.11.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 51 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing composer/installers (v2.3.0): Extracting archive
- Installing squizlabs/php_codesniffer (3.9.0): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing composer/pcre (3.3.1): Extracting archive
- Installing guzzlehttp/promises (2.0.4): Extracting archive
- Installing ralouphie/getallheaders (3.0.3): Extracting archive
- Installing psr/http-message (2.0): Extracting archive
- Installing psr/http-factory (1.1.0): Extracting archive
- Installing guzzlehttp/psr7 (2.7.0): Extracting archive
- Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.11): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.2): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v44.0.0): Extracting archive
- Installing tysonandre/var_representation_polyfill (0.1.3): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
- Installing symfony/string (v7.1.6): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.0): Extracting archive
- Installing symfony/console (v7.1.7): Extracting archive
- Installing sabre/event (5.1.7): Extracting archive
- Installing netresearch/jsonmapper (v4.5.0): Extracting archive
- Installing microsoft/tolerant-php-parser (v0.1.2): Extracting archive
- Installing webmozart/assert (1.11.0): Extracting archive
- Installing phpstan/phpdoc-parser (1.33.0): Extracting archive
- Installing phpdocumentor/reflection-common (2.2.0): Extracting archive
- Installing doctrine/deprecations (1.1.3): Extracting archive
- Installing phpdocumentor/type-resolver (1.10.0): Extracting archive
- Installing phpdocumentor/reflection-docblock (5.5.1): Extracting archive
- Installing felixfbecker/advanced-json-rpc (v3.2.1): Extracting archive
- Installing psr/log (2.0.0): Extracting archive
- Installing composer/xdebug-handler (3.0.5): Extracting archive
- Installing phan/phan (5.4.3): Extracting archive
- Installing mediawiki/phan-taint-check-plugin (6.0.0): Extracting archive
- Installing mediawiki/mediawiki-phan-config (0.14.0): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing symfony/yaml (v7.1.6): Extracting archive
- Installing symfony/stopwatch (v7.1.6): Extracting archive
- Installing symfony/filesystem (v7.1.6): Extracting archive
- Installing symfony/config (v7.1.7): Extracting archive
- Installing psr/http-client (1.0.3): Extracting archive
- Installing guzzlehttp/guzzle (7.9.2): Extracting archive
- Installing php-coveralls/php-coveralls (v2.7.0): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/48 [>---------------------------] 0%
20/48 [===========>----------------] 41%
30/48 [=================>----------] 62%
42/48 [========================>---] 87%
48/48 [============================] 100%
2 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating autoload files
24 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 44.0.0 -> 45.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 4 updates, 0 removals
- Upgrading composer/semver (3.4.2 => 3.4.3)
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0)
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12)
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 4 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12): Extracting archive
- Upgrading composer/semver (3.4.2 => 3.4.3): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0): Extracting archive
0/4 [>---------------------------] 0%
3/4 [=====================>------] 75%
4/4 [============================] 100%
Generating autoload files
24 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: set()
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":10,"warnings":0,"fixable":10},"files":{"\/src\/repo\/src\/config\/EntitySearchProfiles.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/ItemFieldDefinitions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/StatementCountField.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/config\/ElasticSearchRescoreFunctions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/config\/ElasticSearchRescoreProfiles.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/config\/EntityPrefixSearchProfiles.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/LabelsProviderFieldDefinitions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/SearchFieldTestCase.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/PropertyFieldDefinitions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/DescriptionsProviderFieldDefinitions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikibaseSearchConfig.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/TermIndexField.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/AnalysisConfigBuilderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/SiteLinkCountField.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/StatementProviderFieldDefinitions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/AllLabelsFieldTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/DescriptionProviderFieldDefinitionsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikibasePrefixSearcher.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?CirrusDebugOptions $options = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":32,"column":51}]},"\/src\/repo\/src\/Fields\/StatementQuantityField.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/WikibaseNumericFieldTestCase.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/StatementCountFieldTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/LabelsProviderFieldDefinitionsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/EntityResultType.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/SiteLinkCountFieldTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/AllLabelsField.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Query\/WbStatementQuantityFeature.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ElasticTermResult.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/LabelsFieldTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/DescriptionFieldTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/SpecialEntitiesWithoutPageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/StatementQuantityFieldTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/StatementsField.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/ItemFieldDefinitionsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/WikibaseSearch.entitytypes.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Query\/InLabelFeature.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/LabelsField.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Query\/HasDataForLangFeatureTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/EntitySearchElasticFulltextTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/WikibaseSearchTestCase.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/SpecialEntitiesWithoutPageFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/EntityResult.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/SpecialEntitiesWithoutPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/SearchEntitiesIntegrationTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/EntityResultSet.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/WikibaseCirrusSearch.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/DescriptionsField.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ConfigBuilder.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Query\/HasLicenseFeature.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Query\/WbStatementQuantityFeatureTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/PropertyHandlerTest.php":{"errors":3,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?EntityId $id = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":55,"column":35},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?SettingsArray $settings = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":76,"column":36},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?EntityDocument $entity = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":81,"column":42}]},"\/src\/repo\/tests\/phpunit\/OpenSearchLabelsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/StatementsFieldTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Query\/HasWbStatementFeature.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/EntityFullTextQueryBuilder.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Query\/InLabelFeatureTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Query\/HasDataForLangFeature.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/CirrusShowSearchHitHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ItemHandlerTest.php":{"errors":3,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?EntityDocument $entity = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":66,"column":42},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?EntityId $id = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":91,"column":35},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?SettingsArray $settings = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":115,"column":36}]},"\/src\/repo\/tests\/phpunit\/Query\/HasLicenseFeatureTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/EntitySearchUtils.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/EntitySearchElastic.php":{"errors":3,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?WebRequest $request = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":117,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?CirrusDebugOptions $options = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":118,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $profileContext = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":294,"column":9}]},"\/src\/repo\/tests\/phpunit\/ElasticTermResultTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ShowSearchHitHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Query\/HasWbStatementFeatureTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/EntitySearchElasticTest.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":10,"warnings":0,"fixable":10},"files":{"\/src\/repo\/src\/config\/EntitySearchProfiles.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/config\/ElasticSearchRescoreFunctions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/ItemFieldDefinitions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/SearchFieldTestCase.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/StatementCountField.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/DescriptionsProviderFieldDefinitions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/config\/ElasticSearchRescoreProfiles.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/config\/EntityPrefixSearchProfiles.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/SiteLinkCountField.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/LabelsProviderFieldDefinitions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/AnalysisConfigBuilderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikibaseSearchConfig.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/PropertyFieldDefinitions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/StatementProviderFieldDefinitions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/StatementQuantityField.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/DescriptionProviderFieldDefinitionsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/TermIndexField.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/LabelsProviderFieldDefinitionsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/AllLabelsField.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/AllLabelsFieldTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/SiteLinkCountFieldTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikibasePrefixSearcher.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?CirrusDebugOptions $options = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":32,"column":51}]},"\/src\/repo\/tests\/phpunit\/Fields\/WikibaseNumericFieldTestCase.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/DescriptionFieldTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/EntityResultType.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ElasticTermResult.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/LabelsField.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/StatementCountFieldTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/WikibaseSearch.entitytypes.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Query\/WbStatementQuantityFeature.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/ItemFieldDefinitionsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/SearchEntitiesIntegrationTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Fields\/DescriptionsField.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/StatementQuantityFieldTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/SpecialEntitiesWithoutPageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/SpecialEntitiesWithoutPageFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Query\/InLabelFeatureTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/EntityResult.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/WikibaseCirrusSearch.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/LabelsFieldTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/SpecialEntitiesWithoutPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Query\/HasLicenseFeature.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/EntityResultSet.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/OpenSearchLabelsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/EntityFullTextQueryBuilder.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/EntitySearchElasticFulltextTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Query\/HasWbStatementFeatureTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/PropertyHandlerTest.php":{"errors":3,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?EntityId $id = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":55,"column":35},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?SettingsArray $settings = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":76,"column":36},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?EntityDocument $entity = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":81,"column":42}]},"\/src\/repo\/src\/Fields\/StatementsField.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Query\/WbStatementQuantityFeatureTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Query\/InLabelFeature.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Query\/HasDataForLangFeatureTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ConfigBuilder.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Query\/HasWbStatementFeature.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/WikibaseSearchTestCase.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Query\/HasDataForLangFeature.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ElasticTermResultTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Fields\/StatementsFieldTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/CirrusShowSearchHitHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ItemHandlerTest.php":{"errors":3,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?EntityDocument $entity = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":66,"column":42},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?EntityId $id = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":91,"column":35},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?SettingsArray $settings = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":115,"column":36}]},"\/src\/repo\/tests\/phpunit\/EntitySearchElasticTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Query\/HasLicenseFeatureTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/EntitySearchUtils.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/EntitySearchElastic.php":{"errors":3,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?WebRequest $request = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":117,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?CirrusDebugOptions $options = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":118,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $profileContext = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":294,"column":9}]},"\/src\/repo\/tests\/phpunit\/ShowSearchHitHandlerTest.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
* sniff MediaWiki.Usage.NullableType.ExplicitNullableTypes is now failing
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
24 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> composer validate --no-interaction
./composer.json is valid, but with a few warnings
See https://getcomposer.org/doc/04-schema.md for details on the schema
# General warnings
- require.composer/installers : unbound version constraints (>=1.0.1) should be avoided
> parallel-lint . --exclude vendor --exclude node_modules
> phpcs -sp --cache
> minus-x check .
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
............................................................ 60/67 ( 89%)
....... 67/67 (100%)
Checked 67 files in 0.3 seconds
No syntax error found
.................................. 34 / 34 (100%)
Time: 261ms; Memory: 10MB
MinusX
======
Processing /src/repo...
.............................................................
.............................................................
.............................................................
.............................................................
.......................................
All good!
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 315,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 315
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Usage.NullableType.ExplicitNullableTypes
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpg8qd15w9
--- stdout ---
[REL1_43 a2d9240] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
2 files changed, 4 insertions(+), 2 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From a2d92408deb017b0eaeba31c85ff5acc13fb2909 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sun, 10 Nov 2024 16:57:19 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Usage.NullableType.ExplicitNullableTypes
Change-Id: I302da4459b23a9bf85d28c56f011e3c7eb7a2ccb
---
.phpcs.xml | 4 +++-
composer.json | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index 9cfb9b3..6d73443 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,7 +2,9 @@
<ruleset>
<!-- START Copied from wikibase-codesniffer T268828 -->
- <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
+ <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude name="MediaWiki.Usage.NullableType.ExplicitNullableTypes" />
+ </rule>
<!-- The function comment sniff is too rigorous about too many details that need
exceptions:
diff --git a/composer.json b/composer.json
index ee16c71..6009b5a 100644
--- a/composer.json
+++ b/composer.json
@@ -24,7 +24,7 @@
"irc": "irc://irc.libera.chat/wikimedia-discovery"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/mediawiki-phan-config": "0.14.0",
"mediawiki/minus-x": "1.1.3",
"php-coveralls/php-coveralls": "^2.0.0",
--
2.39.2
--- end ---