This run took 15 seconds.
From c97d73e7fac23cc5b92e20b2fa890edc676a6454 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sun, 10 Nov 2024 17:30:55 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Usage.NullableType.ExplicitNullableTypes
Change-Id: I93571a63721f1da5db1b31676f845eb39dc5ed33
---
.phpcs.xml | 4 +++-
composer.json | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index 249407f..1169123 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,6 +1,8 @@
<?xml version="1.0"?>
<ruleset>
- <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
+ <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude name="MediaWiki.Usage.NullableType.ExplicitNullableTypes" />
+ </rule>
<rule ref="Generic.PHP.RequireStrictTypes" />
<file>.</file>
<arg name="extensions" value="php" />
diff --git a/composer.json b/composer.json
index 888d6f7..b643eeb 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/mediawiki-phan-config": "0.14.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
--
2.39.2
$ date
--- stdout ---
Sun Nov 10 17:30:45 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-WikimediaCampaignEvents.git repo --depth=1 -b REL1_43
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/REL1_43
--- stdout ---
fab75c1c9b16bd8347185cbf4364817a1144a9ea refs/heads/REL1_43
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 417,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 417
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 38 installs, 0 updates, 0 removals
- Locking composer/pcre (3.3.1)
- Locking composer/semver (3.4.2)
- Locking composer/spdx-licenses (1.5.8)
- Locking composer/xdebug-handler (3.0.5)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking doctrine/deprecations (1.1.3)
- Locking felixfbecker/advanced-json-rpc (v3.2.1)
- Locking mediawiki/mediawiki-codesniffer (v44.0.0)
- Locking mediawiki/mediawiki-phan-config (0.14.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking mediawiki/phan-taint-check-plugin (6.0.0)
- Locking microsoft/tolerant-php-parser (v0.1.2)
- Locking netresearch/jsonmapper (v4.5.0)
- Locking phan/phan (5.4.3)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.11)
- Locking phpdocumentor/reflection-common (2.2.0)
- Locking phpdocumentor/reflection-docblock (5.5.1)
- Locking phpdocumentor/type-resolver (1.10.0)
- Locking phpstan/phpdoc-parser (1.33.0)
- Locking psr/container (2.0.2)
- Locking psr/log (3.0.2)
- Locking sabre/event (5.1.7)
- Locking squizlabs/php_codesniffer (3.9.0)
- Locking symfony/console (v7.1.7)
- Locking symfony/deprecation-contracts (v3.5.0)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-intl-grapheme (v1.31.0)
- Locking symfony/polyfill-intl-normalizer (v1.31.0)
- Locking symfony/polyfill-mbstring (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking symfony/service-contracts (v3.5.0)
- Locking symfony/string (v7.1.6)
- Locking tysonandre/var_representation_polyfill (0.1.3)
- Locking webmozart/assert (1.11.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 38 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing squizlabs/php_codesniffer (3.9.0): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing composer/pcre (3.3.1): Extracting archive
- Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.11): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.2): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v44.0.0): Extracting archive
- Installing tysonandre/var_representation_polyfill (0.1.3): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
- Installing symfony/string (v7.1.6): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.0): Extracting archive
- Installing symfony/console (v7.1.7): Extracting archive
- Installing sabre/event (5.1.7): Extracting archive
- Installing netresearch/jsonmapper (v4.5.0): Extracting archive
- Installing microsoft/tolerant-php-parser (v0.1.2): Extracting archive
- Installing webmozart/assert (1.11.0): Extracting archive
- Installing phpstan/phpdoc-parser (1.33.0): Extracting archive
- Installing phpdocumentor/reflection-common (2.2.0): Extracting archive
- Installing doctrine/deprecations (1.1.3): Extracting archive
- Installing phpdocumentor/type-resolver (1.10.0): Extracting archive
- Installing phpdocumentor/reflection-docblock (5.5.1): Extracting archive
- Installing felixfbecker/advanced-json-rpc (v3.2.1): Extracting archive
- Installing psr/log (3.0.2): Extracting archive
- Installing composer/xdebug-handler (3.0.5): Extracting archive
- Installing phan/phan (5.4.3): Extracting archive
- Installing mediawiki/phan-taint-check-plugin (6.0.0): Extracting archive
- Installing mediawiki/mediawiki-phan-config (0.14.0): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/36 [>---------------------------] 0%
20/36 [===============>------------] 55%
35/36 [===========================>] 97%
36/36 [============================] 100%
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 44.0.0 -> 45.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 4 updates, 0 removals
- Upgrading composer/semver (3.4.2 => 3.4.3)
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0)
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12)
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 4 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12): Extracting archive
- Upgrading composer/semver (3.4.2 => 3.4.3): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0): Extracting archive
0/4 [>---------------------------] 0%
3/4 [=====================>------] 75%
4/4 [============================] 100%
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: set()
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":17,"warnings":0,"fixable":17},"files":{"\/src\/repo\/src\/WikiProject\/CannotQueryWikibaseException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikiProject\/CannotQueryWDQSException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/Exception\/AuthenticationException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikiProject\/CannotQueryWikiProjectsException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/Exception\/InvalidGrantIDException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/Exception\/FluxxRequestException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/Handlers\/SchemaChangesHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/Handlers\/EventDetailsHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikimediaCampaignEventsServices.php":{"errors":5,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?ContainerInterface $services = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":20,"column":44},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?ContainerInterface $services = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":24,"column":46},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?ContainerInterface $services = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":28,"column":44},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?ContainerInterface $services = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":32,"column":52},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?ContainerInterface $services = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":36,"column":54}]},"\/src\/repo\/src\/Grants\/GrantsStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/DeleteGrantIdHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/WikimediaCampaignEventsExtensionJsonTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/WikimediaCampaignEventsServicesTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/GetGrantIdHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/Handlers\/EventRegistrationFormHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/GrantIDLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikiProject\/WikiProjectIDLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/UpdateGrantIdHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/WikiProject\/WikiProjectFullLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Grants\/GrantsStoreTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/GrantIDLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikiProject\/WikiProjectFullLookup.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $lastEntity = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":54,"column":9}]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/Rest\/DeleteGrantIdHandlerTest.php":{"errors":3,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?IEventLookup $eventLookup = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":33,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?PermissionChecker $permissionChecker = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":34,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?GrantsStore $grantsStore = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":35,"column":9}]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/Rest\/GetGrantIdHandlerTest.php":{"errors":3,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?IEventLookup $eventLookup = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":31,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?PermissionChecker $permissionChecker = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":32,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?GrantsStore $grantsStore = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":33,"column":9}]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/FluxxClientTest.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?WANObjectCache $cache = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":29,"column":9}]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/Rest\/UpdateGrantIdHandlerTest.php":{"errors":4,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?IEventLookup $eventLookup = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":46,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?PermissionChecker $permissionChecker = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":47,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?GrantIDLookup $grantIdLookup = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":48,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?GrantsStore $grantsStore = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":49,"column":9}]},"\/src\/repo\/src\/Grants\/FluxxClient.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/Handlers\/CollaborationListHandler.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":17,"warnings":0,"fixable":17},"files":{"\/src\/repo\/src\/WikiProject\/CannotQueryWikibaseException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikiProject\/CannotQueryWDQSException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikiProject\/CannotQueryWikiProjectsException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/Exception\/AuthenticationException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/Exception\/FluxxRequestException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/Exception\/InvalidGrantIDException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/Handlers\/SchemaChangesHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/Handlers\/EventDetailsHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/GrantsStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikimediaCampaignEventsServices.php":{"errors":5,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?ContainerInterface $services = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":20,"column":44},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?ContainerInterface $services = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":24,"column":46},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?ContainerInterface $services = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":28,"column":44},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?ContainerInterface $services = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":32,"column":52},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?ContainerInterface $services = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":36,"column":54}]},"\/src\/repo\/src\/Rest\/DeleteGrantIdHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/WikimediaCampaignEventsServicesTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikiProject\/WikiProjectIDLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/WikimediaCampaignEventsExtensionJsonTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/GetGrantIdHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Grants\/GrantsStoreTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/UpdateGrantIdHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/GrantIDLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/Handlers\/EventRegistrationFormHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/GrantIDLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/FluxxClient.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/Rest\/GetGrantIdHandlerTest.php":{"errors":3,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?IEventLookup $eventLookup = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":31,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?PermissionChecker $permissionChecker = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":32,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?GrantsStore $grantsStore = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":33,"column":9}]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/Rest\/DeleteGrantIdHandlerTest.php":{"errors":3,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?IEventLookup $eventLookup = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":33,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?PermissionChecker $permissionChecker = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":34,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?GrantsStore $grantsStore = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":35,"column":9}]},"\/src\/repo\/src\/WikiProject\/WikiProjectFullLookup.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $lastEntity = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":54,"column":9}]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/Rest\/UpdateGrantIdHandlerTest.php":{"errors":4,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?IEventLookup $eventLookup = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":46,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?PermissionChecker $permissionChecker = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":47,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?GrantIDLookup $grantIdLookup = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":48,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?GrantsStore $grantsStore = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":49,"column":9}]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/FluxxClientTest.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?WANObjectCache $cache = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":29,"column":9}]},"\/src\/repo\/tests\/phpunit\/unit\/WikiProject\/WikiProjectFullLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/Handlers\/CollaborationListHandler.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
* sniff MediaWiki.Usage.NullableType.ExplicitNullableTypes is now failing
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude node_modules --exclude vendor
> phpcs -sp --cache
> minus-x check .
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
.............................. 30/30 (100%)
Checked 30 files in 0.2 seconds
No syntax error found
.............................. 30 / 30 (100%)
Time: 236ms; Memory: 16MB
MinusX
======
Processing /src/repo...
.............................................................
....................................
All good!
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 417,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 417
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Usage.NullableType.ExplicitNullableTypes
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpmvxknzff
--- stdout ---
[REL1_43 c97d73e] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
2 files changed, 4 insertions(+), 2 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From c97d73e7fac23cc5b92e20b2fa890edc676a6454 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sun, 10 Nov 2024 17:30:55 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Usage.NullableType.ExplicitNullableTypes
Change-Id: I93571a63721f1da5db1b31676f845eb39dc5ed33
---
.phpcs.xml | 4 +++-
composer.json | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index 249407f..1169123 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,6 +1,8 @@
<?xml version="1.0"?>
<ruleset>
- <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
+ <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude name="MediaWiki.Usage.NullableType.ExplicitNullableTypes" />
+ </rule>
<rule ref="Generic.PHP.RequireStrictTypes" />
<file>.</file>
<arg name="extensions" value="php" />
diff --git a/composer.json b/composer.json
index 888d6f7..b643eeb 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/mediawiki-phan-config": "0.14.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
--
2.39.2
--- end ---