This run took 21 seconds.
From a9858f84d5a0a4105152a9bb2e97a6d86de38488 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Wed, 13 Nov 2024 04:15:08 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
Change-Id: Ifea28112393848ba611e81f7c6ce29ad5406a944
---
composer.json | 2 +-
src/Renderer/PageHeader.php | 8 ++++----
src/Renderer/PageHeader/Category.php | 4 ++--
src/Renderer/PageHeader/EditButton.php | 4 ++--
src/Renderer/PageHeader/LastEdit.php | 12 ++++++------
src/Renderer/Panel.php | 6 +++---
src/Structure/TemplateStructure.php | 2 +-
src/Template.php | 2 +-
8 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/composer.json b/composer.json
index 4fb5f85..e779639 100644
--- a/composer.json
+++ b/composer.json
@@ -17,7 +17,7 @@
"composer/installers": "~1.0"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0"
diff --git a/src/Renderer/PageHeader.php b/src/Renderer/PageHeader.php
index 492658e..b41358a 100644
--- a/src/Renderer/PageHeader.php
+++ b/src/Renderer/PageHeader.php
@@ -42,8 +42,8 @@ abstract class PageHeader extends Renderer {
* @param QuickTemplate|null $skinTemplate
*/
protected function __construct( Config $config, Params $params,
- LinkRenderer $linkRenderer = null, IContextSource $context = null,
- $name = '', QuickTemplate $skinTemplate = null ) {
+ ?LinkRenderer $linkRenderer = null, ?IContextSource $context = null,
+ $name = '', ?QuickTemplate $skinTemplate = null ) {
parent::__construct( $config, $params, $linkRenderer, $context, $name );
$this->skinTemplate = $skinTemplate;
}
@@ -60,8 +60,8 @@ abstract class PageHeader extends Renderer {
* @return Renderer
*/
public static function factory( $name, MediaWikiServices $services, Config $config,
- Params $params, IContextSource $context = null, LinkRenderer $linkRenderer = null,
- QuickTemplate $skinTemplate = null ) {
+ Params $params, ?IContextSource $context = null, ?LinkRenderer $linkRenderer = null,
+ ?QuickTemplate $skinTemplate = null ) {
if ( !$context ) {
$context = $params->get(
static::PARAM_CONTEXT,
diff --git a/src/Renderer/PageHeader/Category.php b/src/Renderer/PageHeader/Category.php
index 0e5a656..38a70fb 100644
--- a/src/Renderer/PageHeader/Category.php
+++ b/src/Renderer/PageHeader/Category.php
@@ -25,8 +25,8 @@ class Category extends PageHeader {
* @param QuickTemplate|null $skinTemplate
*/
protected function __construct( Config $config, Params $params,
- LinkRenderer $linkRenderer = null, IContextSource $context = null,
- $name = '', QuickTemplate $skinTemplate = null ) {
+ ?LinkRenderer $linkRenderer = null, ?IContextSource $context = null,
+ $name = '', ?QuickTemplate $skinTemplate = null ) {
parent::__construct( $config, $params, $linkRenderer, $context, $name, $skinTemplate );
$this->args[static::PARAM_CATEGORY_NAMES] = $params->get(
diff --git a/src/Renderer/PageHeader/EditButton.php b/src/Renderer/PageHeader/EditButton.php
index 8d18cf1..3b91397 100644
--- a/src/Renderer/PageHeader/EditButton.php
+++ b/src/Renderer/PageHeader/EditButton.php
@@ -25,8 +25,8 @@ class EditButton extends PageHeader {
* @param QuickTemplate|null $skinTemplate
*/
protected function __construct( Config $config, Params $params,
- LinkRenderer $linkRenderer = null, IContextSource $context = null,
- $name = '', QuickTemplate $skinTemplate = null ) {
+ ?LinkRenderer $linkRenderer = null, ?IContextSource $context = null,
+ $name = '', ?QuickTemplate $skinTemplate = null ) {
parent::__construct( $config, $params, $linkRenderer, $context, $name, $skinTemplate );
$this->args[static::FEATURED_ACTIONS] = $params->get(
diff --git a/src/Renderer/PageHeader/LastEdit.php b/src/Renderer/PageHeader/LastEdit.php
index c927138..3434e8e 100644
--- a/src/Renderer/PageHeader/LastEdit.php
+++ b/src/Renderer/PageHeader/LastEdit.php
@@ -46,9 +46,9 @@ class LastEdit extends PageHeader {
* @param RevisionStore|null $revisionStore
*/
protected function __construct( Config $config, Params $params,
- LinkRenderer $linkRenderer = null, IContextSource $context = null,
- $name = '', QuickTemplate $skinTemplate = null, UtilityFactory $util = null,
- RevisionStore $revisionStore = null ) {
+ ?LinkRenderer $linkRenderer = null, ?IContextSource $context = null,
+ $name = '', ?QuickTemplate $skinTemplate = null, ?UtilityFactory $util = null,
+ ?RevisionStore $revisionStore = null ) {
parent::__construct( $config, $params, $linkRenderer, $context, $name, $skinTemplate );
$this->util = $util;
@@ -69,9 +69,9 @@ class LastEdit extends PageHeader {
* @return Renderer
*/
public static function factory( $name, MediaWikiServices $services, Config $config,
- Params $params, IContextSource $context = null, LinkRenderer $linkRenderer = null,
- QuickTemplate $skinTemplate = null, UtilityFactory $util = null,
- RevisionStore $revisionStore = null ) {
+ Params $params, ?IContextSource $context = null, ?LinkRenderer $linkRenderer = null,
+ ?QuickTemplate $skinTemplate = null, ?UtilityFactory $util = null,
+ ?RevisionStore $revisionStore = null ) {
if ( !$context ) {
$context = $params->get(
static::PARAM_CONTEXT,
diff --git a/src/Renderer/Panel.php b/src/Renderer/Panel.php
index dac57b3..1dcf89b 100644
--- a/src/Renderer/Panel.php
+++ b/src/Renderer/Panel.php
@@ -39,9 +39,9 @@ class Panel extends TemplateRenderer {
* @param TemplateFactory|null $templateFactory
*/
protected function __construct( Config $config, Params $params,
- LinkRenderer $linkRenderer = null, IContextSource $context = null,
- $name = '', CacheHelper $cacheHelper = null,
- TemplateFactory $templateFactory = null ) {
+ ?LinkRenderer $linkRenderer = null, ?IContextSource $context = null,
+ $name = '', ?CacheHelper $cacheHelper = null,
+ ?TemplateFactory $templateFactory = null ) {
parent::__construct(
$config,
$params,
diff --git a/src/Structure/TemplateStructure.php b/src/Structure/TemplateStructure.php
index 22c22b9..8c15669 100644
--- a/src/Structure/TemplateStructure.php
+++ b/src/Structure/TemplateStructure.php
@@ -32,7 +32,7 @@ abstract class TemplateStructure extends \Skins\Chameleon\Components\Structure {
* @param DOMElement|null $domElement
* @param int $indent
*/
- public function __construct( ChameleonTemplate $template, DOMElement $domElement = null,
+ public function __construct( ChameleonTemplate $template, ?DOMElement $domElement = null,
$indent = 0 ) {
parent::__construct( $template, $domElement, $indent );
$this->idRegistry = IdRegistry::getRegistry();
diff --git a/src/Template.php b/src/Template.php
index ffdc2d7..b5891d7 100644
--- a/src/Template.php
+++ b/src/Template.php
@@ -21,7 +21,7 @@ class Template extends \Skins\Chameleon\ChameleonTemplate {
*
* @param \Config|null $config
*/
- public function __construct( \Config $config = null ) {
+ public function __construct( ?\Config $config = null ) {
parent::__construct( $config );
$this->skinDataFieldDefinition =
--
2.39.2
$ date
--- stdout ---
Wed Nov 13 04:14:53 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-skins-BlueSpiceCalumma.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
94666da790b5b3892fd20622cd9c894e16201fb8 refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 315,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 315
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 22 installs, 0 updates, 0 removals
- Locking composer/installers (v1.12.0)
- Locking composer/semver (3.4.2)
- Locking composer/spdx-licenses (1.5.8)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking mediawiki/mediawiki-codesniffer (v44.0.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.11)
- Locking psr/container (2.0.2)
- Locking squizlabs/php_codesniffer (3.9.0)
- Locking symfony/console (v7.1.7)
- Locking symfony/deprecation-contracts (v3.5.0)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-intl-grapheme (v1.31.0)
- Locking symfony/polyfill-intl-normalizer (v1.31.0)
- Locking symfony/polyfill-mbstring (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking symfony/service-contracts (v3.5.0)
- Locking symfony/string (v7.1.6)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 22 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing composer/installers (v1.12.0): Extracting archive
- Installing squizlabs/php_codesniffer (3.9.0): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.11): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.2): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v44.0.0): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
- Installing symfony/string (v7.1.6): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.0): Extracting archive
- Installing symfony/console (v7.1.7): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/19 [>---------------------------] 0%
19/19 [============================] 100%
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 44.0.0 -> 45.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 4 updates, 0 removals
- Upgrading composer/semver (3.4.2 => 3.4.3)
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0)
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12)
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 4 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12): Extracting archive
- Upgrading composer/semver (3.4.2 => 3.4.3): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0): Extracting archive
0/4 [>---------------------------] 0%
3/4 [=====================>------] 75%
4/4 [============================] 100%
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: {'MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic', 'MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic', 'MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected', 'MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate', 'MediaWiki.Commenting.FunctionComment.TypeTypeHintParam', 'MediaWiki.Commenting.FunctionComment.TypeTypeHintReturn'}
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":49,"warnings":2,"fixable":28},"files":{"\/src\/repo\/src\/Controls\/SplitButtonDropdown.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/IControl.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Controls\/SingleButtonDropdown.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/IBreadcrumbRootNode.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/BeforePageDisplay\/HistoryBacklink.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Renderer\/CustomMenu\/Menu.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/BeforePageDisplay\/AddFoucFix.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/IPanel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/CustomMenu\/Header.php":{"errors":0,"warnings":1,"messages":[{"message":"`type` should not be used as a typehint, the actual type should be used","source":"MediaWiki.Commenting.FunctionComment.TypeTypeHintReturn","severity":5,"fixable":false,"type":"WARNING","line":11,"column":16}]},"\/src\/repo\/src\/BreadcrumbRootNode\/SpecialFilelist.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/BreadcrumbRootNode\/SpecialCategories.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/GetPreferences\/UserPreferences.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/BreadcrumbRootNode\/SpecialSpecialPages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/IActiveStateProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Controls\/TemplateControl.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/BreadcrumbRootNodeBase.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/MobileSearchForm.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/CookieHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ConfigDefinition\/BlueSpiceCalummaCustomMenuHeaderCollapse.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/BreadcrumbRootNode\/SpecialAllPages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/BreadcrumbRootNode\/NamespaceMainPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/Wrapper.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/Nav.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/Header.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/LinkListGroup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/BreadcrumbRootNode\/NamespacePortalPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Controls\/VersionPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/BreadcrumbRootNode\/SpecialAllTemplates.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/Banner.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/ChameleonSkinTemplateOutputPageBeforeExec\/AddToGlobalActions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/SkinDataPanel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/ChameleonSkinTemplateOutputPageBeforeExec.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/FlexiSkin\/Subscriber.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Renderer\/CustomMenu\/Menu\/Item.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/SiteNavTabs.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":13,"column":15}]},"\/src\/repo\/src\/Components\/CustomMenu.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Renderer\/PageHeader\/Context.php":{"errors":2,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":14,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate","severity":5,"fixable":false,"type":"ERROR","line":82,"column":13}]},"\/src\/repo\/src\/Components\/Footer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Skin.php":{"errors":4,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":13,"column":12},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":14,"column":12},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":15,"column":12},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":16,"column":12}]},"\/src\/repo\/src\/Renderer\/PageHeader.php":{"errors":6,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?LinkRenderer $linkRenderer = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":45,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?IContextSource $context = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":45,"column":44},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?QuickTemplate $skinTemplate = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":46,"column":21},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?IContextSource $context = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":63,"column":25},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?LinkRenderer $linkRenderer = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":63,"column":57},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?QuickTemplate $skinTemplate = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":64,"column":9}]},"\/src\/repo\/src\/Components\/DivWrapper.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AlertProvider\/OldVersion.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/Logo.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/DataBeforeContent.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/SimpleLinkListGroup.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":7,"column":15}]},"\/src\/repo\/src\/Components\/MobileMoreMenu.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/DataAfterContent.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/Notifications.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/ToggleButton.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Renderer\/Panel.php":{"errors":4,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?LinkRenderer $linkRenderer = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":42,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?IContextSource $context = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":42,"column":44},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?CacheHelper $cacheHelper = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":43,"column":21},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?TemplateFactory $templateFactory = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":44,"column":9}]},"\/src\/repo\/src\/Components\/PageLayout.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/PageContent.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/ToolPaneTabs.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":13,"column":15}]},"\/src\/repo\/src\/Components\/MobileNav.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/SidebarToggle.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":10,"column":15}]},"\/src\/repo\/src\/Components\/Content.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/CollapsibleGroup.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":9,"column":15}]},"\/src\/repo\/src\/AssocLinksCollector.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/IFlyout.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/SiteNavigation.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/SearchForm.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/LinkList.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/OutputPageBodyAttributes\/AddToBodyAttributes.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Renderer\/PageHeader\/EditButton.php":{"errors":3,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?LinkRenderer $linkRenderer = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":28,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?IContextSource $context = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":28,"column":44},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?QuickTemplate $skinTemplate = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":29,"column":21}]},"\/src\/repo\/src\/Renderer\/PageHeader\/Category.php":{"errors":3,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?LinkRenderer $linkRenderer = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":28,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?IContextSource $context = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":28,"column":44},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?QuickTemplate $skinTemplate = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":29,"column":21}]},"\/src\/repo\/src\/Components\/Aside.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/FeaturedActions.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate","severity":5,"fixable":false,"type":"ERROR","line":119,"column":13}]},"\/src\/repo\/src\/Components\/MobileFeaturedActionsButton.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/MobileLoginButton.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/MobileNotificationsButton.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/PlainHTML.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/Toolbox.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/StandardSkinDataLinkList.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate","severity":5,"fixable":false,"type":"ERROR","line":22,"column":13}]},"\/src\/repo\/src\/Panel\/AssocLinks.php":{"errors":2,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":11,"column":15},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":30,"column":15}]},"\/src\/repo\/src\/Components\/UserButton.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/SkinDataFieldDefinition.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate","severity":5,"fixable":false,"type":"ERROR","line":368,"column":20}]},"\/src\/repo\/src\/Panel\/ContentActions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Renderer\/PageHeader\/LastEdit.php":{"errors":10,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?LinkRenderer $linkRenderer = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":49,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?IContextSource $context = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":49,"column":44},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?QuickTemplate $skinTemplate = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":50,"column":21},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?UtilityFactory $util = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":50,"column":57},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?RevisionStore $revisionStore = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":51,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?IContextSource $context = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":72,"column":25},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?LinkRenderer $linkRenderer = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":72,"column":57},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?QuickTemplate $skinTemplate = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":73,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?UtilityFactory $util = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":73,"column":45},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?RevisionStore $revisionStore = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":74,"column":9}]},"\/src\/repo\/src\/Panel\/PageTools.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/FullScreenButton.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/Edit.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/QualityManagement.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":83,"column":12}]},"\/src\/repo\/src\/DataProvider\/MobileMoreMenuData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/PageInfo.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/Categories.php":{"errors":2,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":10,"column":15},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":29,"column":15}]},"\/src\/repo\/src\/AssocLinksProvider\/HistoryView.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/Form.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/BasePanel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/PanelContainer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AssocLinksProvider\/CustomCallback.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/Views.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/TemplateComponent.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Template.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?\\Config $config = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":24,"column":34}]},"\/src\/repo\/SkinBlueSpiceCalumma.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AssocLinksProvider\/RootPageSibling.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/BreadcrumbRootNode\/NamespacePortalPageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Setup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/BreadcrumbRootNode\/SpecialSpecialPagesTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/MobileUserContainer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Renderer\/PageHeader\/BreadCrumb.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AssocLinksProvider\/MappedSiblings.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/GlobalActions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/BreadcrumbRootNode\/SpecialAllPagesTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/UserSidebar.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/BreadcrumbRootNode\/NamespaceMainPageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AssocLinksProvider\/ExistingSiblings.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Structure\/TabPanelStructure.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/DataProvider\/FeaturedActionsData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/PanelFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/MediaWikiSidebar.php":{"errors":2,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":119,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate","severity":5,"fixable":false,"type":"ERROR","line":176,"column":13}]},"\/src\/repo\/tests\/phpunit\/AssocLinksProvider\/HistoryViewTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/PageHeader.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/Export.php":{"errors":0,"warnings":1,"messages":[{"message":"`type` should not be used as a typehint, the actual type should be used","source":"MediaWiki.Commenting.FunctionComment.TypeTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":37,"column":8}]},"\/src\/repo\/tests\/phpunit\/AssocLinksProvider\/CustomCallbackTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Structure\/TemplateStructure.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?DOMElement $domElement = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":35,"column":63}]},"\/src\/repo\/src\/Components\/LanguageSelector.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcbf
--- stdout ---
PHPCBF RESULT SUMMARY
----------------------------------------------------------------------
FILE FIXED REMAINING
----------------------------------------------------------------------
/src/repo/src/Renderer/PageHeader.php 6 0
/src/repo/src/Template.php 1 0
/src/repo/src/Renderer/PageHeader/Category.php 3 0
/src/repo/src/Renderer/Panel.php 4 0
/src/repo/src/Renderer/PageHeader/EditButton.php 3 0
/src/repo/src/Structure/TemplateStructure.php 1 0
/src/repo/src/Renderer/PageHeader/LastEdit.php 10 0
----------------------------------------------------------------------
A TOTAL OF 28 ERRORS WERE FIXED IN 7 FILES
----------------------------------------------------------------------
Time: 1.23 secs; Memory: 6MB
--- end ---
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":21,"warnings":2,"fixable":0},"files":{"\/src\/repo\/src\/IControl.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Controls\/SplitButtonDropdown.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Controls\/SingleButtonDropdown.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/BeforePageDisplay\/HistoryBacklink.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Renderer\/CustomMenu\/Menu.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/BeforePageDisplay\/AddFoucFix.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/IBreadcrumbRootNode.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/GetPreferences\/UserPreferences.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/IActiveStateProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/IPanel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/BreadcrumbRootNode\/SpecialFilelist.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/CustomMenu\/Header.php":{"errors":0,"warnings":1,"messages":[{"message":"`type` should not be used as a typehint, the actual type should be used","source":"MediaWiki.Commenting.FunctionComment.TypeTypeHintReturn","severity":5,"fixable":false,"type":"WARNING","line":11,"column":16}]},"\/src\/repo\/src\/BreadcrumbRootNode\/SpecialSpecialPages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Controls\/TemplateControl.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/BreadcrumbRootNodeBase.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ConfigDefinition\/BlueSpiceCalummaCustomMenuHeaderCollapse.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/BreadcrumbRootNode\/SpecialAllPages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/Wrapper.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/BreadcrumbRootNode\/SpecialCategories.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/Header.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/CookieHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/BreadcrumbRootNode\/NamespaceMainPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/BreadcrumbRootNode\/SpecialAllTemplates.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/MobileSearchForm.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/BreadcrumbRootNode\/NamespacePortalPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/Banner.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/Nav.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/LinkListGroup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Controls\/VersionPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/SkinDataPanel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Skin.php":{"errors":4,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":13,"column":12},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":14,"column":12},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":15,"column":12},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":16,"column":12}]},"\/src\/repo\/src\/FlexiSkin\/Subscriber.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Renderer\/CustomMenu\/Menu\/Item.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AlertProvider\/OldVersion.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/ChameleonSkinTemplateOutputPageBeforeExec\/AddToGlobalActions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/ChameleonSkinTemplateOutputPageBeforeExec.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/Footer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/SiteNavTabs.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":13,"column":15}]},"\/src\/repo\/src\/Components\/DataBeforeContent.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Renderer\/PageHeader.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Renderer\/PageHeader\/Context.php":{"errors":2,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":14,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate","severity":5,"fixable":false,"type":"ERROR","line":82,"column":13}]},"\/src\/repo\/src\/Components\/SimpleLinkListGroup.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":7,"column":15}]},"\/src\/repo\/src\/Components\/PageLayout.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/MobileMoreMenu.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/Logo.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/Notifications.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/DataAfterContent.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/MobileNav.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/DivWrapper.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/CustomMenu.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Renderer\/Panel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/ToggleButton.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/SearchForm.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/Content.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/PageContent.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AssocLinksCollector.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/IFlyout.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/FeaturedActions.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate","severity":5,"fixable":false,"type":"ERROR","line":119,"column":13}]},"\/src\/repo\/src\/Panel\/SiteNavigation.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/MobileFeaturedActionsButton.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/CollapsibleGroup.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":9,"column":15}]},"\/src\/repo\/src\/Panel\/LinkList.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/OutputPageBodyAttributes\/AddToBodyAttributes.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/ToolPaneTabs.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":13,"column":15}]},"\/src\/repo\/src\/Components\/SidebarToggle.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":10,"column":15}]},"\/src\/repo\/src\/Renderer\/PageHeader\/EditButton.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/Aside.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/PlainHTML.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/MobileNotificationsButton.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/AssocLinks.php":{"errors":2,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":11,"column":15},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":30,"column":15}]},"\/src\/repo\/src\/Renderer\/PageHeader\/Category.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/StandardSkinDataLinkList.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate","severity":5,"fixable":false,"type":"ERROR","line":22,"column":13}]},"\/src\/repo\/src\/Panel\/ContentActions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/MobileLoginButton.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/QualityManagement.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":83,"column":12}]},"\/src\/repo\/src\/Panel\/Edit.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/DataProvider\/MobileMoreMenuData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/PageInfo.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Renderer\/PageHeader\/LastEdit.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/Toolbox.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/UserButton.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/SkinDataFieldDefinition.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate","severity":5,"fixable":false,"type":"ERROR","line":368,"column":20}]},"\/src\/repo\/src\/AssocLinksProvider\/CustomCallback.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/FullScreenButton.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AssocLinksProvider\/MappedSiblings.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/Categories.php":{"errors":2,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":10,"column":15},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":29,"column":15}]},"\/src\/repo\/src\/Panel\/Form.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AssocLinksProvider\/HistoryView.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/PageTools.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/BasePanel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Renderer\/PageHeader\/BreadCrumb.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/PanelContainer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Template.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/SkinBlueSpiceCalumma.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/Views.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/TemplateComponent.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/UserSidebar.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/BreadcrumbRootNode\/NamespacePortalPageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AssocLinksProvider\/RootPageSibling.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/BreadcrumbRootNode\/SpecialSpecialPagesTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Setup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Structure\/TabPanelStructure.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/BreadcrumbRootNode\/SpecialAllPagesTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/BreadcrumbRootNode\/NamespaceMainPageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AssocLinksProvider\/ExistingSiblings.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/AssocLinksProvider\/HistoryViewTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/DataProvider\/FeaturedActionsData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/MediaWikiSidebar.php":{"errors":2,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":119,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate","severity":5,"fixable":false,"type":"ERROR","line":176,"column":13}]},"\/src\/repo\/tests\/phpunit\/AssocLinksProvider\/CustomCallbackTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/PanelFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/Export.php":{"errors":0,"warnings":1,"messages":[{"message":"`type` should not be used as a typehint, the actual type should be used","source":"MediaWiki.Commenting.FunctionComment.TypeTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":37,"column":8}]},"\/src\/repo\/src\/Structure\/TemplateStructure.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/MobileUserContainer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/PageHeader.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Panel\/GlobalActions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Components\/LanguageSelector.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> minus-x check .
> phpcs -sp
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
............................................................ 60/116 ( 51%)
........................................................ 116/116 (100%)
Checked 116 files in 0.6 seconds
No syntax error found
MinusX
======
Processing /src/repo...
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
...........................................................
All good!
.......................................................... 58 / 58 (100%)
Time: 1.07 secs; Memory: 6MB
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 315,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 315
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpervo8j__
--- stdout ---
[master a9858f8] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
8 files changed, 20 insertions(+), 20 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From a9858f84d5a0a4105152a9bb2e97a6d86de38488 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Wed, 13 Nov 2024 04:15:08 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
Change-Id: Ifea28112393848ba611e81f7c6ce29ad5406a944
---
composer.json | 2 +-
src/Renderer/PageHeader.php | 8 ++++----
src/Renderer/PageHeader/Category.php | 4 ++--
src/Renderer/PageHeader/EditButton.php | 4 ++--
src/Renderer/PageHeader/LastEdit.php | 12 ++++++------
src/Renderer/Panel.php | 6 +++---
src/Structure/TemplateStructure.php | 2 +-
src/Template.php | 2 +-
8 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/composer.json b/composer.json
index 4fb5f85..e779639 100644
--- a/composer.json
+++ b/composer.json
@@ -17,7 +17,7 @@
"composer/installers": "~1.0"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0"
diff --git a/src/Renderer/PageHeader.php b/src/Renderer/PageHeader.php
index 492658e..b41358a 100644
--- a/src/Renderer/PageHeader.php
+++ b/src/Renderer/PageHeader.php
@@ -42,8 +42,8 @@ abstract class PageHeader extends Renderer {
* @param QuickTemplate|null $skinTemplate
*/
protected function __construct( Config $config, Params $params,
- LinkRenderer $linkRenderer = null, IContextSource $context = null,
- $name = '', QuickTemplate $skinTemplate = null ) {
+ ?LinkRenderer $linkRenderer = null, ?IContextSource $context = null,
+ $name = '', ?QuickTemplate $skinTemplate = null ) {
parent::__construct( $config, $params, $linkRenderer, $context, $name );
$this->skinTemplate = $skinTemplate;
}
@@ -60,8 +60,8 @@ abstract class PageHeader extends Renderer {
* @return Renderer
*/
public static function factory( $name, MediaWikiServices $services, Config $config,
- Params $params, IContextSource $context = null, LinkRenderer $linkRenderer = null,
- QuickTemplate $skinTemplate = null ) {
+ Params $params, ?IContextSource $context = null, ?LinkRenderer $linkRenderer = null,
+ ?QuickTemplate $skinTemplate = null ) {
if ( !$context ) {
$context = $params->get(
static::PARAM_CONTEXT,
diff --git a/src/Renderer/PageHeader/Category.php b/src/Renderer/PageHeader/Category.php
index 0e5a656..38a70fb 100644
--- a/src/Renderer/PageHeader/Category.php
+++ b/src/Renderer/PageHeader/Category.php
@@ -25,8 +25,8 @@ class Category extends PageHeader {
* @param QuickTemplate|null $skinTemplate
*/
protected function __construct( Config $config, Params $params,
- LinkRenderer $linkRenderer = null, IContextSource $context = null,
- $name = '', QuickTemplate $skinTemplate = null ) {
+ ?LinkRenderer $linkRenderer = null, ?IContextSource $context = null,
+ $name = '', ?QuickTemplate $skinTemplate = null ) {
parent::__construct( $config, $params, $linkRenderer, $context, $name, $skinTemplate );
$this->args[static::PARAM_CATEGORY_NAMES] = $params->get(
diff --git a/src/Renderer/PageHeader/EditButton.php b/src/Renderer/PageHeader/EditButton.php
index 8d18cf1..3b91397 100644
--- a/src/Renderer/PageHeader/EditButton.php
+++ b/src/Renderer/PageHeader/EditButton.php
@@ -25,8 +25,8 @@ class EditButton extends PageHeader {
* @param QuickTemplate|null $skinTemplate
*/
protected function __construct( Config $config, Params $params,
- LinkRenderer $linkRenderer = null, IContextSource $context = null,
- $name = '', QuickTemplate $skinTemplate = null ) {
+ ?LinkRenderer $linkRenderer = null, ?IContextSource $context = null,
+ $name = '', ?QuickTemplate $skinTemplate = null ) {
parent::__construct( $config, $params, $linkRenderer, $context, $name, $skinTemplate );
$this->args[static::FEATURED_ACTIONS] = $params->get(
diff --git a/src/Renderer/PageHeader/LastEdit.php b/src/Renderer/PageHeader/LastEdit.php
index c927138..3434e8e 100644
--- a/src/Renderer/PageHeader/LastEdit.php
+++ b/src/Renderer/PageHeader/LastEdit.php
@@ -46,9 +46,9 @@ class LastEdit extends PageHeader {
* @param RevisionStore|null $revisionStore
*/
protected function __construct( Config $config, Params $params,
- LinkRenderer $linkRenderer = null, IContextSource $context = null,
- $name = '', QuickTemplate $skinTemplate = null, UtilityFactory $util = null,
- RevisionStore $revisionStore = null ) {
+ ?LinkRenderer $linkRenderer = null, ?IContextSource $context = null,
+ $name = '', ?QuickTemplate $skinTemplate = null, ?UtilityFactory $util = null,
+ ?RevisionStore $revisionStore = null ) {
parent::__construct( $config, $params, $linkRenderer, $context, $name, $skinTemplate );
$this->util = $util;
@@ -69,9 +69,9 @@ class LastEdit extends PageHeader {
* @return Renderer
*/
public static function factory( $name, MediaWikiServices $services, Config $config,
- Params $params, IContextSource $context = null, LinkRenderer $linkRenderer = null,
- QuickTemplate $skinTemplate = null, UtilityFactory $util = null,
- RevisionStore $revisionStore = null ) {
+ Params $params, ?IContextSource $context = null, ?LinkRenderer $linkRenderer = null,
+ ?QuickTemplate $skinTemplate = null, ?UtilityFactory $util = null,
+ ?RevisionStore $revisionStore = null ) {
if ( !$context ) {
$context = $params->get(
static::PARAM_CONTEXT,
diff --git a/src/Renderer/Panel.php b/src/Renderer/Panel.php
index dac57b3..1dcf89b 100644
--- a/src/Renderer/Panel.php
+++ b/src/Renderer/Panel.php
@@ -39,9 +39,9 @@ class Panel extends TemplateRenderer {
* @param TemplateFactory|null $templateFactory
*/
protected function __construct( Config $config, Params $params,
- LinkRenderer $linkRenderer = null, IContextSource $context = null,
- $name = '', CacheHelper $cacheHelper = null,
- TemplateFactory $templateFactory = null ) {
+ ?LinkRenderer $linkRenderer = null, ?IContextSource $context = null,
+ $name = '', ?CacheHelper $cacheHelper = null,
+ ?TemplateFactory $templateFactory = null ) {
parent::__construct(
$config,
$params,
diff --git a/src/Structure/TemplateStructure.php b/src/Structure/TemplateStructure.php
index 22c22b9..8c15669 100644
--- a/src/Structure/TemplateStructure.php
+++ b/src/Structure/TemplateStructure.php
@@ -32,7 +32,7 @@ abstract class TemplateStructure extends \Skins\Chameleon\Components\Structure {
* @param DOMElement|null $domElement
* @param int $indent
*/
- public function __construct( ChameleonTemplate $template, DOMElement $domElement = null,
+ public function __construct( ChameleonTemplate $template, ?DOMElement $domElement = null,
$indent = 0 ) {
parent::__construct( $template, $domElement, $indent );
$this->idRegistry = IdRegistry::getRegistry();
diff --git a/src/Template.php b/src/Template.php
index ffdc2d7..b5891d7 100644
--- a/src/Template.php
+++ b/src/Template.php
@@ -21,7 +21,7 @@ class Template extends \Skins\Chameleon\ChameleonTemplate {
*
* @param \Config|null $config
*/
- public function __construct( \Config $config = null ) {
+ public function __construct( ?\Config $config = null ) {
parent::__construct( $config );
$this->skinDataFieldDefinition =
--
2.39.2
--- end ---