mediawiki/extensions/WSOAuth: main (log #2093093)

sourcepatches

This run took 14 seconds.

From bc8efaf18e6a562a9361ac206fe9019fd950ed72 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sun, 7 Sep 2025 16:09:13 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0

The following sniffs are failing and were disabled:
* MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation
* MediaWiki.Commenting.PropertyAnnotations.UnrecognizedAnnotation

Change-Id: I4668407a2c3aa97b3f31438193c6046deb56dd6c
---
 .phpcs.xml    | 2 ++
 composer.json | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/.phpcs.xml b/.phpcs.xml
index e99e124..dcfbc60 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,6 +1,8 @@
 <?xml version="1.0"?>
 <ruleset>
 	<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+		<exclude name="MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation" />
+		<exclude name="MediaWiki.Commenting.PropertyAnnotations.UnrecognizedAnnotation" />
 		<exclude name="MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals" />
 	</rule>
 	<file>.</file>
diff --git a/composer.json b/composer.json
index 850d1fb..cce87b6 100644
--- a/composer.json
+++ b/composer.json
@@ -4,7 +4,7 @@
 		"league/oauth2-facebook": "^2.0"
 	},
 	"require-dev": {
-		"mediawiki/mediawiki-codesniffer": "47.0.0",
+		"mediawiki/mediawiki-codesniffer": "48.0.0",
 		"mediawiki/minus-x": "1.1.3",
 		"php-parallel-lint/php-console-highlighter": "1.0.0",
 		"php-parallel-lint/php-parallel-lint": "1.4.0"
-- 
2.39.5

$ date
--- stdout ---
Sun Sep  7 16:09:03 UTC 2025

--- end ---
$ git clone file:///srv/git/mediawiki-extensions-WSOAuth.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---

--- end ---
$ git config user.name libraryupgrader
--- stdout ---

--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---

--- end ---
$ git submodule update --init
--- stdout ---

--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.

--- end ---
$ git show-ref refs/heads/master
--- stdout ---
ff94f228abc5bdb25d7b75b4f5788b0c40988708 refs/heads/master

--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
  "auditReportVersion": 2,
  "vulnerabilities": {},
  "metadata": {
    "vulnerabilities": {
      "info": 0,
      "low": 0,
      "moderate": 0,
      "high": 0,
      "critical": 0,
      "total": 0
    },
    "dependencies": {
      "prod": 1,
      "dev": 353,
      "optional": 4,
      "peer": 5,
      "peerOptional": 0,
      "total": 353
    }
  }
}

--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 32 installs, 0 updates, 0 removals
  - Locking composer/semver (3.4.3)
  - Locking composer/spdx-licenses (1.5.9)
  - Locking dealerdirect/phpcodesniffer-composer-installer (v1.1.2)
  - Locking guzzlehttp/guzzle (7.10.0)
  - Locking guzzlehttp/promises (2.3.0)
  - Locking guzzlehttp/psr7 (2.8.0)
  - Locking league/oauth2-client (2.8.1)
  - Locking league/oauth2-facebook (2.2.0)
  - Locking mediawiki/mediawiki-codesniffer (v47.0.0)
  - Locking mediawiki/minus-x (1.1.3)
  - Locking mediawiki/oauthclient (2.3.0)
  - Locking php-parallel-lint/php-console-color (v1.0.1)
  - Locking php-parallel-lint/php-console-highlighter (v1.0.0)
  - Locking php-parallel-lint/php-parallel-lint (v1.4.0)
  - Locking phpcsstandards/phpcsextra (1.2.1)
  - Locking phpcsstandards/phpcsutils (1.0.12)
  - Locking psr/container (2.0.2)
  - Locking psr/http-client (1.0.3)
  - Locking psr/http-factory (1.1.0)
  - Locking psr/http-message (2.0)
  - Locking psr/log (3.0.2)
  - Locking ralouphie/getallheaders (3.0.3)
  - Locking squizlabs/php_codesniffer (3.12.2)
  - Locking symfony/console (v7.3.3)
  - Locking symfony/deprecation-contracts (v3.6.0)
  - Locking symfony/polyfill-ctype (v1.33.0)
  - Locking symfony/polyfill-intl-grapheme (v1.33.0)
  - Locking symfony/polyfill-intl-normalizer (v1.33.0)
  - Locking symfony/polyfill-mbstring (v1.33.0)
  - Locking symfony/polyfill-php80 (v1.33.0)
  - Locking symfony/service-contracts (v3.6.0)
  - Locking symfony/string (v7.3.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 32 installs, 0 updates, 0 removals
    0 [>---------------------------]    0 [->--------------------------]
  - Installing squizlabs/php_codesniffer (3.12.2): Extracting archive
  - Installing dealerdirect/phpcodesniffer-composer-installer (v1.1.2): Extracting archive
  - Installing symfony/deprecation-contracts (v3.6.0): Extracting archive
  - Installing psr/http-message (2.0): Extracting archive
  - Installing psr/http-client (1.0.3): Extracting archive
  - Installing ralouphie/getallheaders (3.0.3): Extracting archive
  - Installing psr/http-factory (1.1.0): Extracting archive
  - Installing guzzlehttp/psr7 (2.8.0): Extracting archive
  - Installing guzzlehttp/promises (2.3.0): Extracting archive
  - Installing guzzlehttp/guzzle (7.10.0): Extracting archive
  - Installing league/oauth2-client (2.8.1): Extracting archive
  - Installing league/oauth2-facebook (2.2.0): Extracting archive
  - Installing symfony/polyfill-php80 (v1.33.0): Extracting archive
  - Installing phpcsstandards/phpcsutils (1.0.12): Extracting archive
  - Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
  - Installing symfony/polyfill-mbstring (v1.33.0): Extracting archive
  - Installing composer/spdx-licenses (1.5.9): Extracting archive
  - Installing composer/semver (3.4.3): Extracting archive
  - Installing mediawiki/mediawiki-codesniffer (v47.0.0): Extracting archive
  - Installing symfony/polyfill-intl-normalizer (v1.33.0): Extracting archive
  - Installing symfony/polyfill-intl-grapheme (v1.33.0): Extracting archive
  - Installing symfony/polyfill-ctype (v1.33.0): Extracting archive
  - Installing symfony/string (v7.3.3): Extracting archive
  - Installing psr/container (2.0.2): Extracting archive
  - Installing symfony/service-contracts (v3.6.0): Extracting archive
  - Installing symfony/console (v7.3.3): Extracting archive
  - Installing mediawiki/minus-x (1.1.3): Extracting archive
  - Installing psr/log (3.0.2): Extracting archive
  - Installing mediawiki/oauthclient (2.3.0): Extracting archive
  - Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
  - Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
  - Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
  0/30 [>---------------------------]   0%
 22/30 [====================>-------]  73%
 30/30 [============================] 100%
1 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating autoload files
18 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils

--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 47.0.0 -> 48.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 5 updates, 1 removal
  - Removing symfony/polyfill-php80 (v1.33.0)
  - Upgrading composer/semver (3.4.3 => 3.4.4)
  - Upgrading mediawiki/mediawiki-codesniffer (v47.0.0 => v48.0.0)
  - Upgrading phpcsstandards/phpcsextra (1.2.1 => 1.4.0)
  - Upgrading phpcsstandards/phpcsutils (1.0.12 => 1.1.1)
  - Upgrading squizlabs/php_codesniffer (3.12.2 => 3.13.2)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 5 updates, 1 removal
    0 [>---------------------------]    0 [->--------------------------]
  - Removing symfony/polyfill-php80 (v1.33.0)
  - Upgrading squizlabs/php_codesniffer (3.12.2 => 3.13.2): Extracting archive
  - Upgrading phpcsstandards/phpcsutils (1.0.12 => 1.1.1): Extracting archive
  - Upgrading phpcsstandards/phpcsextra (1.2.1 => 1.4.0): Extracting archive
  - Upgrading composer/semver (3.4.3 => 3.4.4): Extracting archive
  - Upgrading mediawiki/mediawiki-codesniffer (v47.0.0 => v48.0.0): Extracting archive
 0/5 [>---------------------------]   0%
 4/5 [======================>-----]  80%
 5/5 [============================] 100%
Generating autoload files
17 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils

--- end ---
Previously failing phpcs rules: {'MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals'}
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":13,"warnings":0,"fixable":0},"files":{"\/src\/repo\/src\/Exception\/InvalidAuthProviderClassException.php":{"errors":1,"warnings":0,"messages":[{"message":"@throwable is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":25,"column":4}]},"\/src\/repo\/src\/Exception\/ContinuationException.php":{"errors":1,"warnings":0,"messages":[{"message":"@throwable is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":25,"column":4}]},"\/src\/repo\/WSOAuth.i18n.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Exception\/InitialisationException.php":{"errors":1,"warnings":0,"messages":[{"message":"@throwable is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":25,"column":4}]},"\/src\/repo\/src\/Exception\/FinalisationException.php":{"errors":1,"warnings":0,"messages":[{"message":"@throwable is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":25,"column":4}]},"\/src\/repo\/src\/Exception\/UnknownAuthProviderException.php":{"errors":1,"warnings":0,"messages":[{"message":"@throwable is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":25,"column":4}]},"\/src\/repo\/src\/WSOAuthSchemaUpdater.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WSOAuthConnectRemoteSpecialPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WSOAuthHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthenticationProvider\/AuthProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthenticationProvider\/FacebookAuth.php":{"errors":5,"warnings":0,"messages":[{"message":"\"$_GET\" superglobals should not be accessed.","source":"MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals","severity":5,"fixable":false,"type":"ERROR","line":72,"column":22},{"message":"\"$_GET\" superglobals should not be accessed.","source":"MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals","severity":5,"fixable":false,"type":"ERROR","line":76,"column":22},{"message":"\"$_GET\" superglobals should not be accessed.","source":"MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals","severity":5,"fixable":false,"type":"ERROR","line":76,"column":49},{"message":"\"$_GET\" superglobals should not be accessed.","source":"MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals","severity":5,"fixable":false,"type":"ERROR","line":76,"column":71},{"message":"\"$_GET\" superglobals should not be accessed.","source":"MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals","severity":5,"fixable":false,"type":"ERROR","line":81,"column":89}]},"\/src\/repo\/src\/AuthenticationProvider\/MediaWikiAuth.php":{"errors":2,"warnings":0,"messages":[{"message":"\"$_GET\" superglobals should not be accessed.","source":"MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals","severity":5,"fixable":false,"type":"ERROR","line":109,"column":22},{"message":"\"$_GET\" superglobals should not be accessed.","source":"MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals","severity":5,"fixable":false,"type":"ERROR","line":116,"column":70}]},"\/src\/repo\/maintenance\/multiAuthMigrate.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WSOAuth.php":{"errors":1,"warnings":0,"messages":[{"message":"@public is not a valid property annotation","source":"MediaWiki.Commenting.PropertyAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":62,"column":8}]}}}

--- end ---
PHPCS run failed
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":13,"warnings":0,"fixable":0},"files":{"\/src\/repo\/src\/Exception\/FinalisationException.php":{"errors":1,"warnings":0,"messages":[{"message":"@throwable is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":25,"column":4}]},"\/src\/repo\/src\/Exception\/ContinuationException.php":{"errors":1,"warnings":0,"messages":[{"message":"@throwable is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":25,"column":4}]},"\/src\/repo\/src\/Exception\/InvalidAuthProviderClassException.php":{"errors":1,"warnings":0,"messages":[{"message":"@throwable is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":25,"column":4}]},"\/src\/repo\/src\/Exception\/UnknownAuthProviderException.php":{"errors":1,"warnings":0,"messages":[{"message":"@throwable is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":25,"column":4}]},"\/src\/repo\/src\/Exception\/InitialisationException.php":{"errors":1,"warnings":0,"messages":[{"message":"@throwable is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":25,"column":4}]},"\/src\/repo\/src\/WSOAuthConnectRemoteSpecialPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WSOAuthSchemaUpdater.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/WSOAuth.i18n.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WSOAuthHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthenticationProvider\/AuthProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AuthenticationProvider\/FacebookAuth.php":{"errors":5,"warnings":0,"messages":[{"message":"\"$_GET\" superglobals should not be accessed.","source":"MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals","severity":5,"fixable":false,"type":"ERROR","line":72,"column":22},{"message":"\"$_GET\" superglobals should not be accessed.","source":"MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals","severity":5,"fixable":false,"type":"ERROR","line":76,"column":22},{"message":"\"$_GET\" superglobals should not be accessed.","source":"MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals","severity":5,"fixable":false,"type":"ERROR","line":76,"column":49},{"message":"\"$_GET\" superglobals should not be accessed.","source":"MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals","severity":5,"fixable":false,"type":"ERROR","line":76,"column":71},{"message":"\"$_GET\" superglobals should not be accessed.","source":"MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals","severity":5,"fixable":false,"type":"ERROR","line":81,"column":89}]},"\/src\/repo\/src\/AuthenticationProvider\/MediaWikiAuth.php":{"errors":2,"warnings":0,"messages":[{"message":"\"$_GET\" superglobals should not be accessed.","source":"MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals","severity":5,"fixable":false,"type":"ERROR","line":109,"column":22},{"message":"\"$_GET\" superglobals should not be accessed.","source":"MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals","severity":5,"fixable":false,"type":"ERROR","line":116,"column":70}]},"\/src\/repo\/maintenance\/multiAuthMigrate.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WSOAuth.php":{"errors":1,"warnings":0,"messages":[{"message":"@public is not a valid property annotation","source":"MediaWiki.Commenting.PropertyAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":62,"column":8}]}}}

--- end ---
 * sniff MediaWiki.Commenting.PropertyAnnotations.UnrecognizedAnnotation is now failing
 * sniff MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation is now failing
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---

--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
17 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---

--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> minus-x check .
> phpcs -sp --cache
--- stdout ---
PHP 8.2.28 | 10 parallel jobs
..............                                               14/14 (100%)


Checked 14 files in 0.1 seconds
No syntax error found
MinusX
======
Processing /src/repo...
.......................................................
All good!
.............. 14 / 14 (100%)


Time: 139ms; Memory: 8MB


--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
  "auditReportVersion": 2,
  "vulnerabilities": {},
  "metadata": {
    "vulnerabilities": {
      "info": 0,
      "low": 0,
      "moderate": 0,
      "high": 0,
      "critical": 0,
      "total": 0
    },
    "dependencies": {
      "prod": 1,
      "dev": 353,
      "optional": 4,
      "peer": 5,
      "peerOptional": 0,
      "total": 353
    }
  }
}

--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json

--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 48.0.0

The following sniffs are failing and were disabled:
* MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation
* MediaWiki.Commenting.PropertyAnnotations.UnrecognizedAnnotation

$ git add .
--- stdout ---

--- end ---
$ git commit -F /tmp/tmprx0kw7dg
--- stdout ---
[master bc8efaf] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0
 2 files changed, 3 insertions(+), 1 deletion(-)

--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From bc8efaf18e6a562a9361ac206fe9019fd950ed72 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sun, 7 Sep 2025 16:09:13 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0

The following sniffs are failing and were disabled:
* MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation
* MediaWiki.Commenting.PropertyAnnotations.UnrecognizedAnnotation

Change-Id: I4668407a2c3aa97b3f31438193c6046deb56dd6c
---
 .phpcs.xml    | 2 ++
 composer.json | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/.phpcs.xml b/.phpcs.xml
index e99e124..dcfbc60 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,6 +1,8 @@
 <?xml version="1.0"?>
 <ruleset>
 	<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+		<exclude name="MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation" />
+		<exclude name="MediaWiki.Commenting.PropertyAnnotations.UnrecognizedAnnotation" />
 		<exclude name="MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals" />
 	</rule>
 	<file>.</file>
diff --git a/composer.json b/composer.json
index 850d1fb..cce87b6 100644
--- a/composer.json
+++ b/composer.json
@@ -4,7 +4,7 @@
 		"league/oauth2-facebook": "^2.0"
 	},
 	"require-dev": {
-		"mediawiki/mediawiki-codesniffer": "47.0.0",
+		"mediawiki/mediawiki-codesniffer": "48.0.0",
 		"mediawiki/minus-x": "1.1.3",
 		"php-parallel-lint/php-console-highlighter": "1.0.0",
 		"php-parallel-lint/php-parallel-lint": "1.4.0"
-- 
2.39.5


--- end ---
Source code is licensed under the AGPL.