This run took 12 seconds.
From 51e9e3dad513ad993a70c7f339b837784ec43199 Mon Sep 17 00:00:00 2001 From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org> Date: Sun, 7 Sep 2025 16:17:38 +0000 Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0 The following sniffs are failing and were disabled: * MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation * MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter Change-Id: I4f36abac1fcf6cb9c2440e55e81c6a21fe21986f --- .phpcs.xml | 2 ++ composer.json | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.phpcs.xml b/.phpcs.xml index 645da8f..08c541b 100644 --- a/.phpcs.xml +++ b/.phpcs.xml @@ -1,6 +1,8 @@ <?xml version="1.0"?> <ruleset> <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki"> + <exclude name="MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation" /> + <exclude name="MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter" /> <exclude name="MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected" /> <exclude name="MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage" /> <exclude name="MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage" /> diff --git a/composer.json b/composer.json index 3b0ce02..aff55f0 100644 --- a/composer.json +++ b/composer.json @@ -1,6 +1,6 @@ { "require-dev": { - "mediawiki/mediawiki-codesniffer": "47.0.0", + "mediawiki/mediawiki-codesniffer": "48.0.0", "mediawiki/minus-x": "1.1.3", "php-parallel-lint/php-console-highlighter": "1.0.0", "php-parallel-lint/php-parallel-lint": "1.4.0" -- 2.39.5
$ date --- stdout --- Sun Sep 7 16:17:30 UTC 2025 --- end --- $ git clone file:///srv/git/mediawiki-extensions-WebToolsManager.git repo --depth=1 -b master --- stderr --- Cloning into 'repo'... --- stdout --- --- end --- $ git config user.name libraryupgrader --- stdout --- --- end --- $ git config user.email tools.libraryupgrader@tools.wmflabs.org --- stdout --- --- end --- $ git submodule update --init --- stdout --- --- end --- $ grr init --- stdout --- Installed commit-msg hook. --- end --- $ git show-ref refs/heads/master --- stdout --- 33e046cb1c89e3ac4807d1dadf9a28ffa8996fb5 refs/heads/master --- end --- $ /usr/bin/npm audit --json --- stdout --- { "auditReportVersion": 2, "vulnerabilities": {}, "metadata": { "vulnerabilities": { "info": 0, "low": 0, "moderate": 0, "high": 0, "critical": 0, "total": 0 }, "dependencies": { "prod": 1, "dev": 430, "optional": 0, "peer": 1, "peerOptional": 0, "total": 430 } } } --- end --- $ /usr/bin/composer install --- stderr --- No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information. Loading composer repositories with package information Updating dependencies Lock file operations: 21 installs, 0 updates, 0 removals - Locking composer/semver (3.4.3) - Locking composer/spdx-licenses (1.5.9) - Locking dealerdirect/phpcodesniffer-composer-installer (v1.1.2) - Locking mediawiki/mediawiki-codesniffer (v47.0.0) - Locking mediawiki/minus-x (1.1.3) - Locking php-parallel-lint/php-console-color (v1.0.1) - Locking php-parallel-lint/php-console-highlighter (v1.0.0) - Locking php-parallel-lint/php-parallel-lint (v1.4.0) - Locking phpcsstandards/phpcsextra (1.2.1) - Locking phpcsstandards/phpcsutils (1.0.12) - Locking psr/container (2.0.2) - Locking squizlabs/php_codesniffer (3.12.2) - Locking symfony/console (v7.3.3) - Locking symfony/deprecation-contracts (v3.6.0) - Locking symfony/polyfill-ctype (v1.33.0) - Locking symfony/polyfill-intl-grapheme (v1.33.0) - Locking symfony/polyfill-intl-normalizer (v1.33.0) - Locking symfony/polyfill-mbstring (v1.33.0) - Locking symfony/polyfill-php80 (v1.33.0) - Locking symfony/service-contracts (v3.6.0) - Locking symfony/string (v7.3.3) Writing lock file Installing dependencies from lock file (including require-dev) Package operations: 21 installs, 0 updates, 0 removals 0 [>---------------------------] 0 [->--------------------------] - Installing squizlabs/php_codesniffer (3.12.2): Extracting archive - Installing dealerdirect/phpcodesniffer-composer-installer (v1.1.2): Extracting archive - Installing symfony/polyfill-php80 (v1.33.0): Extracting archive - Installing phpcsstandards/phpcsutils (1.0.12): Extracting archive - Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive - Installing symfony/polyfill-mbstring (v1.33.0): Extracting archive - Installing composer/spdx-licenses (1.5.9): Extracting archive - Installing composer/semver (3.4.3): Extracting archive - Installing mediawiki/mediawiki-codesniffer (v47.0.0): Extracting archive - Installing symfony/polyfill-intl-normalizer (v1.33.0): Extracting archive - Installing symfony/polyfill-intl-grapheme (v1.33.0): Extracting archive - Installing symfony/polyfill-ctype (v1.33.0): Extracting archive - Installing symfony/string (v7.3.3): Extracting archive - Installing symfony/deprecation-contracts (v3.6.0): Extracting archive - Installing psr/container (2.0.2): Extracting archive - Installing symfony/service-contracts (v3.6.0): Extracting archive - Installing symfony/console (v7.3.3): Extracting archive - Installing mediawiki/minus-x (1.1.3): Extracting archive - Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive - Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive - Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive 0/19 [>---------------------------] 0% 19/19 [============================] 100% Generating autoload files 15 packages you are using are looking for funding. Use the `composer fund` command to find out more! --- stdout --- PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils --- end --- Upgrading c:mediawiki/mediawiki-codesniffer from 47.0.0 -> 48.0.0 $ /usr/bin/composer update --- stderr --- Loading composer repositories with package information Updating dependencies Lock file operations: 0 installs, 5 updates, 1 removal - Removing symfony/polyfill-php80 (v1.33.0) - Upgrading composer/semver (3.4.3 => 3.4.4) - Upgrading mediawiki/mediawiki-codesniffer (v47.0.0 => v48.0.0) - Upgrading phpcsstandards/phpcsextra (1.2.1 => 1.4.0) - Upgrading phpcsstandards/phpcsutils (1.0.12 => 1.1.1) - Upgrading squizlabs/php_codesniffer (3.12.2 => 3.13.2) Writing lock file Installing dependencies from lock file (including require-dev) Package operations: 0 installs, 5 updates, 1 removal 0 [>---------------------------] 0 [->--------------------------] - Removing symfony/polyfill-php80 (v1.33.0) - Upgrading squizlabs/php_codesniffer (3.12.2 => 3.13.2): Extracting archive - Upgrading phpcsstandards/phpcsutils (1.0.12 => 1.1.1): Extracting archive - Upgrading phpcsstandards/phpcsextra (1.2.1 => 1.4.0): Extracting archive - Upgrading composer/semver (3.4.3 => 3.4.4): Extracting archive - Upgrading mediawiki/mediawiki-codesniffer (v47.0.0 => v48.0.0): Extracting archive 0/5 [>---------------------------] 0% 4/5 [======================>-----] 80% 5/5 [============================] 100% Generating autoload files 14 packages you are using are looking for funding. Use the `composer fund` command to find out more! No security vulnerability advisories found --- stdout --- PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils --- end --- Previously failing phpcs rules: {'MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage', 'MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected', 'PSR12.Properties.ConstantVisibility.NotFound', 'MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage'} $ vendor/bin/phpcs --report=json --- stdout --- {"totals":{"errors":6,"warnings":4,"fixable":0},"files":{"\/src\/repo\/tests\/WebToolsManager.test.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/WebToolsManager.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/OutputManager.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":10,"column":15}]},"\/src\/repo\/includes\/Hooks.php":{"errors":2,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":9,"column":4},{"message":"There must be at least a blank line between a file-level comment and a class. Make sure you are not mixing file-level comments (like license headers) and class documentation","source":"MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":11,"column":2}]},"\/src\/repo\/includes\/ConfigService.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SpecialWebToolsManager.php":{"errors":2,"warnings":4,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":9,"column":4},{"message":"There must be at least a blank line between a file-level comment and a class. Make sure you are not mixing file-level comments (like license headers) and class documentation","source":"MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":11,"column":2},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":13,"column":5},{"message":"Should use function $this->getConfig()->get() rather than global $wgSitename","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":60,"column":16},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":107,"column":34},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":119,"column":34}]},"\/src\/repo\/includes\/MetadataManager.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":11,"column":15}]}}} --- end --- PHPCS run failed $ vendor/bin/phpcs --report=json --- stdout --- {"totals":{"errors":6,"warnings":4,"fixable":0},"files":{"\/src\/repo\/includes\/OutputManager.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":10,"column":15}]},"\/src\/repo\/includes\/ConfigService.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/WebToolsManager.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/WebToolsManager.test.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/MetadataManager.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":11,"column":15}]},"\/src\/repo\/includes\/Hooks.php":{"errors":2,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":9,"column":4},{"message":"There must be at least a blank line between a file-level comment and a class. Make sure you are not mixing file-level comments (like license headers) and class documentation","source":"MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":11,"column":2}]},"\/src\/repo\/includes\/SpecialWebToolsManager.php":{"errors":2,"warnings":4,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":9,"column":4},{"message":"There must be at least a blank line between a file-level comment and a class. Make sure you are not mixing file-level comments (like license headers) and class documentation","source":"MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":11,"column":2},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":13,"column":5},{"message":"Should use function $this->getConfig()->get() rather than global $wgSitename","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":60,"column":16},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":107,"column":34},{"message":"Should use function $this->msg() rather than function wfMessage()","source":"MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage","severity":5,"fixable":false,"type":"WARNING","line":119,"column":34}]}}} --- end --- * sniff MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation is now failing * sniff MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter is now failing $ git checkout .phpcs.xml --- stderr --- Updated 1 path from the index --- stdout --- --- end --- $ /usr/bin/composer install --- stderr --- Installing dependencies from lock file (including require-dev) Verifying lock file contents can be installed on current platform. Nothing to install, update or remove Generating autoload files 14 packages you are using are looking for funding. Use the `composer fund` command to find out more! --- stdout --- --- end --- $ /usr/bin/composer test --- stderr --- > parallel-lint . --exclude vendor --exclude node_modules > minus-x check . > phpcs -sp --- stdout --- PHP 8.2.28 | 10 parallel jobs ....... 7/7 (100%) Checked 7 files in 0.1 seconds No syntax error found MinusX ====== Processing /src/repo... .......................................................... All good! ....... 7 / 7 (100%) Time: 181ms; Memory: 8MB --- end --- $ /usr/bin/npm audit --json --- stdout --- { "auditReportVersion": 2, "vulnerabilities": {}, "metadata": { "vulnerabilities": { "info": 0, "low": 0, "moderate": 0, "high": 0, "critical": 0, "total": 0 }, "dependencies": { "prod": 1, "dev": 430, "optional": 0, "peer": 1, "peerOptional": 0, "total": 430 } } } --- end --- $ package-lock-lint package-lock.json --- stdout --- Checking package-lock.json --- end --- build: Updating mediawiki/mediawiki-codesniffer to 48.0.0 The following sniffs are failing and were disabled: * MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation * MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter $ git add . --- stdout --- --- end --- $ git commit -F /tmp/tmp1pn20jre --- stdout --- [master 51e9e3d] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0 2 files changed, 3 insertions(+), 1 deletion(-) --- end --- $ git format-patch HEAD~1 --stdout --- stdout --- From 51e9e3dad513ad993a70c7f339b837784ec43199 Mon Sep 17 00:00:00 2001 From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org> Date: Sun, 7 Sep 2025 16:17:38 +0000 Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0 The following sniffs are failing and were disabled: * MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation * MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter Change-Id: I4f36abac1fcf6cb9c2440e55e81c6a21fe21986f --- .phpcs.xml | 2 ++ composer.json | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.phpcs.xml b/.phpcs.xml index 645da8f..08c541b 100644 --- a/.phpcs.xml +++ b/.phpcs.xml @@ -1,6 +1,8 @@ <?xml version="1.0"?> <ruleset> <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki"> + <exclude name="MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation" /> + <exclude name="MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter" /> <exclude name="MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected" /> <exclude name="MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage" /> <exclude name="MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage" /> diff --git a/composer.json b/composer.json index 3b0ce02..aff55f0 100644 --- a/composer.json +++ b/composer.json @@ -1,6 +1,6 @@ { "require-dev": { - "mediawiki/mediawiki-codesniffer": "47.0.0", + "mediawiki/mediawiki-codesniffer": "48.0.0", "mediawiki/minus-x": "1.1.3", "php-parallel-lint/php-console-highlighter": "1.0.0", "php-parallel-lint/php-parallel-lint": "1.4.0" -- 2.39.5 --- end ---