This run took 22 seconds.
From ce50d1330a46a5c6a65bf6b40fa7a4210f5a49df Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Mon, 8 Sep 2025 00:35:39 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation
* MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter
* MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected
Change-Id: I2e65910cb96e084db7d9a79d54792f9a45201b82
---
.phpcs.xml | 3 +++
composer.json | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index 14fbeb7..3a1f6b4 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,6 +1,9 @@
<?xml version="1.0"?>
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude name="MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation" />
+ <exclude name="MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter" />
+ <exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
<exclude name="MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage" />
</rule>
<rule ref="MediaWiki.NamingConventions.ValidGlobalName">
diff --git a/composer.json b/composer.json
index 48be7a7..ad28112 100644
--- a/composer.json
+++ b/composer.json
@@ -20,7 +20,7 @@
"composer/installers": "^2|^1.0.1"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "47.0.0",
+ "mediawiki/mediawiki-codesniffer": "48.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0"
--
2.39.5
$ date
--- stdout ---
Mon Sep 8 00:35:23 UTC 2025
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-ApprovedRevs.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
ffe007022f7cadfaae124b1116bd231461223ce1 refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 449,
"optional": 4,
"peer": 5,
"peerOptional": 0,
"total": 449
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 22 installs, 0 updates, 0 removals
- Locking composer/installers (v2.3.0)
- Locking composer/semver (3.4.3)
- Locking composer/spdx-licenses (1.5.9)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.1.2)
- Locking mediawiki/mediawiki-codesniffer (v47.0.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.12)
- Locking psr/container (2.0.2)
- Locking squizlabs/php_codesniffer (3.12.2)
- Locking symfony/console (v7.3.3)
- Locking symfony/deprecation-contracts (v3.6.0)
- Locking symfony/polyfill-ctype (v1.33.0)
- Locking symfony/polyfill-intl-grapheme (v1.33.0)
- Locking symfony/polyfill-intl-normalizer (v1.33.0)
- Locking symfony/polyfill-mbstring (v1.33.0)
- Locking symfony/polyfill-php80 (v1.33.0)
- Locking symfony/service-contracts (v3.6.0)
- Locking symfony/string (v7.3.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 22 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing composer/installers (v2.3.0): Extracting archive
- Installing squizlabs/php_codesniffer (3.12.2): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.1.2): Extracting archive
- Installing symfony/polyfill-php80 (v1.33.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.12): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.33.0): Extracting archive
- Installing composer/spdx-licenses (1.5.9): Extracting archive
- Installing composer/semver (3.4.3): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v47.0.0): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.33.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.33.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.33.0): Extracting archive
- Installing symfony/string (v7.3.3): Extracting archive
- Installing symfony/deprecation-contracts (v3.6.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.6.0): Extracting archive
- Installing symfony/console (v7.3.3): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/19 [>---------------------------] 0%
19/19 [============================] 100%
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 47.0.0 -> 48.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 5 updates, 1 removal
- Removing symfony/polyfill-php80 (v1.33.0)
- Upgrading composer/semver (3.4.3 => 3.4.4)
- Upgrading mediawiki/mediawiki-codesniffer (v47.0.0 => v48.0.0)
- Upgrading phpcsstandards/phpcsextra (1.2.1 => 1.4.0)
- Upgrading phpcsstandards/phpcsutils (1.0.12 => 1.1.1)
- Upgrading squizlabs/php_codesniffer (3.12.2 => 3.13.2)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 5 updates, 1 removal
0 [>---------------------------] 0 [->--------------------------]
- Removing symfony/polyfill-php80 (v1.33.0)
- Upgrading squizlabs/php_codesniffer (3.12.2 => 3.13.2): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.0.12 => 1.1.1): Extracting archive
- Upgrading phpcsstandards/phpcsextra (1.2.1 => 1.4.0): Extracting archive
- Upgrading composer/semver (3.4.3 => 3.4.4): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v47.0.0 => v48.0.0): Extracting archive
0/5 [>---------------------------] 0%
4/5 [======================>-----] 80%
5/5 [============================] 100%
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: {'MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage'}
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":5,"warnings":3,"fixable":0},"files":{"\/src\/repo\/ApprovedRevs.i18n.magic.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ARApproveAction.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ARUnapproveFileAction.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ARUnapproveAction.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiApprove.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ARApproveFileAction.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ARParserFunctions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/approveAllFiles.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/ApprovedRevs.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/approveAllPages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/SpecialApprovedRevs.php":{"errors":1,"warnings":3,"messages":[{"message":"Should use function $this->getConfig()->get() rather than global $egApprovedRevsEnabledNamespaces","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":57,"column":16},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":159,"column":15},{"message":"Should use function $this->getConfig()->get() rather than global $egApprovedRevsShowApproveLatest","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":234,"column":20},{"message":"Should use function $this->getConfig()->get() rather than global $egApprovedRevsShowApproveLatest","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":283,"column":20}]},"\/src\/repo\/includes\/ApprovedRevs.php":{"errors":2,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":19,"column":4},{"message":"There must be at least a blank line between a file-level comment and a class. Make sure you are not mixing file-level comments (like license headers) and class documentation","source":"MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":23,"column":2}]},"\/src\/repo\/includes\/ApprovedRevsHooks.php":{"errors":2,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":21,"column":4},{"message":"There must be at least a blank line between a file-level comment and a class. Make sure you are not mixing file-level comments (like license headers) and class documentation","source":"MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":26,"column":2}]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":5,"warnings":3,"fixable":0},"files":{"\/src\/repo\/ApprovedRevs.i18n.magic.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/approveAllFiles.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ARApproveFileAction.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ARApproveAction.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ARUnapproveAction.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ARUnapproveFileAction.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ARParserFunctions.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/approveAllPages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/ApprovedRevs.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiApprove.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/SpecialApprovedRevs.php":{"errors":1,"warnings":3,"messages":[{"message":"Should use function $this->getConfig()->get() rather than global $egApprovedRevsEnabledNamespaces","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":57,"column":16},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":159,"column":15},{"message":"Should use function $this->getConfig()->get() rather than global $egApprovedRevsShowApproveLatest","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":234,"column":20},{"message":"Should use function $this->getConfig()->get() rather than global $egApprovedRevsShowApproveLatest","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":283,"column":20}]},"\/src\/repo\/includes\/ApprovedRevs.php":{"errors":2,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":19,"column":4},{"message":"There must be at least a blank line between a file-level comment and a class. Make sure you are not mixing file-level comments (like license headers) and class documentation","source":"MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":23,"column":2}]},"\/src\/repo\/includes\/ApprovedRevsHooks.php":{"errors":2,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":21,"column":4},{"message":"There must be at least a blank line between a file-level comment and a class. Make sure you are not mixing file-level comments (like license headers) and class documentation","source":"MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":26,"column":2}]}}}
--- end ---
* sniff MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected is now failing
* sniff MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter is now failing
* sniff MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation is now failing
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> minus-x check .
> phpcs -sp --cache
--- stdout ---
PHP 8.2.28 | 10 parallel jobs
............. 13/13 (100%)
Checked 13 files in 0.1 seconds
No syntax error found
MinusX
======
Processing /src/repo...
.............................................................
.............................................................
.............................
All good!
............. 13 / 13 (100%)
Time: 151ms; Memory: 8MB
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 449,
"optional": 4,
"peer": 5,
"peerOptional": 0,
"total": 449
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 48.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation
* MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter
* MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmp39guimyb
--- stdout ---
[master ce50d13] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0
2 files changed, 4 insertions(+), 1 deletion(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From ce50d1330a46a5c6a65bf6b40fa7a4210f5a49df Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Mon, 8 Sep 2025 00:35:39 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation
* MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter
* MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected
Change-Id: I2e65910cb96e084db7d9a79d54792f9a45201b82
---
.phpcs.xml | 3 +++
composer.json | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index 14fbeb7..3a1f6b4 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,6 +1,9 @@
<?xml version="1.0"?>
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude name="MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation" />
+ <exclude name="MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter" />
+ <exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
<exclude name="MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage" />
</rule>
<rule ref="MediaWiki.NamingConventions.ValidGlobalName">
diff --git a/composer.json b/composer.json
index 48be7a7..ad28112 100644
--- a/composer.json
+++ b/composer.json
@@ -20,7 +20,7 @@
"composer/installers": "^2|^1.0.1"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "47.0.0",
+ "mediawiki/mediawiki-codesniffer": "48.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0"
--
2.39.5
--- end ---