This run took 16 seconds.
From 60ffd3433f53265fac06c3605edef820a1e4ddf4 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Mon, 8 Sep 2025 04:46:22 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0
Change-Id: I4b5895d9cfd732ac750e44ccbc6804b05383a630
---
composer.json | 2 +-
includes/Group/Base.php | 3 ---
includes/Group/MapGroups.php | 1 -
includes/HookRunner.php | 1 -
includes/PluggableAuthHooks.php | 2 --
includes/PluggableAuthService.php | 1 -
tests/includes/DummyAuth.php | 1 -
tests/phpunit/Group/MapGroupsTest.php | 2 --
tests/phpunit/Group/SyncAllGroupsTest.php | 2 --
tests/phpunit/integration/PluggableAuthServiceTest.php | 1 -
10 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/composer.json b/composer.json
index ff1eeff..5db4348 100644
--- a/composer.json
+++ b/composer.json
@@ -30,7 +30,7 @@
}
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "47.0.0",
+ "mediawiki/mediawiki-codesniffer": "48.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0",
diff --git a/includes/Group/Base.php b/includes/Group/Base.php
index cea8777..0fc489f 100644
--- a/includes/Group/Base.php
+++ b/includes/Group/Base.php
@@ -31,19 +31,16 @@ use Psr\Log\NullLogger;
abstract class Base implements IGroupProcessor, LoggerAwareInterface {
/**
- *
* @var UserIdentity
*/
protected $user = null;
/**
- *
* @var array
*/
protected $attributes = [];
/**
- *
* @var Config
*/
protected $config = null;
diff --git a/includes/Group/MapGroups.php b/includes/Group/MapGroups.php
index 8009207..5b860b4 100644
--- a/includes/Group/MapGroups.php
+++ b/includes/Group/MapGroups.php
@@ -41,7 +41,6 @@ class MapGroups extends GroupProcessorBase {
}
/**
- *
* @var array
*/
protected $groupMap = [];
diff --git a/includes/HookRunner.php b/includes/HookRunner.php
index 35b7c9b..9c1d4ea 100644
--- a/includes/HookRunner.php
+++ b/includes/HookRunner.php
@@ -29,7 +29,6 @@ use MediaWiki\User\UserIdentity;
class HookRunner implements PluggableAuthUserAuthorization {
/**
- *
* @var HookContainer
*/
private $container;
diff --git a/includes/PluggableAuthHooks.php b/includes/PluggableAuthHooks.php
index a359b42..3cbf1eb 100644
--- a/includes/PluggableAuthHooks.php
+++ b/includes/PluggableAuthHooks.php
@@ -259,7 +259,6 @@ class PluggableAuthHooks implements
* Removes password providers if local login is not enabled.
*
* @since 2.0
- *
*/
public static function onRegistration() {
if ( $GLOBALS['wgPluggableAuth_EnableLocalLogin'] ) {
@@ -285,7 +284,6 @@ class PluggableAuthHooks implements
* @return void
*
* @since 7.3.0
- *
*/
public function onLoginFormValidErrorMessages( array &$messages ) {
$messages[] = 'pluggableauth-fatal-error';
diff --git a/includes/PluggableAuthService.php b/includes/PluggableAuthService.php
index 17dc2cc..1c6c7d7 100644
--- a/includes/PluggableAuthService.php
+++ b/includes/PluggableAuthService.php
@@ -138,7 +138,6 @@ class PluggableAuthService {
* Adds PluggableAuth login special pages to allowed list.
* @param Title $title being checked
* @param bool &$whitelisted whether this title is whitelisted
- *
*/
public function allowLoginPage(
Title $title,
diff --git a/tests/includes/DummyAuth.php b/tests/includes/DummyAuth.php
index bea4e03..75f12d8 100644
--- a/tests/includes/DummyAuth.php
+++ b/tests/includes/DummyAuth.php
@@ -76,7 +76,6 @@ class DummyAuth extends PluggableAuth {
* @param string|null &$email
* @param string|null &$errorMessage
* @return bool true if user is authenticated, false otherwise
- *
*/
public function authenticate(
?int &$id,
diff --git a/tests/phpunit/Group/MapGroupsTest.php b/tests/phpunit/Group/MapGroupsTest.php
index 064a0a3..c9eeb95 100644
--- a/tests/phpunit/Group/MapGroupsTest.php
+++ b/tests/phpunit/Group/MapGroupsTest.php
@@ -13,7 +13,6 @@ use TestUserRegistry;
class MapGroupsTest extends MediaWikiIntegrationTestCase {
/**
- *
* @param array $attributes
* @param array $configArray
* @param array $initialGroups
@@ -43,7 +42,6 @@ class MapGroupsTest extends MediaWikiIntegrationTestCase {
}
/**
- *
* @return array
*/
public function provideRunData() {
diff --git a/tests/phpunit/Group/SyncAllGroupsTest.php b/tests/phpunit/Group/SyncAllGroupsTest.php
index cd2cca2..86f99e5 100644
--- a/tests/phpunit/Group/SyncAllGroupsTest.php
+++ b/tests/phpunit/Group/SyncAllGroupsTest.php
@@ -13,7 +13,6 @@ use TestUserRegistry;
class SyncAllGroupsTest extends MediaWikiIntegrationTestCase {
/**
- *
* @param array $attributes
* @param array $configArray
* @param array $initialGroups
@@ -47,7 +46,6 @@ class SyncAllGroupsTest extends MediaWikiIntegrationTestCase {
}
/**
- *
* @return array
*/
public function provideRunData() {
diff --git a/tests/phpunit/integration/PluggableAuthServiceTest.php b/tests/phpunit/integration/PluggableAuthServiceTest.php
index 9db9f20..2b8fd42 100644
--- a/tests/phpunit/integration/PluggableAuthServiceTest.php
+++ b/tests/phpunit/integration/PluggableAuthServiceTest.php
@@ -17,7 +17,6 @@ use Psr\Log\LoggerInterface;
class PluggableAuthServiceTest extends MediaWikiIntegrationTestCase {
/**
- *
* @param array $links
* @param array $expectedLinks
* @param array $options
--
2.39.5
$ date
--- stdout ---
Mon Sep 8 04:46:10 UTC 2025
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-PluggableAuth.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
9d0f062bd9f02adeb924ab85b9540081050be3c3 refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 353,
"optional": 4,
"peer": 5,
"peerOptional": 0,
"total": 353
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 31 installs, 0 updates, 0 removals
- Locking composer/installers (v2.3.0)
- Locking composer/pcre (3.3.2)
- Locking composer/semver (3.4.3)
- Locking composer/spdx-licenses (1.5.9)
- Locking composer/xdebug-handler (3.0.5)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.1.2)
- Locking mediawiki/mediawiki-codesniffer (v47.0.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking pdepend/pdepend (2.16.2)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.12)
- Locking phpmd/phpmd (2.15.0)
- Locking psr/container (2.0.2)
- Locking psr/log (3.0.2)
- Locking squizlabs/php_codesniffer (3.12.2)
- Locking symfony/config (v7.3.2)
- Locking symfony/console (v7.3.3)
- Locking symfony/dependency-injection (v7.3.3)
- Locking symfony/deprecation-contracts (v3.6.0)
- Locking symfony/filesystem (v7.3.2)
- Locking symfony/polyfill-ctype (v1.33.0)
- Locking symfony/polyfill-intl-grapheme (v1.33.0)
- Locking symfony/polyfill-intl-normalizer (v1.33.0)
- Locking symfony/polyfill-mbstring (v1.33.0)
- Locking symfony/polyfill-php80 (v1.33.0)
- Locking symfony/service-contracts (v3.6.0)
- Locking symfony/string (v7.3.3)
- Locking symfony/var-exporter (v7.3.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 31 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing composer/installers (v2.3.0): Extracting archive
- Installing squizlabs/php_codesniffer (3.12.2): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.1.2): Extracting archive
- Installing composer/pcre (3.3.2): Extracting archive
- Installing symfony/polyfill-php80 (v1.33.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.12): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.33.0): Extracting archive
- Installing composer/spdx-licenses (1.5.9): Extracting archive
- Installing composer/semver (3.4.3): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v47.0.0): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.33.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.33.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.33.0): Extracting archive
- Installing symfony/string (v7.3.3): Extracting archive
- Installing symfony/deprecation-contracts (v3.6.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.6.0): Extracting archive
- Installing symfony/console (v7.3.3): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
- Installing symfony/filesystem (v7.3.2): Extracting archive
- Installing symfony/var-exporter (v7.3.3): Extracting archive
- Installing symfony/dependency-injection (v7.3.3): Extracting archive
- Installing symfony/config (v7.3.2): Extracting archive
- Installing pdepend/pdepend (2.16.2): Extracting archive
- Installing psr/log (3.0.2): Extracting archive
- Installing composer/xdebug-handler (3.0.5): Extracting archive
- Installing phpmd/phpmd (2.15.0): Extracting archive
0/28 [>---------------------------] 0%
20/28 [====================>-------] 71%
28/28 [============================] 100%
Generating autoload files
24 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 47.0.0 -> 48.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 5 updates, 1 removal
- Removing symfony/polyfill-php80 (v1.33.0)
- Upgrading composer/semver (3.4.3 => 3.4.4)
- Upgrading mediawiki/mediawiki-codesniffer (v47.0.0 => v48.0.0)
- Upgrading phpcsstandards/phpcsextra (1.2.1 => 1.4.0)
- Upgrading phpcsstandards/phpcsutils (1.0.12 => 1.1.1)
- Upgrading squizlabs/php_codesniffer (3.12.2 => 3.13.2)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 5 updates, 1 removal
0 [>---------------------------] 0 [->--------------------------]
- Removing symfony/polyfill-php80 (v1.33.0)
- Upgrading squizlabs/php_codesniffer (3.12.2 => 3.13.2): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.0.12 => 1.1.1): Extracting archive
- Upgrading phpcsstandards/phpcsextra (1.2.1 => 1.4.0): Extracting archive
- Upgrading composer/semver (3.4.3 => 3.4.4): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v47.0.0 => v48.0.0): Extracting archive
0/5 [>---------------------------] 0%
4/5 [======================>-----] 80%
5/5 [============================] 100%
Generating autoload files
23 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: {'PSR12.Properties.ConstantVisibility.NotFound'}
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":0,"warnings":21,"fixable":14},"files":{"\/src\/repo\/includes\/PluggableAuth.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hook\/PluggableAuthUserAuthorization.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Group\/IGroupProcessor.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/BeginAuthenticationRequest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/CaseInsensitiveHashConfig.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ContinueAuthenticationRequest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PluggableAuthPlugin.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PluggableAuthLogout.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/HookRunner.php":{"errors":0,"warnings":1,"messages":[{"message":"Doc comments must not start with multiple empty lines","source":"MediaWiki.Commenting.PropertyDocumentation.EmptyLinesStart","severity":5,"fixable":true,"type":"WARNING","line":31,"column":5}]},"\/src\/repo\/includes\/Group\/GroupProcessorBase.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Group\/GroupProcessorFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Group\/GroupProcessorRunner.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/BackchannelLogoutAwarePlugin.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Group\/Base.php":{"errors":0,"warnings":3,"messages":[{"message":"Doc comments must not start with multiple empty lines","source":"MediaWiki.Commenting.PropertyDocumentation.EmptyLinesStart","severity":5,"fixable":true,"type":"WARNING","line":33,"column":5},{"message":"Doc comments must not start with multiple empty lines","source":"MediaWiki.Commenting.PropertyDocumentation.EmptyLinesStart","severity":5,"fixable":true,"type":"WARNING","line":39,"column":5},{"message":"Doc comments must not start with multiple empty lines","source":"MediaWiki.Commenting.PropertyDocumentation.EmptyLinesStart","severity":5,"fixable":true,"type":"WARNING","line":45,"column":5}]},"\/src\/repo\/includes\/PluggableAuth.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PluggableAuthFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Group\/MapGroups.php":{"errors":0,"warnings":1,"messages":[{"message":"Doc comments must not start with multiple empty lines","source":"MediaWiki.Commenting.PropertyDocumentation.EmptyLinesStart","severity":5,"fixable":true,"type":"WARNING","line":43,"column":5}]},"\/src\/repo\/includes\/Rest\/LogoutHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Group\/MapGroupsTest.php":{"errors":0,"warnings":2,"messages":[{"message":"Doc comments must not start with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesStart","severity":5,"fixable":true,"type":"WARNING","line":15,"column":5},{"message":"Doc comments must not start with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesStart","severity":5,"fixable":true,"type":"WARNING","line":45,"column":5}]},"\/src\/repo\/tests\/includes\/DummyAuth.php":{"errors":0,"warnings":1,"messages":[{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":80,"column":6}]},"\/src\/repo\/includes\/PluggableAuthLogin.php":{"errors":0,"warnings":7,"messages":[{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":37,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":38,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":39,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":40,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":41,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":42,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":43,"column":5}]},"\/src\/repo\/tests\/phpunit\/integration\/PluggableAuthServiceTest.php":{"errors":0,"warnings":1,"messages":[{"message":"Doc comments must not start with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesStart","severity":5,"fixable":true,"type":"WARNING","line":19,"column":5}]},"\/src\/repo\/includes\/Group\/SyncAllGroups.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Group\/SyncAllGroupsTest.php":{"errors":0,"warnings":2,"messages":[{"message":"Doc comments must not start with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesStart","severity":5,"fixable":true,"type":"WARNING","line":15,"column":5},{"message":"Doc comments must not start with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesStart","severity":5,"fixable":true,"type":"WARNING","line":49,"column":5}]},"\/src\/repo\/includes\/PrimaryAuthenticationProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PluggableAuthHooks.php":{"errors":0,"warnings":2,"messages":[{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":263,"column":6},{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":289,"column":6}]},"\/src\/repo\/includes\/PluggableAuthService.php":{"errors":0,"warnings":1,"messages":[{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":142,"column":6}]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcbf
--- stdout ---
PHPCBF RESULT SUMMARY
--------------------------------------------------------------------------------
FILE FIXED REMAINING
--------------------------------------------------------------------------------
/src/repo/includes/HookRunner.php 1 0
/src/repo/includes/Group/Base.php 3 0
...repo/tests/phpunit/integration/PluggableAuthServiceTest.php 1 0
/src/repo/tests/includes/DummyAuth.php 1 0
/src/repo/includes/Group/MapGroups.php 1 0
/src/repo/tests/phpunit/Group/SyncAllGroupsTest.php 2 0
/src/repo/includes/PluggableAuthHooks.php 2 0
/src/repo/tests/phpunit/Group/MapGroupsTest.php 2 0
/src/repo/includes/PluggableAuthService.php 1 0
--------------------------------------------------------------------------------
A TOTAL OF 14 ERRORS WERE FIXED IN 9 FILES
--------------------------------------------------------------------------------
Time: 628ms; Memory: 8MB
--- end ---
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":0,"warnings":7,"fixable":0},"files":{"\/src\/repo\/includes\/PluggableAuth.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Group\/IGroupProcessor.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ContinueAuthenticationRequest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PluggableAuthPlugin.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hook\/PluggableAuthUserAuthorization.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/HookRunner.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Group\/GroupProcessorBase.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PluggableAuthLogout.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PluggableAuth.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/BeginAuthenticationRequest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/CaseInsensitiveHashConfig.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/BackchannelLogoutAwarePlugin.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Group\/Base.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PluggableAuthFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Group\/GroupProcessorFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Group\/MapGroups.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Rest\/LogoutHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Group\/GroupProcessorRunner.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/includes\/DummyAuth.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Group\/MapGroupsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Group\/SyncAllGroups.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PrimaryAuthenticationProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PluggableAuthService.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Group\/SyncAllGroupsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PluggableAuthLogin.php":{"errors":0,"warnings":7,"messages":[{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":37,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":38,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":39,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":40,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":41,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":42,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":43,"column":5}]},"\/src\/repo\/tests\/phpunit\/integration\/PluggableAuthServiceTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PluggableAuthHooks.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
23 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> minus-x check .
> phpmd includes text .phpmd.xml || :
> phpcs -sp --cache
--- stdout ---
PHP 8.2.28 | 10 parallel jobs
............................ 28/28 (100%)
Checked 28 files in 0.2 seconds
No syntax error found
MinusX
======
Processing /src/repo...
.............................................................
.................................
All good!
/src/repo/includes/PluggableAuthHooks.php:252 CamelCaseMethodName The method onSpecialPage_initList is not named in camelCase.
............................ 28 / 28 (100%)
Time: 211ms; Memory: 8MB
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 353,
"optional": 4,
"peer": 5,
"peerOptional": 0,
"total": 353
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 48.0.0
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpjft8v1jf
--- stdout ---
[master 60ffd34] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0
10 files changed, 1 insertion(+), 15 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 60ffd3433f53265fac06c3605edef820a1e4ddf4 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Mon, 8 Sep 2025 04:46:22 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0
Change-Id: I4b5895d9cfd732ac750e44ccbc6804b05383a630
---
composer.json | 2 +-
includes/Group/Base.php | 3 ---
includes/Group/MapGroups.php | 1 -
includes/HookRunner.php | 1 -
includes/PluggableAuthHooks.php | 2 --
includes/PluggableAuthService.php | 1 -
tests/includes/DummyAuth.php | 1 -
tests/phpunit/Group/MapGroupsTest.php | 2 --
tests/phpunit/Group/SyncAllGroupsTest.php | 2 --
tests/phpunit/integration/PluggableAuthServiceTest.php | 1 -
10 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/composer.json b/composer.json
index ff1eeff..5db4348 100644
--- a/composer.json
+++ b/composer.json
@@ -30,7 +30,7 @@
}
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "47.0.0",
+ "mediawiki/mediawiki-codesniffer": "48.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0",
diff --git a/includes/Group/Base.php b/includes/Group/Base.php
index cea8777..0fc489f 100644
--- a/includes/Group/Base.php
+++ b/includes/Group/Base.php
@@ -31,19 +31,16 @@ use Psr\Log\NullLogger;
abstract class Base implements IGroupProcessor, LoggerAwareInterface {
/**
- *
* @var UserIdentity
*/
protected $user = null;
/**
- *
* @var array
*/
protected $attributes = [];
/**
- *
* @var Config
*/
protected $config = null;
diff --git a/includes/Group/MapGroups.php b/includes/Group/MapGroups.php
index 8009207..5b860b4 100644
--- a/includes/Group/MapGroups.php
+++ b/includes/Group/MapGroups.php
@@ -41,7 +41,6 @@ class MapGroups extends GroupProcessorBase {
}
/**
- *
* @var array
*/
protected $groupMap = [];
diff --git a/includes/HookRunner.php b/includes/HookRunner.php
index 35b7c9b..9c1d4ea 100644
--- a/includes/HookRunner.php
+++ b/includes/HookRunner.php
@@ -29,7 +29,6 @@ use MediaWiki\User\UserIdentity;
class HookRunner implements PluggableAuthUserAuthorization {
/**
- *
* @var HookContainer
*/
private $container;
diff --git a/includes/PluggableAuthHooks.php b/includes/PluggableAuthHooks.php
index a359b42..3cbf1eb 100644
--- a/includes/PluggableAuthHooks.php
+++ b/includes/PluggableAuthHooks.php
@@ -259,7 +259,6 @@ class PluggableAuthHooks implements
* Removes password providers if local login is not enabled.
*
* @since 2.0
- *
*/
public static function onRegistration() {
if ( $GLOBALS['wgPluggableAuth_EnableLocalLogin'] ) {
@@ -285,7 +284,6 @@ class PluggableAuthHooks implements
* @return void
*
* @since 7.3.0
- *
*/
public function onLoginFormValidErrorMessages( array &$messages ) {
$messages[] = 'pluggableauth-fatal-error';
diff --git a/includes/PluggableAuthService.php b/includes/PluggableAuthService.php
index 17dc2cc..1c6c7d7 100644
--- a/includes/PluggableAuthService.php
+++ b/includes/PluggableAuthService.php
@@ -138,7 +138,6 @@ class PluggableAuthService {
* Adds PluggableAuth login special pages to allowed list.
* @param Title $title being checked
* @param bool &$whitelisted whether this title is whitelisted
- *
*/
public function allowLoginPage(
Title $title,
diff --git a/tests/includes/DummyAuth.php b/tests/includes/DummyAuth.php
index bea4e03..75f12d8 100644
--- a/tests/includes/DummyAuth.php
+++ b/tests/includes/DummyAuth.php
@@ -76,7 +76,6 @@ class DummyAuth extends PluggableAuth {
* @param string|null &$email
* @param string|null &$errorMessage
* @return bool true if user is authenticated, false otherwise
- *
*/
public function authenticate(
?int &$id,
diff --git a/tests/phpunit/Group/MapGroupsTest.php b/tests/phpunit/Group/MapGroupsTest.php
index 064a0a3..c9eeb95 100644
--- a/tests/phpunit/Group/MapGroupsTest.php
+++ b/tests/phpunit/Group/MapGroupsTest.php
@@ -13,7 +13,6 @@ use TestUserRegistry;
class MapGroupsTest extends MediaWikiIntegrationTestCase {
/**
- *
* @param array $attributes
* @param array $configArray
* @param array $initialGroups
@@ -43,7 +42,6 @@ class MapGroupsTest extends MediaWikiIntegrationTestCase {
}
/**
- *
* @return array
*/
public function provideRunData() {
diff --git a/tests/phpunit/Group/SyncAllGroupsTest.php b/tests/phpunit/Group/SyncAllGroupsTest.php
index cd2cca2..86f99e5 100644
--- a/tests/phpunit/Group/SyncAllGroupsTest.php
+++ b/tests/phpunit/Group/SyncAllGroupsTest.php
@@ -13,7 +13,6 @@ use TestUserRegistry;
class SyncAllGroupsTest extends MediaWikiIntegrationTestCase {
/**
- *
* @param array $attributes
* @param array $configArray
* @param array $initialGroups
@@ -47,7 +46,6 @@ class SyncAllGroupsTest extends MediaWikiIntegrationTestCase {
}
/**
- *
* @return array
*/
public function provideRunData() {
diff --git a/tests/phpunit/integration/PluggableAuthServiceTest.php b/tests/phpunit/integration/PluggableAuthServiceTest.php
index 9db9f20..2b8fd42 100644
--- a/tests/phpunit/integration/PluggableAuthServiceTest.php
+++ b/tests/phpunit/integration/PluggableAuthServiceTest.php
@@ -17,7 +17,6 @@ use Psr\Log\LoggerInterface;
class PluggableAuthServiceTest extends MediaWikiIntegrationTestCase {
/**
- *
* @param array $links
* @param array $expectedLinks
* @param array $options
--
2.39.5
--- end ---