This run took 29 seconds.
From 3ceaafa34f0dfe930db21ef83f288d9f641a1699 Mon Sep 17 00:00:00 2001 From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org> Date: Mon, 8 Sep 2025 05:40:09 +0000 Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0 The following sniffs are failing and were disabled: * MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation * MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter * MediaWiki.Commenting.CommentBeforeClass.StrayStyle Change-Id: I4232efe1c1c1557a9b5c85701643761445835c35 --- .phpcs.xml | 3 +++ composer.json | 2 +- includes/Ballots/STVBallot.php | 1 - includes/SecurePollLogPager.php | 2 +- includes/Talliers/CommentDumper.php | 1 - includes/Talliers/HistogramRangeTallier.php | 5 ----- includes/Talliers/PairwiseTallier.php | 1 - includes/Talliers/PluralityTallier.php | 3 --- includes/Talliers/STVFormatter/HtmlFormatter.php | 1 - includes/Talliers/SchulzeTallier.php | 5 ----- includes/TranslationRepo.php | 1 - tests/phpunit/integration/TranslationRepoTest.php | 1 - 12 files changed, 5 insertions(+), 21 deletions(-) diff --git a/.phpcs.xml b/.phpcs.xml index 6d42d20..7b1c7f5 100644 --- a/.phpcs.xml +++ b/.phpcs.xml @@ -2,6 +2,9 @@ <ruleset> <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki"> <exclude name="Generic.Files.LineLength.TooLong" /> + <exclude name="MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation" /> + <exclude name="MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter" /> + <exclude name="MediaWiki.Commenting.CommentBeforeClass.StrayStyle" /> </rule> <rule ref="MediaWiki.Files.ClassMatchesFilename.NotMatch"> <exclude-pattern>*/cli/*.php</exclude-pattern> diff --git a/composer.json b/composer.json index 7c9ad41..b0db4d2 100644 --- a/composer.json +++ b/composer.json @@ -1,7 +1,7 @@ { "require-dev": { "ext-bcmath": "*", - "mediawiki/mediawiki-codesniffer": "47.0.0", + "mediawiki/mediawiki-codesniffer": "48.0.0", "mediawiki/mediawiki-phan-config": "0.17.0", "mediawiki/minus-x": "1.1.3", "php-parallel-lint/php-console-highlighter": "1.0.0", diff --git a/includes/Ballots/STVBallot.php b/includes/Ballots/STVBallot.php index a22d7f1..a8bc082 100644 --- a/includes/Ballots/STVBallot.php +++ b/includes/Ballots/STVBallot.php @@ -324,7 +324,6 @@ class STVBallot extends Ballot { } /** - * * @param int $count * @return bool */ diff --git a/includes/SecurePollLogPager.php b/includes/SecurePollLogPager.php index 1c6fe48..25dffc2 100644 --- a/includes/SecurePollLogPager.php +++ b/includes/SecurePollLogPager.php @@ -20,7 +20,7 @@ class SecurePollLogPager extends ReverseChronologicalPager { int $year, int $month, int $day, - /** @var int[] $actions */ + /** @var int[] */ private readonly array $actions, ) { parent::__construct(); diff --git a/includes/Talliers/CommentDumper.php b/includes/Talliers/CommentDumper.php index 4f18a87..d3d77a0 100644 --- a/includes/Talliers/CommentDumper.php +++ b/includes/Talliers/CommentDumper.php @@ -101,7 +101,6 @@ class CommentDumper extends ElectionTallier { /** * @inheritDoc - * */ public function getTextResult() { return stream_get_contents( $this->csvHandle, -1, 0 ); diff --git a/includes/Talliers/HistogramRangeTallier.php b/includes/Talliers/HistogramRangeTallier.php index f738c5d..c3edb05 100644 --- a/includes/Talliers/HistogramRangeTallier.php +++ b/includes/Talliers/HistogramRangeTallier.php @@ -42,7 +42,6 @@ class HistogramRangeTallier extends Tallier { /** * @inheritDoc - * */ public function addVote( $scores ) { foreach ( $scores as $oid => $score ) { @@ -56,7 +55,6 @@ class HistogramRangeTallier extends Tallier { /** * @inheritDoc - * */ public function finishTally() { $this->averages = []; @@ -72,7 +70,6 @@ class HistogramRangeTallier extends Tallier { /** * @inheritDoc - * */ public function loadJSONResult( $data ) { $this->averages = $data['averages']; @@ -81,7 +78,6 @@ class HistogramRangeTallier extends Tallier { /** * @inheritDoc - * */ public function getJSONResult() { return [ @@ -138,7 +134,6 @@ class HistogramRangeTallier extends Tallier { /** * @inheritDoc - * */ public function getTextResult() { return $this->getHtmlResult(); diff --git a/includes/Talliers/PairwiseTallier.php b/includes/Talliers/PairwiseTallier.php index 5161649..2fc35bc 100644 --- a/includes/Talliers/PairwiseTallier.php +++ b/includes/Talliers/PairwiseTallier.php @@ -36,7 +36,6 @@ abstract class PairwiseTallier extends Tallier { /** * @inheritDoc - * */ public function addVote( $ranks ) { foreach ( $this->optionIds as $oid1 ) { diff --git a/includes/Talliers/PluralityTallier.php b/includes/Talliers/PluralityTallier.php index b4da88a..ad1c957 100644 --- a/includes/Talliers/PluralityTallier.php +++ b/includes/Talliers/PluralityTallier.php @@ -42,7 +42,6 @@ class PluralityTallier extends Tallier { /** * @inheritDoc - * */ public function finishTally() { // Sort the scores @@ -51,7 +50,6 @@ class PluralityTallier extends Tallier { /** * @inheritDoc - * */ public function loadJSONResult( $data ) { $this->tally = $data; @@ -64,7 +62,6 @@ class PluralityTallier extends Tallier { /** * @inheritDoc - * */ public function getHtmlResult() { // Show the results diff --git a/includes/Talliers/STVFormatter/HtmlFormatter.php b/includes/Talliers/STVFormatter/HtmlFormatter.php index d9b27b0..9c07140 100644 --- a/includes/Talliers/STVFormatter/HtmlFormatter.php +++ b/includes/Talliers/STVFormatter/HtmlFormatter.php @@ -51,7 +51,6 @@ class HtmlFormatter implements STVFormatter { protected $modifiers = []; /** - * * @param array $resultLogs * @param array $rankedVotes * @param int $seats diff --git a/includes/Talliers/SchulzeTallier.php b/includes/Talliers/SchulzeTallier.php index 976b735..f69e65b 100644 --- a/includes/Talliers/SchulzeTallier.php +++ b/includes/Talliers/SchulzeTallier.php @@ -138,7 +138,6 @@ class SchulzeTallier extends PairwiseTallier { /** * @inheritDoc - * */ public function finishTally() { $this->strengths = $this->getPathStrengths( $this->victories ); @@ -154,7 +153,6 @@ class SchulzeTallier extends PairwiseTallier { /** * @inheritDoc - * */ public function loadJSONResult( $data ) { $this->ranks = $data['ranks']; @@ -164,7 +162,6 @@ class SchulzeTallier extends PairwiseTallier { /** * @inheritDoc - * */ public function getJSONResult() { return [ @@ -176,7 +173,6 @@ class SchulzeTallier extends PairwiseTallier { /** * @inheritDoc - * */ public function getHtmlResult() { $s = '<h2>' . wfMessage( 'securepoll-ranks' )->parse() . "</h2>\n"; @@ -194,7 +190,6 @@ class SchulzeTallier extends PairwiseTallier { /** * @inheritDoc - * */ public function getTextResult() { $rankedIds = array_keys( $this->ranks ); diff --git a/includes/TranslationRepo.php b/includes/TranslationRepo.php index 5c287ea..1500c88 100644 --- a/includes/TranslationRepo.php +++ b/includes/TranslationRepo.php @@ -22,7 +22,6 @@ class TranslationRepo { } /** - * * @param Election $election * @param array $data * @param string $language diff --git a/tests/phpunit/integration/TranslationRepoTest.php b/tests/phpunit/integration/TranslationRepoTest.php index 5515510..a78e832 100644 --- a/tests/phpunit/integration/TranslationRepoTest.php +++ b/tests/phpunit/integration/TranslationRepoTest.php @@ -18,7 +18,6 @@ use Wikimedia\Rdbms\SelectQueryBuilder; class TranslationRepoTest extends MediaWikiIntegrationTestCase { /** - * * @param array $data * @param string $language * @param string $comment -- 2.39.5
$ date --- stdout --- Mon Sep 8 05:39:49 UTC 2025 --- end --- $ git clone file:///srv/git/mediawiki-extensions-SecurePoll.git repo --depth=1 -b master --- stderr --- Cloning into 'repo'... --- stdout --- --- end --- $ git config user.name libraryupgrader --- stdout --- --- end --- $ git config user.email tools.libraryupgrader@tools.wmflabs.org --- stdout --- --- end --- $ git submodule update --init --- stdout --- --- end --- $ grr init --- stdout --- Installed commit-msg hook. --- end --- $ git show-ref refs/heads/master --- stdout --- 20a927fdd3145badba19fc98f4799071762ca962 refs/heads/master --- end --- $ /usr/bin/npm audit --json --- stdout --- { "auditReportVersion": 2, "vulnerabilities": {}, "metadata": { "vulnerabilities": { "info": 0, "low": 0, "moderate": 0, "high": 0, "critical": 0, "total": 0 }, "dependencies": { "prod": 1, "dev": 455, "optional": 4, "peer": 5, "peerOptional": 0, "total": 455 } } } --- end --- $ /usr/bin/composer install --- stderr --- No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information. Loading composer repositories with package information Updating dependencies Lock file operations: 38 installs, 0 updates, 0 removals - Locking composer/pcre (3.3.2) - Locking composer/semver (3.4.3) - Locking composer/spdx-licenses (1.5.9) - Locking composer/xdebug-handler (3.0.5) - Locking dealerdirect/phpcodesniffer-composer-installer (v1.1.2) - Locking doctrine/deprecations (1.1.5) - Locking felixfbecker/advanced-json-rpc (v3.2.1) - Locking mediawiki/mediawiki-codesniffer (v47.0.0) - Locking mediawiki/mediawiki-phan-config (0.17.0) - Locking mediawiki/minus-x (1.1.3) - Locking mediawiki/phan-taint-check-plugin (7.0.0) - Locking microsoft/tolerant-php-parser (v0.1.2) - Locking netresearch/jsonmapper (v4.5.0) - Locking phan/phan (5.5.1) - Locking php-parallel-lint/php-console-color (v1.0.1) - Locking php-parallel-lint/php-console-highlighter (v1.0.0) - Locking php-parallel-lint/php-parallel-lint (v1.4.0) - Locking phpcsstandards/phpcsextra (1.2.1) - Locking phpcsstandards/phpcsutils (1.0.12) - Locking phpdocumentor/reflection-common (2.2.0) - Locking phpdocumentor/reflection-docblock (5.6.3) - Locking phpdocumentor/type-resolver (1.10.0) - Locking phpstan/phpdoc-parser (2.3.0) - Locking psr/container (2.0.2) - Locking psr/log (3.0.2) - Locking sabre/event (5.1.7) - Locking squizlabs/php_codesniffer (3.12.2) - Locking symfony/console (v7.3.3) - Locking symfony/deprecation-contracts (v3.6.0) - Locking symfony/polyfill-ctype (v1.33.0) - Locking symfony/polyfill-intl-grapheme (v1.33.0) - Locking symfony/polyfill-intl-normalizer (v1.33.0) - Locking symfony/polyfill-mbstring (v1.33.0) - Locking symfony/polyfill-php80 (v1.33.0) - Locking symfony/service-contracts (v3.6.0) - Locking symfony/string (v7.3.3) - Locking tysonandre/var_representation_polyfill (0.1.3) - Locking webmozart/assert (1.11.0) Writing lock file Installing dependencies from lock file (including require-dev) Package operations: 38 installs, 0 updates, 0 removals 0 [>---------------------------] 0 [->--------------------------] - Installing squizlabs/php_codesniffer (3.12.2): Extracting archive - Installing dealerdirect/phpcodesniffer-composer-installer (v1.1.2): Extracting archive - Installing composer/pcre (3.3.2): Extracting archive - Installing symfony/polyfill-php80 (v1.33.0): Extracting archive - Installing phpcsstandards/phpcsutils (1.0.12): Extracting archive - Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive - Installing symfony/polyfill-mbstring (v1.33.0): Extracting archive - Installing composer/spdx-licenses (1.5.9): Extracting archive - Installing composer/semver (3.4.3): Extracting archive - Installing mediawiki/mediawiki-codesniffer (v47.0.0): Extracting archive - Installing tysonandre/var_representation_polyfill (0.1.3): Extracting archive - Installing symfony/polyfill-intl-normalizer (v1.33.0): Extracting archive - Installing symfony/polyfill-intl-grapheme (v1.33.0): Extracting archive - Installing symfony/polyfill-ctype (v1.33.0): Extracting archive - Installing symfony/string (v7.3.3): Extracting archive - Installing symfony/deprecation-contracts (v3.6.0): Extracting archive - Installing psr/container (2.0.2): Extracting archive - Installing symfony/service-contracts (v3.6.0): Extracting archive - Installing symfony/console (v7.3.3): Extracting archive - Installing sabre/event (5.1.7): Extracting archive - Installing netresearch/jsonmapper (v4.5.0): Extracting archive - Installing microsoft/tolerant-php-parser (v0.1.2): Extracting archive - Installing webmozart/assert (1.11.0): Extracting archive - Installing phpstan/phpdoc-parser (2.3.0): Extracting archive - Installing phpdocumentor/reflection-common (2.2.0): Extracting archive - Installing doctrine/deprecations (1.1.5): Extracting archive - Installing phpdocumentor/type-resolver (1.10.0): Extracting archive - Installing phpdocumentor/reflection-docblock (5.6.3): Extracting archive - Installing felixfbecker/advanced-json-rpc (v3.2.1): Extracting archive - Installing psr/log (3.0.2): Extracting archive - Installing composer/xdebug-handler (3.0.5): Extracting archive - Installing phan/phan (5.5.1): Extracting archive - Installing mediawiki/phan-taint-check-plugin (7.0.0): Extracting archive - Installing mediawiki/mediawiki-phan-config (0.17.0): Extracting archive - Installing mediawiki/minus-x (1.1.3): Extracting archive - Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive - Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive - Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive 0/36 [>---------------------------] 0% 20/36 [===============>------------] 55% 35/36 [===========================>] 97% 36/36 [============================] 100% 1 package suggestions were added by new dependencies, use `composer suggest` to see details. Generating autoload files 17 packages you are using are looking for funding. Use the `composer fund` command to find out more! --- stdout --- PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils --- end --- Upgrading c:mediawiki/mediawiki-codesniffer from 47.0.0 -> 48.0.0 $ /usr/bin/composer update --- stderr --- Loading composer repositories with package information Updating dependencies Lock file operations: 0 installs, 5 updates, 0 removals - Upgrading composer/semver (3.4.3 => 3.4.4) - Upgrading mediawiki/mediawiki-codesniffer (v47.0.0 => v48.0.0) - Upgrading phpcsstandards/phpcsextra (1.2.1 => 1.4.0) - Upgrading phpcsstandards/phpcsutils (1.0.12 => 1.1.1) - Upgrading squizlabs/php_codesniffer (3.12.2 => 3.13.2) Writing lock file Installing dependencies from lock file (including require-dev) Package operations: 0 installs, 5 updates, 0 removals 0 [>---------------------------] 0 [->--------------------------] - Upgrading squizlabs/php_codesniffer (3.12.2 => 3.13.2): Extracting archive - Upgrading phpcsstandards/phpcsutils (1.0.12 => 1.1.1): Extracting archive - Upgrading phpcsstandards/phpcsextra (1.2.1 => 1.4.0): Extracting archive - Upgrading composer/semver (3.4.3 => 3.4.4): Extracting archive - Upgrading mediawiki/mediawiki-codesniffer (v47.0.0 => v48.0.0): Extracting archive 0/5 [>---------------------------] 0% 4/5 [======================>-----] 80% 5/5 [============================] 100% Generating autoload files 17 packages you are using are looking for funding. Use the `composer fund` command to find out more! No security vulnerability advisories found --- stdout --- PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils --- end --- Previously failing phpcs rules: {'Generic.Files.LineLength.TooLong'} $ vendor/bin/phpcs --report=json --- stdout --- {"totals":{"errors":6,"warnings":21,"fixable":20},"files":{"\/src\/repo\/SecurePoll.constants.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Entities\/Option.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/SecurePoll_GetUserParamsHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/wm-scripts\/includes\/MailingListEntry.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/HookRunner.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Entities\/Question.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/SecurePoll_JumpUrlHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/ArchivedPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/MigrateTallies.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/LoginPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/TallyPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/PurgeDecryptionKeys.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/wm-scripts\/importGlobalVoterList.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Ballots\/RadioRangeCommentBallot.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/wm-scripts\/ucocar2025\/ucocAR2025PopulateEditCount.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Ballots\/ChooseBallot.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/PurgePrivateVoteData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Jobs\/UnarchiveElectionJob.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Jobs\/LogAdminActionJob.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/MakeSimpleList.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/HookHandler\/SetupHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/HookHandler\/LogoutHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/DumpVoteCsv.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/StrikePager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Api\/ApiSecurePollAuth.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/ArchivePage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SpecialSecurePoll.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/UpdateNotBlockedKey.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/ActionPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Jobs\/DeleteTallyJob.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/DeleteTallyPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ActionPageFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Exceptions\/InvalidDataException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/UnarchivePage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/wm-scripts\/deduplicateMailingList.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Ballots\/BallotStatus.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/EntryPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Ballots\/PreferentialBallot.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Rest\/SetTranslationHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/FindUsersWithRight.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/HookRunnerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/TallyElection.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/HookHandler\/InstallHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/ImportElectionConfiguration.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/ConvertVotes.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/DumpElection.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/maintenance\/DropUnusedTablesTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/DropUnusedTables.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/maintenance\/MigrateTalliesTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Store\/DBStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/wm-scripts\/makeGlobalVoterList.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/SetTranslationHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Api\/ApiStrikeVote.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/DumpElectionScript.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/PluralityTallierTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/SecurePollLogPagerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/TranslationRepo.php":{"errors":0,"warnings":1,"messages":[{"message":"Doc comments must not start with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesStart","severity":5,"fixable":true,"type":"WARNING","line":24,"column":5}]},"\/src\/repo\/maintenance\/wm-scripts\/u4c2025\/u4C2025PopulateEditCount.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Jobs\/TallyElectionJob.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/VoteRecordTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/OpenSSLAsymmetricKey.php":{"errors":1,"warnings":0,"messages":[{"message":"You must use \"\/**\" style comments for a class comment, or add an empty line after stray comments","source":"MediaWiki.Commenting.CommentBeforeClass.StrayStyle","severity":5,"fixable":false,"type":"ERROR","line":3,"column":1}]},"\/src\/repo\/includes\/Store\/Store.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/SchulzeTallierTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/User\/LocalAuth.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/DeletePoll.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/ElectionPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Talliers\/Tallier.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/HistogramRangeTallierTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/maintenance\/ConvertVotesTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/SecurePoll.namespaces.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/ListPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/wm-scripts\/makeMailingList.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Entities\/Entity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/DumpTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Talliers\/PairwiseTallier.php":{"errors":0,"warnings":1,"messages":[{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":40,"column":6}]},"\/src\/repo\/includes\/VoteRecord.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/maintenance\/ImportElectionConfigurationTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/DumpComments.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/WikitextFormatterTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/TranslatePage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/MainElectionsPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SpecialSecurePollLog.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ChooseBallotTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Crypt\/Random.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/HtmlFormatterTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Pages\/ArchivePageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/PairwiseTallierTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/wm-scripts\/PopulateEditCount.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/BallotTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/User\/Voter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/TallierTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Talliers\/STVFormatter\/WikitextFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/RadioRangeBallotTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/DetailsPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/HtmlForm\/HTMLFormRadioRangeColumnLabels.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ActionPageFactoryTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/TranslationRepoTest.php":{"errors":0,"warnings":1,"messages":[{"message":"Doc comments must not start with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesStart","severity":5,"fixable":true,"type":"WARNING","line":20,"column":5}]},"\/src\/repo\/includes\/Pages\/ArchivedPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/User\/Auth.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/SpecialSecurePollLogTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Crypt\/Crypt.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/GenerateTestElection.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/SecurePollContentHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/SecurePollServiceWiringTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Pages\/EntryPageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/DeleteTallyJobTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/STVTallierTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/TallyListPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Ballots\/Ballot.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Pages\/CreatePageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Jobs\/PopulateVoterListJob.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/User\/RemoteMWAuth.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ApprovalBallotTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Ballots\/STVBallot.php":{"errors":0,"warnings":1,"messages":[{"message":"Doc comments must not start with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesStart","severity":5,"fixable":true,"type":"WARNING","line":326,"column":5}]},"\/src\/repo\/includes\/Pages\/MessageDumpPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Pages\/DetailsPageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Jobs\/ArchiveElectionJob.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/OpenSslCryptTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/wm-scripts\/sendMail.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Store\/XMLStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/SetTranslationHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/wm-scripts\/bv2025\/bv2025PopulateEditCount.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Ballots\/RadioRangeBallot.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Context.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Talliers\/HistogramRangeTallier.php":{"errors":0,"warnings":5,"messages":[{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":46,"column":6},{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":60,"column":6},{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":76,"column":6},{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":85,"column":6},{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":142,"column":6}]},"\/src\/repo\/includes\/SecurePollContentHandler.php":{"errors":2,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":16,"column":4},{"message":"There must be at least a blank line between a file-level comment and a class. Make sure you are not mixing file-level comments (like license headers) and class documentation","source":"MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":21,"column":2}]},"\/src\/repo\/tests\/phpunit\/integration\/VoteSummaryTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Pages\/UnarchivePageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Entities\/Election.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/DumpPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Talliers\/ElectionTallier.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Talliers\/STVTallier.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Ballots\/ApprovalBallot.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/SecurePoll.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SecurePollLogPager.php":{"errors":1,"warnings":0,"messages":[{"message":"Found redundant variable name $actions in @var","source":"MediaWiki.Commenting.RedundantVarName.Found","severity":5,"fixable":true,"type":"ERROR","line":23,"column":18}]},"\/src\/repo\/includes\/Talliers\/CommentDumper.php":{"errors":0,"warnings":1,"messages":[{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":105,"column":6}]},"\/src\/repo\/includes\/Talliers\/STVFormatter\/HtmlFormatter.php":{"errors":0,"warnings":1,"messages":[{"message":"Doc comments must not start with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesStart","severity":5,"fixable":true,"type":"WARNING","line":53,"column":5}]},"\/src\/repo\/includes\/Talliers\/SchulzeTallier.php":{"errors":0,"warnings":6,"messages":[{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":142,"column":6},{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":158,"column":6},{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":168,"column":6},{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":180,"column":6},{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":198,"column":6},{"message":"Line exceeds 120 characters; contains 143 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":204,"column":143}]},"\/src\/repo\/includes\/SecurePollContent.php":{"errors":2,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":10,"column":4},{"message":"There must be at least a blank line between a file-level comment and a class. Make sure you are not mixing file-level comments (like license headers) and class documentation","source":"MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":15,"column":2}]},"\/src\/repo\/includes\/Crypt\/OpenSslCrypt.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Pages\/VoterEligibilityPageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Talliers\/STVFormatter\/STVFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/cli\/purgePrivateVoteData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/maintenance\/UpdateNotBlockedKeyTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Pages\/DumpPageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Talliers\/PluralityTallier.php":{"errors":0,"warnings":3,"messages":[{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":46,"column":6},{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":55,"column":6},{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.FunctionComment.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":68,"column":6}]},"\/src\/repo\/tests\/phpunit\/integration\/ElectionTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/VotePage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Store\/FormStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/PreferentialBallotTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Store\/MemoryStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/CreatePage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Pages\/ListPageTest.php":{"errors":0,"warnings":1,"messages":[{"message":"Line exceeds 120 characters; contains 138 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":179,"column":138}]},"\/src\/repo\/tests\/phpunit\/integration\/STVBallotTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/ListPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/StatusException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/VoterEligibilityPage.php":{"errors":0,"warnings":0,"messages":[]}}} --- end --- PHPCS run failed $ vendor/bin/phpcbf --- stdout --- PHPCBF RESULT SUMMARY -------------------------------------------------------------------------------- FILE FIXED REMAINING -------------------------------------------------------------------------------- /src/repo/includes/TranslationRepo.php 1 0 /src/repo/tests/phpunit/integration/TranslationRepoTest.php 1 0 /src/repo/includes/Talliers/PairwiseTallier.php 1 0 /src/repo/includes/Talliers/HistogramRangeTallier.php 5 0 /src/repo/includes/Talliers/CommentDumper.php 1 0 /src/repo/includes/Ballots/STVBallot.php 1 0 /src/repo/includes/Talliers/SchulzeTallier.php 5 1 /src/repo/includes/SecurePollLogPager.php 1 0 /src/repo/includes/Talliers/PluralityTallier.php 3 0 /src/repo/includes/Talliers/STVFormatter/HtmlFormatter.php 1 0 -------------------------------------------------------------------------------- A TOTAL OF 20 ERRORS WERE FIXED IN 10 FILES -------------------------------------------------------------------------------- Time: 2.44 secs; Memory: 8MB --- end --- $ vendor/bin/phpcs --report=json --- stdout --- {"totals":{"errors":5,"warnings":2,"fixable":0},"files":{"\/src\/repo\/SecurePoll.constants.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/SecurePoll_GetUserParamsHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Entities\/Option.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/wm-scripts\/includes\/MailingListEntry.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/LoginPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/HookRunner.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/ArchivedPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Entities\/Question.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/SecurePoll_JumpUrlHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/TallyPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Ballots\/RadioRangeCommentBallot.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/MigrateTallies.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/PurgeDecryptionKeys.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Ballots\/ChooseBallot.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/wm-scripts\/importGlobalVoterList.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Jobs\/LogAdminActionJob.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/wm-scripts\/ucocar2025\/ucocAR2025PopulateEditCount.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/MakeSimpleList.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Jobs\/UnarchiveElectionJob.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/PurgePrivateVoteData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/HookHandler\/SetupHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/HookHandler\/LogoutHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/DeleteTallyPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/StrikePager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Jobs\/DeleteTallyJob.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Api\/ApiSecurePollAuth.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/UnarchivePage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ActionPageFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Exceptions\/InvalidDataException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SpecialSecurePoll.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/DumpVoteCsv.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/ActionPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Ballots\/PreferentialBallot.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/UpdateNotBlockedKey.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/DumpElection.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/ArchivePage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/HookHandler\/InstallHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Ballots\/BallotStatus.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/HookRunnerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Rest\/SetTranslationHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/wm-scripts\/deduplicateMailingList.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/FindUsersWithRight.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/maintenance\/MigrateTalliesTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/TallyElection.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/maintenance\/DropUnusedTablesTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/ImportElectionConfiguration.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/EntryPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SpecialSecurePollLog.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/SecurePollLogPagerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Talliers\/PairwiseTallier.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/DropUnusedTables.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Store\/DBStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Jobs\/TallyElectionJob.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/PluralityTallierTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/OpenSSLAsymmetricKey.php":{"errors":1,"warnings":0,"messages":[{"message":"You must use \"\/**\" style comments for a class comment, or add an empty line after stray comments","source":"MediaWiki.Commenting.CommentBeforeClass.StrayStyle","severity":5,"fixable":false,"type":"ERROR","line":3,"column":1}]},"\/src\/repo\/includes\/Pages\/ElectionPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/HistogramRangeTallierTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/ConvertVotes.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/wm-scripts\/makeGlobalVoterList.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Api\/ApiStrikeVote.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/VoteRecordTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/SetTranslationHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/SecurePoll.namespaces.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/wm-scripts\/u4c2025\/u4C2025PopulateEditCount.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/DumpElectionScript.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/maintenance\/ConvertVotesTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/TranslationRepo.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/SchulzeTallierTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/MainElectionsPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Store\/Store.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/User\/LocalAuth.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Talliers\/Tallier.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/WikitextFormatterTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Talliers\/STVFormatter\/WikitextFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/DeletePoll.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ChooseBallotTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/maintenance\/ImportElectionConfigurationTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/wm-scripts\/makeMailingList.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/DumpTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/TranslatePage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/ListPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Pages\/ArchivePageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/PairwiseTallierTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Entities\/Entity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/DumpComments.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/TranslationRepoTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ActionPageFactoryTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/wm-scripts\/PopulateEditCount.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/RadioRangeBallotTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/HtmlFormatterTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Crypt\/Random.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/VoteRecord.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/SpecialSecurePollLogTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/BallotTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/HtmlForm\/HTMLFormRadioRangeColumnLabels.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/TallierTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/STVTallierTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Ballots\/Ballot.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/User\/Voter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/DetailsPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SecurePollContentHandler.php":{"errors":2,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":16,"column":4},{"message":"There must be at least a blank line between a file-level comment and a class. Make sure you are not mixing file-level comments (like license headers) and class documentation","source":"MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":21,"column":2}]},"\/src\/repo\/tests\/phpunit\/integration\/SecurePollServiceWiringTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/DeleteTallyJobTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/SecurePollContentHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Ballots\/STVBallot.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Pages\/CreatePageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/User\/Auth.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ApprovalBallotTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/GenerateTestElection.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/ArchivedPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Talliers\/STVTallier.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/SetTranslationHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Crypt\/Crypt.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Pages\/DetailsPageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Pages\/EntryPageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Context.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Talliers\/STVFormatter\/HtmlFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Talliers\/CommentDumper.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Talliers\/STVFormatter\/STVFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Jobs\/PopulateVoterListJob.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/TallyListPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/User\/RemoteMWAuth.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Talliers\/ElectionTallier.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Ballots\/ApprovalBallot.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Pages\/UnarchivePageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Talliers\/HistogramRangeTallier.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/OpenSslCryptTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/wm-scripts\/sendMail.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Jobs\/ArchiveElectionJob.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/VoteSummaryTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Store\/XMLStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Ballots\/RadioRangeBallot.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/MessageDumpPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/wm-scripts\/bv2025\/bv2025PopulateEditCount.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/SecurePoll.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SecurePollLogPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Talliers\/PluralityTallier.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SecurePollContent.php":{"errors":2,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":10,"column":4},{"message":"There must be at least a blank line between a file-level comment and a class. Make sure you are not mixing file-level comments (like license headers) and class documentation","source":"MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":15,"column":2}]},"\/src\/repo\/includes\/Entities\/Election.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Talliers\/SchulzeTallier.php":{"errors":0,"warnings":1,"messages":[{"message":"Line exceeds 120 characters; contains 143 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":199,"column":143}]},"\/src\/repo\/tests\/phpunit\/integration\/Pages\/VoterEligibilityPageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/DumpPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Pages\/DumpPageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/VotePage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ElectionTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Crypt\/OpenSslCrypt.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/cli\/purgePrivateVoteData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Pages\/ListPageTest.php":{"errors":0,"warnings":1,"messages":[{"message":"Line exceeds 120 characters; contains 138 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":179,"column":138}]},"\/src\/repo\/includes\/Store\/FormStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/maintenance\/UpdateNotBlockedKeyTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/PreferentialBallotTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Store\/MemoryStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/STVBallotTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/CreatePage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/ListPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/StatusException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Pages\/VoterEligibilityPage.php":{"errors":0,"warnings":0,"messages":[]}}} --- end --- * sniff MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation is now failing * sniff MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter is now failing * sniff MediaWiki.Commenting.CommentBeforeClass.StrayStyle is now failing $ git checkout .phpcs.xml --- stderr --- Updated 1 path from the index --- stdout --- --- end --- $ /usr/bin/composer install --- stderr --- Installing dependencies from lock file (including require-dev) Verifying lock file contents can be installed on current platform. Nothing to install, update or remove Generating autoload files 17 packages you are using are looking for funding. Use the `composer fund` command to find out more! --- stdout --- --- end --- $ /usr/bin/composer test --- stderr --- > parallel-lint . --exclude vendor --exclude node_modules -e php,inc > phpcs -sp --cache > minus-x check . --- stdout --- PHP 8.2.28 | 10 parallel jobs ............................................................ 60/159 ( 37%) ............................................................ 120/159 ( 75%) ....................................... 159/159 (100%) Checked 159 files in 0.7 seconds No syntax error found ..................................................... 53 / 53 (100%) Time: 412ms; Memory: 14MB MinusX ====== Processing /src/repo... ............................................................. ............................................................. ............................................................. ............................................................. ............................................................. ............................................................. ............................................................. ............................................................. ............................................................. ......................... All good! --- end --- $ /usr/bin/npm audit --json --- stdout --- { "auditReportVersion": 2, "vulnerabilities": {}, "metadata": { "vulnerabilities": { "info": 0, "low": 0, "moderate": 0, "high": 0, "critical": 0, "total": 0 }, "dependencies": { "prod": 1, "dev": 455, "optional": 4, "peer": 5, "peerOptional": 0, "total": 455 } } } --- end --- $ package-lock-lint package-lock.json --- stdout --- Checking package-lock.json --- end --- build: Updating mediawiki/mediawiki-codesniffer to 48.0.0 The following sniffs are failing and were disabled: * MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation * MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter * MediaWiki.Commenting.CommentBeforeClass.StrayStyle $ git add . --- stdout --- --- end --- $ git commit -F /tmp/tmpz5gs0dlj --- stdout --- [master 3ceaafa] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0 12 files changed, 5 insertions(+), 21 deletions(-) --- end --- $ git format-patch HEAD~1 --stdout --- stdout --- From 3ceaafa34f0dfe930db21ef83f288d9f641a1699 Mon Sep 17 00:00:00 2001 From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org> Date: Mon, 8 Sep 2025 05:40:09 +0000 Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0 The following sniffs are failing and were disabled: * MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation * MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter * MediaWiki.Commenting.CommentBeforeClass.StrayStyle Change-Id: I4232efe1c1c1557a9b5c85701643761445835c35 --- .phpcs.xml | 3 +++ composer.json | 2 +- includes/Ballots/STVBallot.php | 1 - includes/SecurePollLogPager.php | 2 +- includes/Talliers/CommentDumper.php | 1 - includes/Talliers/HistogramRangeTallier.php | 5 ----- includes/Talliers/PairwiseTallier.php | 1 - includes/Talliers/PluralityTallier.php | 3 --- includes/Talliers/STVFormatter/HtmlFormatter.php | 1 - includes/Talliers/SchulzeTallier.php | 5 ----- includes/TranslationRepo.php | 1 - tests/phpunit/integration/TranslationRepoTest.php | 1 - 12 files changed, 5 insertions(+), 21 deletions(-) diff --git a/.phpcs.xml b/.phpcs.xml index 6d42d20..7b1c7f5 100644 --- a/.phpcs.xml +++ b/.phpcs.xml @@ -2,6 +2,9 @@ <ruleset> <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki"> <exclude name="Generic.Files.LineLength.TooLong" /> + <exclude name="MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation" /> + <exclude name="MediaWiki.Commenting.CommentBeforeClass.FileSpacingAfter" /> + <exclude name="MediaWiki.Commenting.CommentBeforeClass.StrayStyle" /> </rule> <rule ref="MediaWiki.Files.ClassMatchesFilename.NotMatch"> <exclude-pattern>*/cli/*.php</exclude-pattern> diff --git a/composer.json b/composer.json index 7c9ad41..b0db4d2 100644 --- a/composer.json +++ b/composer.json @@ -1,7 +1,7 @@ { "require-dev": { "ext-bcmath": "*", - "mediawiki/mediawiki-codesniffer": "47.0.0", + "mediawiki/mediawiki-codesniffer": "48.0.0", "mediawiki/mediawiki-phan-config": "0.17.0", "mediawiki/minus-x": "1.1.3", "php-parallel-lint/php-console-highlighter": "1.0.0", diff --git a/includes/Ballots/STVBallot.php b/includes/Ballots/STVBallot.php index a22d7f1..a8bc082 100644 --- a/includes/Ballots/STVBallot.php +++ b/includes/Ballots/STVBallot.php @@ -324,7 +324,6 @@ class STVBallot extends Ballot { } /** - * * @param int $count * @return bool */ diff --git a/includes/SecurePollLogPager.php b/includes/SecurePollLogPager.php index 1c6fe48..25dffc2 100644 --- a/includes/SecurePollLogPager.php +++ b/includes/SecurePollLogPager.php @@ -20,7 +20,7 @@ class SecurePollLogPager extends ReverseChronologicalPager { int $year, int $month, int $day, - /** @var int[] $actions */ + /** @var int[] */ private readonly array $actions, ) { parent::__construct(); diff --git a/includes/Talliers/CommentDumper.php b/includes/Talliers/CommentDumper.php index 4f18a87..d3d77a0 100644 --- a/includes/Talliers/CommentDumper.php +++ b/includes/Talliers/CommentDumper.php @@ -101,7 +101,6 @@ class CommentDumper extends ElectionTallier { /** * @inheritDoc - * */ public function getTextResult() { return stream_get_contents( $this->csvHandle, -1, 0 ); diff --git a/includes/Talliers/HistogramRangeTallier.php b/includes/Talliers/HistogramRangeTallier.php index f738c5d..c3edb05 100644 --- a/includes/Talliers/HistogramRangeTallier.php +++ b/includes/Talliers/HistogramRangeTallier.php @@ -42,7 +42,6 @@ class HistogramRangeTallier extends Tallier { /** * @inheritDoc - * */ public function addVote( $scores ) { foreach ( $scores as $oid => $score ) { @@ -56,7 +55,6 @@ class HistogramRangeTallier extends Tallier { /** * @inheritDoc - * */ public function finishTally() { $this->averages = []; @@ -72,7 +70,6 @@ class HistogramRangeTallier extends Tallier { /** * @inheritDoc - * */ public function loadJSONResult( $data ) { $this->averages = $data['averages']; @@ -81,7 +78,6 @@ class HistogramRangeTallier extends Tallier { /** * @inheritDoc - * */ public function getJSONResult() { return [ @@ -138,7 +134,6 @@ class HistogramRangeTallier extends Tallier { /** * @inheritDoc - * */ public function getTextResult() { return $this->getHtmlResult(); diff --git a/includes/Talliers/PairwiseTallier.php b/includes/Talliers/PairwiseTallier.php index 5161649..2fc35bc 100644 --- a/includes/Talliers/PairwiseTallier.php +++ b/includes/Talliers/PairwiseTallier.php @@ -36,7 +36,6 @@ abstract class PairwiseTallier extends Tallier { /** * @inheritDoc - * */ public function addVote( $ranks ) { foreach ( $this->optionIds as $oid1 ) { diff --git a/includes/Talliers/PluralityTallier.php b/includes/Talliers/PluralityTallier.php index b4da88a..ad1c957 100644 --- a/includes/Talliers/PluralityTallier.php +++ b/includes/Talliers/PluralityTallier.php @@ -42,7 +42,6 @@ class PluralityTallier extends Tallier { /** * @inheritDoc - * */ public function finishTally() { // Sort the scores @@ -51,7 +50,6 @@ class PluralityTallier extends Tallier { /** * @inheritDoc - * */ public function loadJSONResult( $data ) { $this->tally = $data; @@ -64,7 +62,6 @@ class PluralityTallier extends Tallier { /** * @inheritDoc - * */ public function getHtmlResult() { // Show the results diff --git a/includes/Talliers/STVFormatter/HtmlFormatter.php b/includes/Talliers/STVFormatter/HtmlFormatter.php index d9b27b0..9c07140 100644 --- a/includes/Talliers/STVFormatter/HtmlFormatter.php +++ b/includes/Talliers/STVFormatter/HtmlFormatter.php @@ -51,7 +51,6 @@ class HtmlFormatter implements STVFormatter { protected $modifiers = []; /** - * * @param array $resultLogs * @param array $rankedVotes * @param int $seats diff --git a/includes/Talliers/SchulzeTallier.php b/includes/Talliers/SchulzeTallier.php index 976b735..f69e65b 100644 --- a/includes/Talliers/SchulzeTallier.php +++ b/includes/Talliers/SchulzeTallier.php @@ -138,7 +138,6 @@ class SchulzeTallier extends PairwiseTallier { /** * @inheritDoc - * */ public function finishTally() { $this->strengths = $this->getPathStrengths( $this->victories ); @@ -154,7 +153,6 @@ class SchulzeTallier extends PairwiseTallier { /** * @inheritDoc - * */ public function loadJSONResult( $data ) { $this->ranks = $data['ranks']; @@ -164,7 +162,6 @@ class SchulzeTallier extends PairwiseTallier { /** * @inheritDoc - * */ public function getJSONResult() { return [ @@ -176,7 +173,6 @@ class SchulzeTallier extends PairwiseTallier { /** * @inheritDoc - * */ public function getHtmlResult() { $s = '<h2>' . wfMessage( 'securepoll-ranks' )->parse() . "</h2>\n"; @@ -194,7 +190,6 @@ class SchulzeTallier extends PairwiseTallier { /** * @inheritDoc - * */ public function getTextResult() { $rankedIds = array_keys( $this->ranks ); diff --git a/includes/TranslationRepo.php b/includes/TranslationRepo.php index 5c287ea..1500c88 100644 --- a/includes/TranslationRepo.php +++ b/includes/TranslationRepo.php @@ -22,7 +22,6 @@ class TranslationRepo { } /** - * * @param Election $election * @param array $data * @param string $language diff --git a/tests/phpunit/integration/TranslationRepoTest.php b/tests/phpunit/integration/TranslationRepoTest.php index 5515510..a78e832 100644 --- a/tests/phpunit/integration/TranslationRepoTest.php +++ b/tests/phpunit/integration/TranslationRepoTest.php @@ -18,7 +18,6 @@ use Wikimedia\Rdbms\SelectQueryBuilder; class TranslationRepoTest extends MediaWikiIntegrationTestCase { /** - * * @param array $data * @param string $language * @param string $comment -- 2.39.5 --- end ---