This run took 17 seconds.
From b593646f847152cd3ddab913d9b7f170481911f3 Mon Sep 17 00:00:00 2001 From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org> Date: Fri, 12 Sep 2025 05:16:17 +0000 Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0 The following sniffs are failing and were disabled: * MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation * MediaWiki.Commenting.CommentBeforeClass.SpacingAfter Change-Id: I8c9ac10b54b0e02a0f6870fb4a44976ea570f962 --- .phpcs.xml | 5 ++++- composer.json | 2 +- tests/phpunit/DigestEmailTest.php | 1 - 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.phpcs.xml b/.phpcs.xml index a2143a7..eac1842 100644 --- a/.phpcs.xml +++ b/.phpcs.xml @@ -1,6 +1,9 @@ <?xml version="1.0"?> <ruleset> - <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" /> + <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki"> + <exclude name="MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation" /> + <exclude name="MediaWiki.Commenting.CommentBeforeClass.SpacingAfter" /> + </rule> <rule ref="Generic.Files.LineLength"> <exclude-pattern>TranslationNotifications\.alias\.php</exclude-pattern> </rule> diff --git a/composer.json b/composer.json index 8fb3789..745ffd9 100644 --- a/composer.json +++ b/composer.json @@ -4,7 +4,7 @@ "homepage": "https://www.mediawiki.org/wiki/Extension:TranslationNotifications", "license": "GPL-2.0-or-later", "require-dev": { - "mediawiki/mediawiki-codesniffer": "47.0.0", + "mediawiki/mediawiki-codesniffer": "48.0.0", "mediawiki/mediawiki-phan-config": "0.17.0", "mediawiki/minus-x": "1.1.3", "php-parallel-lint/php-console-highlighter": "1.0.0", diff --git a/tests/phpunit/DigestEmailTest.php b/tests/phpunit/DigestEmailTest.php index 275db93..556ed82 100644 --- a/tests/phpunit/DigestEmailTest.php +++ b/tests/phpunit/DigestEmailTest.php @@ -7,7 +7,6 @@ use MediaWiki\MainConfigNames; use MediaWiki\Title\Title; /** - * * Unit tests for DigestEmailer class. * @author Santhosh Thottingal * @copyright Copyright © 2012, Santhosh Thottingal -- 2.39.5
$ date --- stdout --- Fri Sep 12 05:16:07 UTC 2025 --- end --- $ git clone file:///srv/git/mediawiki-extensions-TranslationNotifications.git repo --depth=1 -b master --- stderr --- Cloning into 'repo'... --- stdout --- --- end --- $ git config user.name libraryupgrader --- stdout --- --- end --- $ git config user.email tools.libraryupgrader@tools.wmflabs.org --- stdout --- --- end --- $ git submodule update --init --- stdout --- --- end --- $ grr init --- stdout --- Installed commit-msg hook. --- end --- $ git show-ref refs/heads/master --- stdout --- 14f74470d00784c5b2d572459b2dab12008f0e34 refs/heads/master --- end --- $ /usr/bin/npm audit --json --- stdout --- { "auditReportVersion": 2, "vulnerabilities": {}, "metadata": { "vulnerabilities": { "info": 0, "low": 0, "moderate": 0, "high": 0, "critical": 0, "total": 0 }, "dependencies": { "prod": 1, "dev": 456, "optional": 4, "peer": 5, "peerOptional": 0, "total": 456 } } } --- end --- $ /usr/bin/composer install --- stderr --- No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information. Loading composer repositories with package information Updating dependencies Lock file operations: 38 installs, 0 updates, 0 removals - Locking composer/pcre (3.3.2) - Locking composer/semver (3.4.3) - Locking composer/spdx-licenses (1.5.9) - Locking composer/xdebug-handler (3.0.5) - Locking dealerdirect/phpcodesniffer-composer-installer (v1.1.2) - Locking doctrine/deprecations (1.1.5) - Locking felixfbecker/advanced-json-rpc (v3.2.1) - Locking mediawiki/mediawiki-codesniffer (v47.0.0) - Locking mediawiki/mediawiki-phan-config (0.17.0) - Locking mediawiki/minus-x (1.1.3) - Locking mediawiki/phan-taint-check-plugin (7.0.0) - Locking microsoft/tolerant-php-parser (v0.1.2) - Locking netresearch/jsonmapper (v4.5.0) - Locking phan/phan (5.5.1) - Locking php-parallel-lint/php-console-color (v1.0.1) - Locking php-parallel-lint/php-console-highlighter (v1.0.0) - Locking php-parallel-lint/php-parallel-lint (v1.4.0) - Locking phpcsstandards/phpcsextra (1.2.1) - Locking phpcsstandards/phpcsutils (1.0.12) - Locking phpdocumentor/reflection-common (2.2.0) - Locking phpdocumentor/reflection-docblock (5.6.3) - Locking phpdocumentor/type-resolver (1.10.0) - Locking phpstan/phpdoc-parser (2.3.0) - Locking psr/container (2.0.2) - Locking psr/log (3.0.2) - Locking sabre/event (5.1.7) - Locking squizlabs/php_codesniffer (3.12.2) - Locking symfony/console (v7.3.3) - Locking symfony/deprecation-contracts (v3.6.0) - Locking symfony/polyfill-ctype (v1.33.0) - Locking symfony/polyfill-intl-grapheme (v1.33.0) - Locking symfony/polyfill-intl-normalizer (v1.33.0) - Locking symfony/polyfill-mbstring (v1.33.0) - Locking symfony/polyfill-php80 (v1.33.0) - Locking symfony/service-contracts (v3.6.0) - Locking symfony/string (v7.3.3) - Locking tysonandre/var_representation_polyfill (0.1.3) - Locking webmozart/assert (1.11.0) Writing lock file Installing dependencies from lock file (including require-dev) Package operations: 38 installs, 0 updates, 0 removals 0 [>---------------------------] 0 [->--------------------------] - Installing squizlabs/php_codesniffer (3.12.2): Extracting archive - Installing dealerdirect/phpcodesniffer-composer-installer (v1.1.2): Extracting archive - Installing composer/pcre (3.3.2): Extracting archive - Installing symfony/polyfill-php80 (v1.33.0): Extracting archive - Installing phpcsstandards/phpcsutils (1.0.12): Extracting archive - Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive - Installing symfony/polyfill-mbstring (v1.33.0): Extracting archive - Installing composer/spdx-licenses (1.5.9): Extracting archive - Installing composer/semver (3.4.3): Extracting archive - Installing mediawiki/mediawiki-codesniffer (v47.0.0): Extracting archive - Installing tysonandre/var_representation_polyfill (0.1.3): Extracting archive - Installing symfony/polyfill-intl-normalizer (v1.33.0): Extracting archive - Installing symfony/polyfill-intl-grapheme (v1.33.0): Extracting archive - Installing symfony/polyfill-ctype (v1.33.0): Extracting archive - Installing symfony/string (v7.3.3): Extracting archive - Installing symfony/deprecation-contracts (v3.6.0): Extracting archive - Installing psr/container (2.0.2): Extracting archive - Installing symfony/service-contracts (v3.6.0): Extracting archive - Installing symfony/console (v7.3.3): Extracting archive - Installing sabre/event (5.1.7): Extracting archive - Installing netresearch/jsonmapper (v4.5.0): Extracting archive - Installing microsoft/tolerant-php-parser (v0.1.2): Extracting archive - Installing webmozart/assert (1.11.0): Extracting archive - Installing phpstan/phpdoc-parser (2.3.0): Extracting archive - Installing phpdocumentor/reflection-common (2.2.0): Extracting archive - Installing doctrine/deprecations (1.1.5): Extracting archive - Installing phpdocumentor/type-resolver (1.10.0): Extracting archive - Installing phpdocumentor/reflection-docblock (5.6.3): Extracting archive - Installing felixfbecker/advanced-json-rpc (v3.2.1): Extracting archive - Installing psr/log (3.0.2): Extracting archive - Installing composer/xdebug-handler (3.0.5): Extracting archive - Installing phan/phan (5.5.1): Extracting archive - Installing mediawiki/phan-taint-check-plugin (7.0.0): Extracting archive - Installing mediawiki/mediawiki-phan-config (0.17.0): Extracting archive - Installing mediawiki/minus-x (1.1.3): Extracting archive - Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive - Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive - Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive 0/36 [>---------------------------] 0% 23/36 [=================>----------] 63% 35/36 [===========================>] 97% 36/36 [============================] 100% 1 package suggestions were added by new dependencies, use `composer suggest` to see details. Generating autoload files 17 packages you are using are looking for funding. Use the `composer fund` command to find out more! --- stdout --- PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils --- end --- Upgrading c:mediawiki/mediawiki-codesniffer from 47.0.0 -> 48.0.0 $ /usr/bin/composer update --- stderr --- Loading composer repositories with package information Updating dependencies Lock file operations: 0 installs, 5 updates, 0 removals - Upgrading composer/semver (3.4.3 => 3.4.4) - Upgrading mediawiki/mediawiki-codesniffer (v47.0.0 => v48.0.0) - Upgrading phpcsstandards/phpcsextra (1.2.1 => 1.4.0) - Upgrading phpcsstandards/phpcsutils (1.0.12 => 1.1.1) - Upgrading squizlabs/php_codesniffer (3.12.2 => 3.13.2) Writing lock file Installing dependencies from lock file (including require-dev) Package operations: 0 installs, 5 updates, 0 removals 0 [>---------------------------] 0 [->--------------------------] - Upgrading squizlabs/php_codesniffer (3.12.2 => 3.13.2): Extracting archive - Upgrading phpcsstandards/phpcsutils (1.0.12 => 1.1.1): Extracting archive - Upgrading phpcsstandards/phpcsextra (1.2.1 => 1.4.0): Extracting archive - Upgrading composer/semver (3.4.3 => 3.4.4): Extracting archive - Upgrading mediawiki/mediawiki-codesniffer (v47.0.0 => v48.0.0): Extracting archive 0/5 [>---------------------------] 0% 4/5 [======================>-----] 80% 5/5 [============================] 100% Generating autoload files 17 packages you are using are looking for funding. Use the `composer fund` command to find out more! No security vulnerability advisories found --- stdout --- PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils --- end --- $ vendor/bin/phpcs --report=json --- stdout --- {"totals":{"errors":2,"warnings":1,"fixable":1},"files":{"\/src\/repo\/includes\/Hooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/Event.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/FixTranslationNotificationsEmptyLangPrefs.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/EchoEventPresentationModel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/UnsubscribeInactiveUsersPresentationModel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/TranslationNotificationsLogFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Jobs\/GenericTranslationNotificationsJob.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Utilities\/LanguageSet.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Jobs\/TranslationNotificationsEmailJob.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Utilities\/NotificationMessageBuilder.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Utilities\/TranslationNotifyUser.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SpecialNotifyTranslators.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/DigestEmailTest.php":{"errors":0,"warnings":1,"messages":[{"message":"Doc comments must not start with multiple empty lines","source":"MediaWiki.Commenting.ClassDocumentation.EmptyLinesStart","severity":5,"fixable":true,"type":"WARNING","line":9,"column":1}]},"\/src\/repo\/scripts\/DigestEmailer.php":{"errors":1,"warnings":0,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments; if it is a file-level comment, file a task in #MediaWiki-Codesniffer","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":23,"column":1}]},"\/src\/repo\/maintenance\/UnsubscribeInactiveUsers.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SpecialTranslatorSignup.php":{"errors":1,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":21,"column":4}]},"\/src\/repo\/includes\/Jobs\/TranslationNotificationsSubmitJob.php":{"errors":0,"warnings":0,"messages":[]}}} --- end --- PHPCS run failed $ vendor/bin/phpcbf --- stdout --- PHPCBF RESULT SUMMARY ---------------------------------------------------------------------- FILE FIXED REMAINING ---------------------------------------------------------------------- /src/repo/tests/phpunit/DigestEmailTest.php 1 0 ---------------------------------------------------------------------- A TOTAL OF 1 ERROR WERE FIXED IN 1 FILE ---------------------------------------------------------------------- Time: 470ms; Memory: 8MB --- end --- $ vendor/bin/phpcs --report=json --- stdout --- {"totals":{"errors":2,"warnings":0,"fixable":0},"files":{"\/src\/repo\/.phan\/stubs\/Event.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/FixTranslationNotificationsEmptyLangPrefs.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Utilities\/LanguageSet.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/EchoEventPresentationModel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Jobs\/GenericTranslationNotificationsJob.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/UnsubscribeInactiveUsersPresentationModel.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Utilities\/NotificationMessageBuilder.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/TranslationNotificationsLogFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Jobs\/TranslationNotificationsEmailJob.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/scripts\/DigestEmailer.php":{"errors":1,"warnings":0,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments; if it is a file-level comment, file a task in #MediaWiki-Codesniffer","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":23,"column":1}]},"\/src\/repo\/includes\/SpecialNotifyTranslators.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Utilities\/TranslationNotifyUser.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SpecialTranslatorSignup.php":{"errors":1,"warnings":0,"messages":[{"message":"@file is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":21,"column":4}]},"\/src\/repo\/tests\/phpunit\/DigestEmailTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Jobs\/TranslationNotificationsSubmitJob.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/UnsubscribeInactiveUsers.php":{"errors":0,"warnings":0,"messages":[]}}} --- end --- * sniff MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation is now failing * sniff MediaWiki.Commenting.CommentBeforeClass.SpacingAfter is now failing $ git checkout .phpcs.xml --- stderr --- Updated 0 paths from the index --- stdout --- --- end --- $ /usr/bin/composer install --- stderr --- Installing dependencies from lock file (including require-dev) Verifying lock file contents can be installed on current platform. Nothing to install, update or remove Generating autoload files 17 packages you are using are looking for funding. Use the `composer fund` command to find out more! --- stdout --- --- end --- $ /usr/bin/composer test --- stderr --- > parallel-lint . --exclude node_modules --exclude vendor > phpcs -sp --cache > minus-x check . --- stdout --- PHP 8.2.28 | 10 parallel jobs .................. 18/18 (100%) Checked 18 files in 0.1 seconds No syntax error found .................. 18 / 18 (100%) Time: 169ms; Memory: 8MB MinusX ====== Processing /src/repo... ............................................................. ............................................................. ............................................................. ........................................................... All good! --- end --- $ /usr/bin/npm audit --json --- stdout --- { "auditReportVersion": 2, "vulnerabilities": {}, "metadata": { "vulnerabilities": { "info": 0, "low": 0, "moderate": 0, "high": 0, "critical": 0, "total": 0 }, "dependencies": { "prod": 1, "dev": 456, "optional": 4, "peer": 5, "peerOptional": 0, "total": 456 } } } --- end --- $ package-lock-lint package-lock.json --- stdout --- Checking package-lock.json --- end --- build: Updating mediawiki/mediawiki-codesniffer to 48.0.0 The following sniffs are failing and were disabled: * MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation * MediaWiki.Commenting.CommentBeforeClass.SpacingAfter $ git add . --- stdout --- --- end --- $ git commit -F /tmp/tmpqm_6i146 --- stdout --- [master b593646] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0 3 files changed, 5 insertions(+), 3 deletions(-) --- end --- $ git format-patch HEAD~1 --stdout --- stdout --- From b593646f847152cd3ddab913d9b7f170481911f3 Mon Sep 17 00:00:00 2001 From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org> Date: Fri, 12 Sep 2025 05:16:17 +0000 Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 48.0.0 The following sniffs are failing and were disabled: * MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation * MediaWiki.Commenting.CommentBeforeClass.SpacingAfter Change-Id: I8c9ac10b54b0e02a0f6870fb4a44976ea570f962 --- .phpcs.xml | 5 ++++- composer.json | 2 +- tests/phpunit/DigestEmailTest.php | 1 - 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.phpcs.xml b/.phpcs.xml index a2143a7..eac1842 100644 --- a/.phpcs.xml +++ b/.phpcs.xml @@ -1,6 +1,9 @@ <?xml version="1.0"?> <ruleset> - <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" /> + <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki"> + <exclude name="MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation" /> + <exclude name="MediaWiki.Commenting.CommentBeforeClass.SpacingAfter" /> + </rule> <rule ref="Generic.Files.LineLength"> <exclude-pattern>TranslationNotifications\.alias\.php</exclude-pattern> </rule> diff --git a/composer.json b/composer.json index 8fb3789..745ffd9 100644 --- a/composer.json +++ b/composer.json @@ -4,7 +4,7 @@ "homepage": "https://www.mediawiki.org/wiki/Extension:TranslationNotifications", "license": "GPL-2.0-or-later", "require-dev": { - "mediawiki/mediawiki-codesniffer": "47.0.0", + "mediawiki/mediawiki-codesniffer": "48.0.0", "mediawiki/mediawiki-phan-config": "0.17.0", "mediawiki/minus-x": "1.1.3", "php-parallel-lint/php-console-highlighter": "1.0.0", diff --git a/tests/phpunit/DigestEmailTest.php b/tests/phpunit/DigestEmailTest.php index 275db93..556ed82 100644 --- a/tests/phpunit/DigestEmailTest.php +++ b/tests/phpunit/DigestEmailTest.php @@ -7,7 +7,6 @@ use MediaWiki\MainConfigNames; use MediaWiki\Title\Title; /** - * * Unit tests for DigestEmailer class. * @author Santhosh Thottingal * @copyright Copyright © 2012, Santhosh Thottingal -- 2.39.5 --- end ---