This run took 26 seconds.
$ date
--- stdout ---
Tue Jan 27 08:16:08 UTC 2026
--- end ---
$ git clone file:///srv/git/mediawiki-tools-phan-SecurityCheckPlugin.git /src/repo --depth=1 -b master
--- stderr ---
Cloning into '/src/repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
f8f7e9349d826547c0b901ae7b28ad6592b39027 refs/heads/master
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 62 installs, 0 updates, 0 removals
- Locking composer/pcre (3.3.2)
- Locking composer/semver (3.4.4)
- Locking composer/spdx-licenses (1.5.9)
- Locking composer/xdebug-handler (3.0.5)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.2.0)
- Locking doctrine/deprecations (1.1.5)
- Locking felixfbecker/advanced-json-rpc (v3.2.1)
- Locking mediawiki/mediawiki-codesniffer (v48.0.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking microsoft/tolerant-php-parser (v0.1.2)
- Locking myclabs/deep-copy (1.13.4)
- Locking netresearch/jsonmapper (v4.5.0)
- Locking nikic/php-parser (v5.7.0)
- Locking phan/phan (5.5.2)
- Locking phar-io/manifest (2.0.4)
- Locking phar-io/version (3.2.1)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.4.0)
- Locking phpcsstandards/phpcsutils (1.1.1)
- Locking phpdocumentor/reflection-common (2.2.0)
- Locking phpdocumentor/reflection-docblock (5.6.6)
- Locking phpdocumentor/type-resolver (1.12.0)
- Locking phpstan/phpdoc-parser (2.3.2)
- Locking phpunit/php-code-coverage (10.1.16)
- Locking phpunit/php-file-iterator (4.1.0)
- Locking phpunit/php-invoker (4.0.0)
- Locking phpunit/php-text-template (3.0.1)
- Locking phpunit/php-timer (6.0.0)
- Locking phpunit/phpunit (10.5.58)
- Locking psr/container (2.0.2)
- Locking psr/log (3.0.2)
- Locking sabre/event (5.1.7)
- Locking sebastian/cli-parser (2.0.1)
- Locking sebastian/code-unit (2.0.0)
- Locking sebastian/code-unit-reverse-lookup (3.0.0)
- Locking sebastian/comparator (5.0.5)
- Locking sebastian/complexity (3.2.0)
- Locking sebastian/diff (5.1.1)
- Locking sebastian/environment (6.1.0)
- Locking sebastian/exporter (5.1.4)
- Locking sebastian/global-state (6.0.2)
- Locking sebastian/lines-of-code (2.0.2)
- Locking sebastian/object-enumerator (5.0.0)
- Locking sebastian/object-reflector (3.0.0)
- Locking sebastian/recursion-context (5.0.1)
- Locking sebastian/type (4.0.0)
- Locking sebastian/version (4.0.1)
- Locking squizlabs/php_codesniffer (3.13.2)
- Locking symfony/console (v7.4.4)
- Locking symfony/deprecation-contracts (v3.6.0)
- Locking symfony/polyfill-ctype (v1.33.0)
- Locking symfony/polyfill-intl-grapheme (v1.33.0)
- Locking symfony/polyfill-intl-normalizer (v1.33.0)
- Locking symfony/polyfill-mbstring (v1.33.0)
- Locking symfony/polyfill-php80 (v1.33.0)
- Locking symfony/service-contracts (v3.6.1)
- Locking symfony/string (v8.0.4)
- Locking theseer/tokenizer (1.3.1)
- Locking tysonandre/var_representation_polyfill (0.1.3)
- Locking webmozart/assert (2.1.2)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 62 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing squizlabs/php_codesniffer (3.13.2): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.2.0): Extracting archive
- Installing composer/pcre (3.3.2): Extracting archive
- Installing phpcsstandards/phpcsutils (1.1.1): Extracting archive
- Installing phpcsstandards/phpcsextra (1.4.0): Extracting archive
- Installing symfony/polyfill-mbstring (v1.33.0): Extracting archive
- Installing composer/spdx-licenses (1.5.9): Extracting archive
- Installing composer/semver (3.4.4): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v48.0.0): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.33.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.33.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.33.0): Extracting archive
- Installing symfony/string (v8.0.4): Extracting archive
- Installing symfony/deprecation-contracts (v3.6.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.6.1): Extracting archive
- Installing symfony/console (v7.4.4): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing tysonandre/var_representation_polyfill (0.1.3): Extracting archive
- Installing symfony/polyfill-php80 (v1.33.0): Extracting archive
- Installing sabre/event (5.1.7): Extracting archive
- Installing netresearch/jsonmapper (v4.5.0): Extracting archive
- Installing microsoft/tolerant-php-parser (v0.1.2): Extracting archive
- Installing webmozart/assert (2.1.2): Extracting archive
- Installing phpstan/phpdoc-parser (2.3.2): Extracting archive
- Installing phpdocumentor/reflection-common (2.2.0): Extracting archive
- Installing doctrine/deprecations (1.1.5): Extracting archive
- Installing phpdocumentor/type-resolver (1.12.0): Extracting archive
- Installing phpdocumentor/reflection-docblock (5.6.6): Extracting archive
- Installing felixfbecker/advanced-json-rpc (v3.2.1): Extracting archive
- Installing psr/log (3.0.2): Extracting archive
- Installing composer/xdebug-handler (3.0.5): Extracting archive
- Installing phan/phan (5.5.2): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
- Installing sebastian/version (4.0.1): Extracting archive
- Installing sebastian/type (4.0.0): Extracting archive
- Installing sebastian/recursion-context (5.0.1): Extracting archive
- Installing sebastian/object-reflector (3.0.0): Extracting archive
- Installing sebastian/object-enumerator (5.0.0): Extracting archive
- Installing sebastian/global-state (6.0.2): Extracting archive
- Installing sebastian/exporter (5.1.4): Extracting archive
- Installing sebastian/environment (6.1.0): Extracting archive
- Installing sebastian/diff (5.1.1): Extracting archive
- Installing sebastian/comparator (5.0.5): Extracting archive
- Installing sebastian/code-unit (2.0.0): Extracting archive
- Installing sebastian/cli-parser (2.0.1): Extracting archive
- Installing phpunit/php-timer (6.0.0): Extracting archive
- Installing phpunit/php-text-template (3.0.1): Extracting archive
- Installing phpunit/php-invoker (4.0.0): Extracting archive
- Installing phpunit/php-file-iterator (4.1.0): Extracting archive
- Installing theseer/tokenizer (1.3.1): Extracting archive
- Installing nikic/php-parser (v5.7.0): Extracting archive
- Installing sebastian/lines-of-code (2.0.2): Extracting archive
- Installing sebastian/complexity (3.2.0): Extracting archive
- Installing sebastian/code-unit-reverse-lookup (3.0.0): Extracting archive
- Installing phpunit/php-code-coverage (10.1.16): Extracting archive
- Installing phar-io/version (3.2.1): Extracting archive
- Installing phar-io/manifest (2.0.4): Extracting archive
- Installing myclabs/deep-copy (1.13.4): Extracting archive
- Installing phpunit/phpunit (10.5.58): Extracting archive
0/60 [>---------------------------] 0%
29/60 [=============>--------------] 48%
46/60 [=====================>------] 76%
59/60 [===========================>] 98%
60/60 [============================] 100%
3 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating autoload files
41 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 48.0.0 -> 49.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 3 updates, 0 removals
- Upgrading mediawiki/mediawiki-codesniffer (v48.0.0 => v49.0.0)
- Upgrading phpcsstandards/phpcsutils (1.1.1 => 1.2.2)
- Upgrading squizlabs/php_codesniffer (3.13.2 => 3.13.5)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 3 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.13.2 => 3.13.5): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.1.1 => 1.2.2): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v48.0.0 => v49.0.0): Extracting archive
0/3 [>---------------------------] 0%
2/3 [==================>---------] 66%
3/3 [============================] 100%
Generating autoload files
41 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found.
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: {'MediaWiki.Usage.ForbiddenFunctions.assert', 'MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix'}
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":4,"warnings":51,"fixable":0},"files":{"\/src\/repo\/src\/VarLinksMap.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/TaintednessLoopVisitor.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/TaintednessWithError.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/LinksMap.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/integration-test-config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/bootstrap.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/internal\/make_phar.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phan-interaction-test-config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/PreTaintednessVisitor.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/GenericSecurityCheckPlugin.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/MWPreVisitor.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/MediaWikiHooksHelper.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/scripts\/base-config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/scripts\/generic-config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/self-phan-config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/SingleMethodLinks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/TestMediaWikiSecurityCheckPlugin.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/TaintednessAccessorsTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/PreservedTaintedness.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ReturnObjectsCollectVisitor.php":{"errors":0,"warnings":2,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":27,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":236,"column":9}]},"\/src\/repo\/src\/ParamLinksOffsets.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/TaintednessBackpropVisitor.php":{"errors":0,"warnings":1,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":275,"column":9}]},"\/src\/repo\/src\/TaintednessAssignVisitor.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/FunctionCausedByLines.php":{"errors":0,"warnings":4,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":70,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":91,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":137,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":159,"column":9}]},"\/src\/repo\/src\/FunctionTaintedness.php":{"errors":0,"warnings":4,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":75,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":86,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":94,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":103,"column":9}]},"\/src\/repo\/MediaWikiSecurityCheckPlugin.php":{"errors":0,"warnings":1,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":233,"column":9}]},"\/src\/repo\/tests\/SecurityCheckTest.php":{"errors":4,"warnings":0,"messages":[{"message":"Global variable \"$internal_class_name_list\" is lacking an allowed prefix ('wg'). Should be \"$wgInternal_class_name_list\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":44,"column":13},{"message":"Global variable \"$internal_interface_name_list\" is lacking an allowed prefix ('wg'). Should be \"$wgInternal_interface_name_list\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":45,"column":13},{"message":"Global variable \"$internal_trait_name_list\" is lacking an allowed prefix ('wg'). Should be \"$wgInternal_trait_name_list\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":46,"column":13},{"message":"Global variable \"$internal_function_name_list\" is lacking an allowed prefix ('wg'). Should be \"$wgInternal_function_name_list\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":47,"column":13}]},"\/src\/repo\/src\/Taintedness.php":{"errors":0,"warnings":1,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":75,"column":13}]},"\/src\/repo\/src\/CausedByLines.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/MethodLinks.php":{"errors":0,"warnings":1,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":57,"column":13}]},"\/src\/repo\/src\/MWVisitor.php":{"errors":0,"warnings":14,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":55,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":57,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":221,"column":17},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":300,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":418,"column":13},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":423,"column":13},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":566,"column":13},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":571,"column":13},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":639,"column":13},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":644,"column":13},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":716,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":721,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":811,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":999,"column":13}]},"\/src\/repo\/src\/SecurityCheckPlugin.php":{"errors":0,"warnings":1,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":447,"column":21}]},"\/src\/repo\/src\/TaintednessVisitor.php":{"errors":0,"warnings":7,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":118,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":786,"column":17},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":807,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":853,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":859,"column":13},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":903,"column":13},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":938,"column":13}]},"\/src\/repo\/src\/TaintednessBaseVisitor.php":{"errors":0,"warnings":15,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":204,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":257,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":837,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":876,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":905,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":932,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":939,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":1102,"column":17},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":1221,"column":17},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":1302,"column":13},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":1513,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":1709,"column":21},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":1740,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":2092,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":2214,"column":13}]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":4,"warnings":51,"fixable":0},"files":{"\/src\/repo\/src\/VarLinksMap.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/TaintednessLoopVisitor.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/TaintednessWithError.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/LinksMap.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/integration-test-config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/GenericSecurityCheckPlugin.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phan-interaction-test-config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/PreTaintednessVisitor.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/internal\/make_phar.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/bootstrap.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/MWPreVisitor.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/scripts\/base-config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/scripts\/generic-config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/self-phan-config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/MediaWikiHooksHelper.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/PreservedTaintedness.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/SingleMethodLinks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/TestMediaWikiSecurityCheckPlugin.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/TaintednessAccessorsTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ReturnObjectsCollectVisitor.php":{"errors":0,"warnings":2,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":27,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":236,"column":9}]},"\/src\/repo\/src\/TaintednessAssignVisitor.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ParamLinksOffsets.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/TaintednessBackpropVisitor.php":{"errors":0,"warnings":1,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":275,"column":9}]},"\/src\/repo\/src\/FunctionCausedByLines.php":{"errors":0,"warnings":4,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":70,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":91,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":137,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":159,"column":9}]},"\/src\/repo\/src\/FunctionTaintedness.php":{"errors":0,"warnings":4,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":75,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":86,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":94,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":103,"column":9}]},"\/src\/repo\/MediaWikiSecurityCheckPlugin.php":{"errors":0,"warnings":1,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":233,"column":9}]},"\/src\/repo\/src\/Taintedness.php":{"errors":0,"warnings":1,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":75,"column":13}]},"\/src\/repo\/tests\/SecurityCheckTest.php":{"errors":4,"warnings":0,"messages":[{"message":"Global variable \"$internal_class_name_list\" is lacking an allowed prefix ('wg'). Should be \"$wgInternal_class_name_list\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":44,"column":13},{"message":"Global variable \"$internal_interface_name_list\" is lacking an allowed prefix ('wg'). Should be \"$wgInternal_interface_name_list\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":45,"column":13},{"message":"Global variable \"$internal_trait_name_list\" is lacking an allowed prefix ('wg'). Should be \"$wgInternal_trait_name_list\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":46,"column":13},{"message":"Global variable \"$internal_function_name_list\" is lacking an allowed prefix ('wg'). Should be \"$wgInternal_function_name_list\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":47,"column":13}]},"\/src\/repo\/src\/CausedByLines.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/MethodLinks.php":{"errors":0,"warnings":1,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":57,"column":13}]},"\/src\/repo\/src\/SecurityCheckPlugin.php":{"errors":0,"warnings":1,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":447,"column":21}]},"\/src\/repo\/src\/MWVisitor.php":{"errors":0,"warnings":14,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":55,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":57,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":221,"column":17},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":300,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":418,"column":13},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":423,"column":13},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":566,"column":13},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":571,"column":13},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":639,"column":13},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":644,"column":13},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":716,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":721,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":811,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":999,"column":13}]},"\/src\/repo\/src\/TaintednessVisitor.php":{"errors":0,"warnings":7,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":118,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":786,"column":17},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":807,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":853,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":859,"column":13},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":903,"column":13},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":938,"column":13}]},"\/src\/repo\/src\/TaintednessBaseVisitor.php":{"errors":0,"warnings":15,"messages":[{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":204,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":257,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":837,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":876,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":905,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":932,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":939,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":1102,"column":17},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":1221,"column":17},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":1302,"column":13},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":1513,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":1709,"column":21},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":1740,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":2092,"column":9},{"message":"assert should not be used","source":"MediaWiki.Usage.ForbiddenFunctions.assert","severity":5,"fixable":false,"type":"WARNING","line":2214,"column":13}]}}}
--- end ---
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
Tests still failing. Skipping
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
41 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude tests/integration
> phpcs -p -s
> minus-x check .
> bash ./tests/run-phan-on-plugin.sh
ERROR: Phan 5.x requires php-ast 1.1.3+ to properly analyze ASTs for php 8.4+. php-ast 1.1.2 and php 8.4.11 is installed.
php-ast can be installed in the following ways:
1. Unix (PECL): Run 'pecl install ast' and add extension=ast.so to your php.ini.
2. Unix (Compile): Download https://github.com/nikic/php-ast then compile and install the extension as follows:
cd path/to/php-ast
phpize
./configure
make
sudo make install
Additionally, add extension=ast.so to your php.ini file.
For more information, see https://github.com/phan/phan/wiki/Getting-Started#installing-dependencies
Exiting without analyzing files.
Script bash ./tests/run-phan-on-plugin.sh handling the phan-for-plugin event returned with error code 1
Script @phan-for-plugin was called via test
--- stdout ---
PHP 8.4.11 | 10 parallel jobs
........................................................... 59/59 (100%)
Checked 59 files in 0.2 seconds
No syntax error found
.................................. 34 / 34 (100%)
Time: 1.39 secs; Memory: 8MB
MinusX
======
Processing /src/repo...
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................
All good!
Starting phan
--- end ---
Traceback (most recent call last):
File "/venv/lib/python3.13/site-packages/runner/__init__.py", line 1304, in main
libup.run()
~~~~~~~~~^^
File "/venv/lib/python3.13/site-packages/runner/__init__.py", line 1239, in run
self.composer_upgrade(plan)
~~~~~~~~~~~~~~~~~~~~~^^^^^^
File "/venv/lib/python3.13/site-packages/runner/__init__.py", line 1024, in composer_upgrade
self.composer_test()
~~~~~~~~~~~~~~~~~~^^
File "/venv/lib/python3.13/site-packages/runner/__init__.py", line 326, in composer_test
self.check_call(["composer", "test"])
~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
File "/venv/lib/python3.13/site-packages/runner/shell2.py", line 66, in check_call
res.check_returncode()
~~~~~~~~~~~~~~~~~~~~^^
File "/usr/lib/python3.13/subprocess.py", line 508, in check_returncode
raise CalledProcessError(self.returncode, self.args, self.stdout,
self.stderr)
subprocess.CalledProcessError: Command '['/usr/bin/composer', 'test']' returned non-zero exit status 1.