$ date
--- stdout ---
Tue Nov 11 03:00:19 UTC 2025
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-S5SlideShow.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
982c156f746f72154da81a506e8e72b5f31d330a refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {
"brace-expansion": {
"name": "brace-expansion",
"severity": "low",
"isDirect": false,
"via": [
{
"source": 1105443,
"name": "brace-expansion",
"dependency": "brace-expansion",
"title": "brace-expansion Regular Expression Denial of Service vulnerability",
"url": "https://github.com/advisories/GHSA-v6h2-p8h4-qcjw",
"severity": "low",
"cwe": [
"CWE-400"
],
"cvss": {
"score": 3.1,
"vectorString": "CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:N/A:L"
},
"range": ">=1.0.0 <=1.1.11"
},
{
"source": 1105444,
"name": "brace-expansion",
"dependency": "brace-expansion",
"title": "brace-expansion Regular Expression Denial of Service vulnerability",
"url": "https://github.com/advisories/GHSA-v6h2-p8h4-qcjw",
"severity": "low",
"cwe": [
"CWE-400"
],
"cvss": {
"score": 3.1,
"vectorString": "CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:N/A:L"
},
"range": ">=2.0.0 <=2.0.1"
}
],
"effects": [],
"range": "1.0.0 - 1.1.11 || 2.0.0 - 2.0.1",
"nodes": [
"node_modules/@typescript-eslint/typescript-estree/node_modules/brace-expansion",
"node_modules/brace-expansion",
"node_modules/eslint-plugin-n/node_modules/brace-expansion"
],
"fixAvailable": true
}
},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 1,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 1
},
"dependencies": {
"prod": 1,
"dev": 311,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 311
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 22 installs, 0 updates, 0 removals
- Locking composer/installers (v1.12.0)
- Locking composer/semver (3.4.3)
- Locking composer/spdx-licenses (1.5.9)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.1.2)
- Locking mediawiki/mediawiki-codesniffer (v47.0.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.12)
- Locking psr/container (2.0.2)
- Locking squizlabs/php_codesniffer (3.12.2)
- Locking symfony/console (v7.3.6)
- Locking symfony/deprecation-contracts (v3.6.0)
- Locking symfony/polyfill-ctype (v1.33.0)
- Locking symfony/polyfill-intl-grapheme (v1.33.0)
- Locking symfony/polyfill-intl-normalizer (v1.33.0)
- Locking symfony/polyfill-mbstring (v1.33.0)
- Locking symfony/polyfill-php80 (v1.33.0)
- Locking symfony/service-contracts (v3.6.1)
- Locking symfony/string (v7.3.4)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 22 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing composer/installers (v1.12.0): Extracting archive
Deprecation Notice: Composer\Installers\Installer::__construct(): Implicitly marking parameter $filesystem as nullable is deprecated, the explicit nullable type must be used instead in /src/repo/vendor/composer/installers/src/Composer/Installers/Installer.php:136
More deprecation notices were hidden, run again with `-v` to show them.
- Installing squizlabs/php_codesniffer (3.12.2): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.1.2): Extracting archive
- Installing symfony/polyfill-php80 (v1.33.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.12): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.33.0): Extracting archive
- Installing composer/spdx-licenses (1.5.9): Extracting archive
- Installing composer/semver (3.4.3): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v47.0.0): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.33.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.33.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.33.0): Extracting archive
- Installing symfony/string (v7.3.4): Extracting archive
- Installing symfony/deprecation-contracts (v3.6.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.6.1): Extracting archive
- Installing symfony/console (v7.3.6): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/19 [>---------------------------] 0%
19/19 [============================] 100%
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 47.0.0 -> 48.0.0
$ /usr/bin/composer update
--- stderr ---
Deprecation Notice: Composer\Installers\Installer::__construct(): Implicitly marking parameter $filesystem as nullable is deprecated, the explicit nullable type must be used instead in /src/repo/vendor/composer/installers/src/Composer/Installers/Installer.php:136
More deprecation notices were hidden, run again with `-v` to show them.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 5 updates, 1 removal
- Removing symfony/polyfill-php80 (v1.33.0)
- Upgrading composer/semver (3.4.3 => 3.4.4)
- Upgrading mediawiki/mediawiki-codesniffer (v47.0.0 => v48.0.0)
- Upgrading phpcsstandards/phpcsextra (1.2.1 => 1.4.0)
- Upgrading phpcsstandards/phpcsutils (1.0.12 => 1.1.1)
- Upgrading squizlabs/php_codesniffer (3.12.2 => 3.13.2)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 5 updates, 1 removal
0 [>---------------------------] 0 [->--------------------------]
- Removing symfony/polyfill-php80 (v1.33.0)
- Upgrading squizlabs/php_codesniffer (3.12.2 => 3.13.2): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.0.12 => 1.1.1): Extracting archive
- Upgrading phpcsstandards/phpcsextra (1.2.1 => 1.4.0): Extracting archive
- Upgrading composer/semver (3.4.3 => 3.4.4): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v47.0.0 => v48.0.0): Extracting archive
0/5 [>---------------------------] 0%
4/5 [======================>-----] 80%
5/5 [============================] 100%
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found.
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: {'MediaWiki.Commenting.FunctionComment.MissingParamTag', 'MediaWiki.Commenting.FunctionComment.WrongStyle', 'MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate', 'MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected', 'MediaWiki.Files.ClassMatchesFilename.NotMatch', 'MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName', 'MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix', 'MediaWiki.Commenting.FunctionComment.MissingReturn', 'Generic.CodeAnalysis.AssignmentInCondition.Found'}
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":90,"warnings":4,"fixable":1},"files":{"\/src\/repo\/src\/S5SlideShow.i18n.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/S5SlideShow.i18n.magic.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Special.php":{"errors":2,"warnings":0,"messages":[{"message":"Class name 'SpecialS5SlideShow' does not match filename 'Special.php'","source":"MediaWiki.Files.ClassMatchesFilename.NotMatch","severity":5,"fixable":false,"type":"ERROR","line":31,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":48,"column":15}]},"\/src\/repo\/src\/Skin.php":{"errors":0,"warnings":1,"messages":[{"message":"Doc comments must not end with multiple empty lines","source":"MediaWiki.Commenting.ClassDocumentation.EmptyLinesEnd","severity":5,"fixable":true,"type":"WARNING","line":35,"column":2}]},"\/src\/repo\/src\/Article.php":{"errors":4,"warnings":0,"messages":[{"message":"You must use \"\/**\" style comments for a class comment, or add an empty line after stray comments","source":"MediaWiki.Commenting.CommentBeforeClass.StrayStyle","severity":5,"fixable":false,"type":"ERROR","line":42,"column":1},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":49,"column":12},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":57,"column":12},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":68,"column":12}]},"\/src\/repo\/src\/Action.php":{"errors":4,"warnings":1,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments; if it is a file-level comment, file a task in #MediaWiki-Codesniffer","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":28,"column":1},{"message":"@subpackage is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":32,"column":4},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":39,"column":12},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":49,"column":12},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.Found","severity":5,"fixable":false,"type":"WARNING","line":103,"column":33}]},"\/src\/repo\/src\/S5SlideShowHooks.php":{"errors":17,"warnings":0,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments; if it is a file-level comment, file a task in #MediaWiki-Codesniffer","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":29,"column":1},{"message":"@subpackage is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":33,"column":4},{"message":"Method name \"ParserFirstCallInit\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":48,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":48,"column":19},{"message":"Method name \"Setup\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":84,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":84,"column":19},{"message":"Method name \"MagicWordwgVariableIDs\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":95,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":95,"column":19},{"message":"Method name \"ParserGetVariableValueSwitch\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":100,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":100,"column":19},{"message":"Method name \"ImageBeforeProduceHTML\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":107,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":107,"column":19},{"message":"Global variable \"$egS5BrowserScaleHack\" is lacking an allowed prefix ('wg'). Should be \"$wgEgS5BrowserScaleHack\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":110,"column":9},{"message":"Method name \"ArticleFromTitle\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":162,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":162,"column":19},{"message":"Method name \"AlternateEdit\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":178,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":178,"column":19}]},"\/src\/repo\/src\/Render.php":{"errors":63,"warnings":2,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments; if it is a file-level comment, file a task in #MediaWiki-Codesniffer","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":39,"column":1},{"message":"@subpackage is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":44,"column":4},{"message":"Doc comment for parameter \"$sTitle\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":69,"column":5},{"message":"Doc comment for parameter \"$sContent\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":69,"column":5},{"message":"Doc comment for parameter \"$attr\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":69,"column":5},{"message":"Doc comment for parameter \"$attr\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":91,"column":5},{"message":"Global variable \"$egS5SlideHeadingMark\" is lacking an allowed prefix ('wg'). Should be \"$wgEgS5SlideHeadingMark\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":95,"column":9},{"message":"Global variable \"$egS5SlideIncMark\" is lacking an allowed prefix ('wg'). Should be \"$wgEgS5SlideIncMark\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":95,"column":9},{"message":"Global variable \"$egS5SlideCenterMark\" is lacking an allowed prefix ('wg'). Should be \"$wgEgS5SlideCenterMark\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":95,"column":9},{"message":"Global variable \"$egS5DefaultStyle\" is lacking an allowed prefix ('wg'). Should be \"$wgEgS5DefaultStyle\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":95,"column":9},{"message":"Global variable \"$egS5Scaled\" is lacking an allowed prefix ('wg'). Should be \"$wgEgS5Scaled\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":95,"column":9},{"message":"Doc comment for parameter \"$node\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":157,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":160,"column":6},{"message":"Method name \"check_slide_heading\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":161,"column":12},{"message":"Doc comment for parameter \"$content\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":186,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":188,"column":6},{"message":"Method name \"transform_section_slides\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":189,"column":13},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.Found","severity":5,"fixable":false,"type":"WARNING","line":217,"column":72},{"message":"Doc comment for parameter \"$content\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":273,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":275,"column":6},{"message":"Doc comment for parameter \"$text\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":307,"column":5},{"message":"Doc comment for parameter \"$inline\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":307,"column":5},{"message":"Doc comment for parameter \"$title\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":307,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":310,"column":6},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":329,"column":13},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate","severity":5,"fixable":false,"type":"ERROR","line":352,"column":13},{"message":"Doc comment for parameter \"$printPageSize\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":372,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":374,"column":6},{"message":"Global variable \"$egS5SlideTemplateFile\" is lacking an allowed prefix ('wg'). Should be \"$wgEgS5SlideTemplateFile\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":376,"column":9},{"message":"Doc comment for parameter \"$skin\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":474,"column":5},{"message":"Doc comment for parameter \"$m\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":474,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":477,"column":6},{"message":"Doc comment for parameter \"$skin\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":503,"column":5},{"message":"Doc comment for parameter \"$print\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":503,"column":5},{"message":"Doc comment for parameter \"$content\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":542,"column":5},{"message":"Doc comment for parameter \"$attr\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":542,"column":5},{"message":"Doc comment for parameter \"$parser\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":542,"column":5},{"message":"Doc comment for parameter \"$frame\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":542,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":544,"column":6},{"message":"Method name \"slideshow_legacy\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":545,"column":19},{"message":"Doc comment for parameter \"$content\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":553,"column":5},{"message":"Doc comment for parameter \"$parser\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":553,"column":5},{"message":"Doc comment for parameter \"$inline\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":553,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":556,"column":6},{"message":"Method name \"clone_options_parse\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":557,"column":20},{"message":"Doc comment for parameter \"$content\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":579,"column":5},{"message":"Doc comment for parameter \"$attr\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":579,"column":5},{"message":"Doc comment for parameter \"$parser\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":579,"column":5},{"message":"Doc comment for parameter \"$frame\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":579,"column":5},{"message":"Doc comment for parameter \"$addmsg\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":579,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":582,"column":6},{"message":"Method name \"slideshow_view\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":583,"column":19},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.Found","severity":5,"fixable":false,"type":"WARNING","line":624,"column":46},{"message":"Method name \"slideshow_parse\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":655,"column":12},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":655,"column":12},{"message":"Method name \"slides_view\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":662,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":662,"column":19},{"message":"Method name \"slides_parse\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":707,"column":12},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":707,"column":12},{"message":"Method name \"slidecss_view\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":726,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":726,"column":19},{"message":"Method name \"slidecss_parse\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":739,"column":12},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":739,"column":12},{"message":"Method name \"empty_tag_hook\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":744,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":744,"column":19}]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcbf
--- stdout ---
PHPCBF RESULT SUMMARY
----------------------------------------------------------------------
FILE FIXED REMAINING
----------------------------------------------------------------------
/src/repo/src/Skin.php 1 0
----------------------------------------------------------------------
A TOTAL OF 1 ERROR WERE FIXED IN 1 FILE
----------------------------------------------------------------------
Time: 300ms; Memory: 8MB
--- end ---
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":90,"warnings":3,"fixable":0},"files":{"\/src\/repo\/src\/Special.php":{"errors":2,"warnings":0,"messages":[{"message":"Class name 'SpecialS5SlideShow' does not match filename 'Special.php'","source":"MediaWiki.Files.ClassMatchesFilename.NotMatch","severity":5,"fixable":false,"type":"ERROR","line":31,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":48,"column":15}]},"\/src\/repo\/src\/Skin.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Article.php":{"errors":4,"warnings":0,"messages":[{"message":"You must use \"\/**\" style comments for a class comment, or add an empty line after stray comments","source":"MediaWiki.Commenting.CommentBeforeClass.StrayStyle","severity":5,"fixable":false,"type":"ERROR","line":42,"column":1},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":49,"column":12},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":57,"column":12},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":68,"column":12}]},"\/src\/repo\/src\/S5SlideShow.i18n.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/S5SlideShow.i18n.magic.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Action.php":{"errors":4,"warnings":1,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments; if it is a file-level comment, file a task in #MediaWiki-Codesniffer","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":28,"column":1},{"message":"@subpackage is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":32,"column":4},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":39,"column":12},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":49,"column":12},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.Found","severity":5,"fixable":false,"type":"WARNING","line":103,"column":33}]},"\/src\/repo\/src\/S5SlideShowHooks.php":{"errors":17,"warnings":0,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments; if it is a file-level comment, file a task in #MediaWiki-Codesniffer","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":29,"column":1},{"message":"@subpackage is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":33,"column":4},{"message":"Method name \"ParserFirstCallInit\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":48,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":48,"column":19},{"message":"Method name \"Setup\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":84,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":84,"column":19},{"message":"Method name \"MagicWordwgVariableIDs\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":95,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":95,"column":19},{"message":"Method name \"ParserGetVariableValueSwitch\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":100,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":100,"column":19},{"message":"Method name \"ImageBeforeProduceHTML\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":107,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":107,"column":19},{"message":"Global variable \"$egS5BrowserScaleHack\" is lacking an allowed prefix ('wg'). Should be \"$wgEgS5BrowserScaleHack\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":110,"column":9},{"message":"Method name \"ArticleFromTitle\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":162,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":162,"column":19},{"message":"Method name \"AlternateEdit\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":178,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":178,"column":19}]},"\/src\/repo\/src\/Render.php":{"errors":63,"warnings":2,"messages":[{"message":"If this is a class comment, it must have no blank lines after; if it is a stray comment, it must not use \"\/**\" style comments; if it is a file-level comment, file a task in #MediaWiki-Codesniffer","source":"MediaWiki.Commenting.CommentBeforeClass.SpacingAfter","severity":5,"fixable":false,"type":"ERROR","line":39,"column":1},{"message":"@subpackage is not a valid class annotation","source":"MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":44,"column":4},{"message":"Doc comment for parameter \"$sTitle\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":69,"column":5},{"message":"Doc comment for parameter \"$sContent\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":69,"column":5},{"message":"Doc comment for parameter \"$attr\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":69,"column":5},{"message":"Doc comment for parameter \"$attr\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":91,"column":5},{"message":"Global variable \"$egS5SlideHeadingMark\" is lacking an allowed prefix ('wg'). Should be \"$wgEgS5SlideHeadingMark\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":95,"column":9},{"message":"Global variable \"$egS5SlideIncMark\" is lacking an allowed prefix ('wg'). Should be \"$wgEgS5SlideIncMark\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":95,"column":9},{"message":"Global variable \"$egS5SlideCenterMark\" is lacking an allowed prefix ('wg'). Should be \"$wgEgS5SlideCenterMark\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":95,"column":9},{"message":"Global variable \"$egS5DefaultStyle\" is lacking an allowed prefix ('wg'). Should be \"$wgEgS5DefaultStyle\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":95,"column":9},{"message":"Global variable \"$egS5Scaled\" is lacking an allowed prefix ('wg'). Should be \"$wgEgS5Scaled\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":95,"column":9},{"message":"Doc comment for parameter \"$node\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":157,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":160,"column":6},{"message":"Method name \"check_slide_heading\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":161,"column":12},{"message":"Doc comment for parameter \"$content\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":186,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":188,"column":6},{"message":"Method name \"transform_section_slides\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":189,"column":13},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.Found","severity":5,"fixable":false,"type":"WARNING","line":217,"column":72},{"message":"Doc comment for parameter \"$content\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":273,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":275,"column":6},{"message":"Doc comment for parameter \"$text\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":307,"column":5},{"message":"Doc comment for parameter \"$inline\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":307,"column":5},{"message":"Doc comment for parameter \"$title\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":307,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":310,"column":6},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":329,"column":13},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate","severity":5,"fixable":false,"type":"ERROR","line":352,"column":13},{"message":"Doc comment for parameter \"$printPageSize\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":372,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":374,"column":6},{"message":"Global variable \"$egS5SlideTemplateFile\" is lacking an allowed prefix ('wg'). Should be \"$wgEgS5SlideTemplateFile\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":376,"column":9},{"message":"Doc comment for parameter \"$skin\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":474,"column":5},{"message":"Doc comment for parameter \"$m\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":474,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":477,"column":6},{"message":"Doc comment for parameter \"$skin\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":503,"column":5},{"message":"Doc comment for parameter \"$print\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":503,"column":5},{"message":"Doc comment for parameter \"$content\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":542,"column":5},{"message":"Doc comment for parameter \"$attr\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":542,"column":5},{"message":"Doc comment for parameter \"$parser\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":542,"column":5},{"message":"Doc comment for parameter \"$frame\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":542,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":544,"column":6},{"message":"Method name \"slideshow_legacy\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":545,"column":19},{"message":"Doc comment for parameter \"$content\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":553,"column":5},{"message":"Doc comment for parameter \"$parser\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":553,"column":5},{"message":"Doc comment for parameter \"$inline\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":553,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":556,"column":6},{"message":"Method name \"clone_options_parse\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":557,"column":20},{"message":"Doc comment for parameter \"$content\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":579,"column":5},{"message":"Doc comment for parameter \"$attr\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":579,"column":5},{"message":"Doc comment for parameter \"$parser\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":579,"column":5},{"message":"Doc comment for parameter \"$frame\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":579,"column":5},{"message":"Doc comment for parameter \"$addmsg\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":579,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":582,"column":6},{"message":"Method name \"slideshow_view\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":583,"column":19},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.Found","severity":5,"fixable":false,"type":"WARNING","line":624,"column":46},{"message":"Method name \"slideshow_parse\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":655,"column":12},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":655,"column":12},{"message":"Method name \"slides_view\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":662,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":662,"column":19},{"message":"Method name \"slides_parse\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":707,"column":12},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":707,"column":12},{"message":"Method name \"slidecss_view\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":726,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":726,"column":19},{"message":"Method name \"slidecss_parse\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":739,"column":12},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":739,"column":12},{"message":"Method name \"empty_tag_hook\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":744,"column":19},{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":744,"column":19}]}}}
--- end ---
* sniff MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation is now failing
* sniff MediaWiki.Commenting.CommentBeforeClass.StrayStyle is now failing
* sniff MediaWiki.Commenting.CommentBeforeClass.SpacingAfter is now failing
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Deprecation Notice: Composer\Installers\Installer::__construct(): Implicitly marking parameter $filesystem as nullable is deprecated, the explicit nullable type must be used instead in /src/repo/vendor/composer/installers/src/Composer/Installers/Installer.php:136
More deprecation notices were hidden, run again with `-v` to show them.
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
Deprecation Notice: Composer\Installers\Installer::__construct(): Implicitly marking parameter $filesystem as nullable is deprecated, the explicit nullable type must be used instead in /src/repo/vendor/composer/installers/src/Composer/Installers/Installer.php:136
More deprecation notices were hidden, run again with `-v` to show them.
> parallel-lint . --exclude vendor --exclude node_modules
> phpcs -p -s .
> minus-x check .
--- stdout ---
PHP 8.4.11 | 10 parallel jobs
........ 8/8 (100%)
Checked 8 files in 0.1 seconds
No syntax error found
........ 8 / 8 (100%)
Time: 291ms; Memory: 8MB
MinusX
======
Processing /src/repo...
.............................................................
.................................................
All good!
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {
"brace-expansion": {
"name": "brace-expansion",
"severity": "low",
"isDirect": false,
"via": [
{
"source": 1105443,
"name": "brace-expansion",
"dependency": "brace-expansion",
"title": "brace-expansion Regular Expression Denial of Service vulnerability",
"url": "https://github.com/advisories/GHSA-v6h2-p8h4-qcjw",
"severity": "low",
"cwe": [
"CWE-400"
],
"cvss": {
"score": 3.1,
"vectorString": "CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:N/A:L"
},
"range": ">=1.0.0 <=1.1.11"
},
{
"source": 1105444,
"name": "brace-expansion",
"dependency": "brace-expansion",
"title": "brace-expansion Regular Expression Denial of Service vulnerability",
"url": "https://github.com/advisories/GHSA-v6h2-p8h4-qcjw",
"severity": "low",
"cwe": [
"CWE-400"
],
"cvss": {
"score": 3.1,
"vectorString": "CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:N/A:L"
},
"range": ">=2.0.0 <=2.0.1"
}
],
"effects": [],
"range": "1.0.0 - 1.1.11 || 2.0.0 - 2.0.1",
"nodes": [
"node_modules/@typescript-eslint/typescript-estree/node_modules/brace-expansion",
"node_modules/brace-expansion",
"node_modules/eslint-plugin-n/node_modules/brace-expansion"
],
"fixAvailable": true
}
},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 1,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 1
},
"dependencies": {
"prod": 1,
"dev": 311,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 311
}
}
}
--- end ---
Attempting to npm audit fix
$ /usr/bin/npm audit fix --dry-run --only=dev --json
--- stderr ---
npm WARN invalid config only="dev" set in command line options
npm WARN invalid config Must be one of: null, prod, production
--- stdout ---
{
"added": 311,
"removed": 0,
"changed": 0,
"audited": 312,
"funding": 58,
"audit": {
"auditReportVersion": 2,
"vulnerabilities": {
"brace-expansion": {
"name": "brace-expansion",
"severity": "low",
"isDirect": false,
"via": [
{
"source": 1105443,
"name": "brace-expansion",
"dependency": "brace-expansion",
"title": "brace-expansion Regular Expression Denial of Service vulnerability",
"url": "https://github.com/advisories/GHSA-v6h2-p8h4-qcjw",
"severity": "low",
"cwe": [
"CWE-400"
],
"cvss": {
"score": 3.1,
"vectorString": "CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:N/A:L"
},
"range": ">=1.0.0 <=1.1.11"
},
{
"source": 1105444,
"name": "brace-expansion",
"dependency": "brace-expansion",
"title": "brace-expansion Regular Expression Denial of Service vulnerability",
"url": "https://github.com/advisories/GHSA-v6h2-p8h4-qcjw",
"severity": "low",
"cwe": [
"CWE-400"
],
"cvss": {
"score": 3.1,
"vectorString": "CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:N/A:L"
},
"range": ">=2.0.0 <=2.0.1"
}
],
"effects": [],
"range": "1.0.0 - 1.1.11 || 2.0.0 - 2.0.1",
"nodes": [
"",
"",
""
],
"fixAvailable": true
}
},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 1,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 1
},
"dependencies": {
"prod": 1,
"dev": 311,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 311
}
}
}
}
--- end ---
{"added": 311, "removed": 0, "changed": 0, "audited": 312, "funding": 58, "audit": {"auditReportVersion": 2, "vulnerabilities": {"brace-expansion": {"name": "brace-expansion", "severity": "low", "isDirect": false, "via": [{"source": 1105443, "name": "brace-expansion", "dependency": "brace-expansion", "title": "brace-expansion Regular Expression Denial of Service vulnerability", "url": "https://github.com/advisories/GHSA-v6h2-p8h4-qcjw", "severity": "low", "cwe": ["CWE-400"], "cvss": {"score": 3.1, "vectorString": "CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:N/A:L"}, "range": ">=1.0.0 <=1.1.11"}, {"source": 1105444, "name": "brace-expansion", "dependency": "brace-expansion", "title": "brace-expansion Regular Expression Denial of Service vulnerability", "url": "https://github.com/advisories/GHSA-v6h2-p8h4-qcjw", "severity": "low", "cwe": ["CWE-400"], "cvss": {"score": 3.1, "vectorString": "CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:N/A:L"}, "range": ">=2.0.0 <=2.0.1"}], "effects": [], "range": "1.0.0 - 1.1.11 || 2.0.0 - 2.0.1", "nodes": ["", "", ""], "fixAvailable": true}}, "metadata": {"vulnerabilities": {"info": 0, "low": 1, "moderate": 0, "high": 0, "critical": 0, "total": 1}, "dependencies": {"prod": 1, "dev": 311, "optional": 0, "peer": 1, "peerOptional": 0, "total": 311}}}}
$ /usr/bin/npm audit fix --only=dev
--- stderr ---
npm WARN invalid config only="dev" set in command line options
npm WARN invalid config Must be one of: null, prod, production
npm WARN deprecated @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
npm WARN deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
--- stdout ---
added 311 packages, and audited 312 packages in 3s
58 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
--- end ---
Verifying that tests still pass
$ /usr/bin/npm ci
--- stderr ---
npm WARN deprecated @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
npm WARN deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
--- stdout ---
added 311 packages, and audited 312 packages in 3s
58 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
--- end ---
$ /usr/bin/npm test
--- stdout ---
> test
> grunt test
Running "eslint:all" (eslint) task
Running "banana:S5SlideShow" (banana) task
>> 1 message directory checked.
Done.
--- end ---
{"1105443": {"source": 1105443, "name": "brace-expansion", "dependency": "brace-expansion", "title": "brace-expansion Regular Expression Denial of Service vulnerability", "url": "https://github.com/advisories/GHSA-v6h2-p8h4-qcjw", "severity": "low", "cwe": ["CWE-400"], "cvss": {"score": 3.1, "vectorString": "CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:N/A:L"}, "range": ">=1.0.0 <=1.1.11"}, "1105444": {"source": 1105444, "name": "brace-expansion", "dependency": "brace-expansion", "title": "brace-expansion Regular Expression Denial of Service vulnerability", "url": "https://github.com/advisories/GHSA-v6h2-p8h4-qcjw", "severity": "low", "cwe": ["CWE-400"], "cvss": {"score": 3.1, "vectorString": "CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:N/A:L"}, "range": ">=2.0.0 <=2.0.1"}}
Upgrading n:brace-expansion from 1.1.11, 2.0.1 -> 1.1.12, 2.0.2
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 47.0.0 → 48.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation
* MediaWiki.Commenting.CommentBeforeClass.SpacingAfter
* MediaWiki.Commenting.CommentBeforeClass.StrayStyle
npm:
* brace-expansion: 1.1.11, 2.0.1 → 1.1.12, 2.0.2
* https://github.com/advisories/GHSA-v6h2-p8h4-qcjw
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmp5qkkcrrm
--- stdout ---
[master f2354e1] build: Updating dependencies
4 files changed, 22 insertions(+), 20 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From f2354e1314e778a4609f7f5ea1f57dd6e2157cf8 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Tue, 11 Nov 2025 03:00:43 +0000
Subject: [PATCH] build: Updating dependencies
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
composer:
* mediawiki/mediawiki-codesniffer: 47.0.0 → 48.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation
* MediaWiki.Commenting.CommentBeforeClass.SpacingAfter
* MediaWiki.Commenting.CommentBeforeClass.StrayStyle
npm:
* brace-expansion: 1.1.11, 2.0.1 → 1.1.12, 2.0.2
* https://github.com/advisories/GHSA-v6h2-p8h4-qcjw
Change-Id: I4d9f7e6fa8d6d66e26ef291e0b52b2c290c422b5
---
.phpcs.xml | 3 +++
composer.json | 2 +-
package-lock.json | 36 ++++++++++++++++++------------------
src/Skin.php | 1 -
4 files changed, 22 insertions(+), 20 deletions(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index b48d343..48707fb 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,6 +2,9 @@
<ruleset name="MediaWiki">
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="Generic.CodeAnalysis.AssignmentInCondition.Found" />
+ <exclude name="MediaWiki.Commenting.ClassAnnotations.UnrecognizedAnnotation" />
+ <exclude name="MediaWiki.Commenting.CommentBeforeClass.SpacingAfter" />
+ <exclude name="MediaWiki.Commenting.CommentBeforeClass.StrayStyle" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
diff --git a/composer.json b/composer.json
index 2a4e351..a4b148e 100644
--- a/composer.json
+++ b/composer.json
@@ -40,7 +40,7 @@
"composer/installers": "1.*,>=1.0.1"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "47.0.0",
+ "mediawiki/mediawiki-codesniffer": "48.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0"
diff --git a/package-lock.json b/package-lock.json
index 8ecdefa..4fd6cf7 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -414,9 +414,9 @@
}
},
"node_modules/@typescript-eslint/typescript-estree/node_modules/brace-expansion": {
- "version": "2.0.1",
- "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.1.tgz",
- "integrity": "sha512-XnAIvQ8eM+kC6aULx6wuQiwVsnzsi9d3WxzV3FpWTGA19F621kwdbsAcFKXgKUHZWsy+mY6iL1sHTxWEFCytDA==",
+ "version": "2.0.2",
+ "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.2.tgz",
+ "integrity": "sha512-Jt0vHyM+jmUBqojB7E1NIYadt0vI0Qxjxd2TErW94wDz+E2LAm5vKMXXwg6ZZBTHPuUlDgQHKXvjGBdfcF1ZDQ==",
"dev": true,
"dependencies": {
"balanced-match": "^1.0.0"
@@ -617,9 +617,9 @@
"dev": true
},
"node_modules/brace-expansion": {
- "version": "1.1.11",
- "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-1.1.11.tgz",
- "integrity": "sha512-iCuPHDFgrHX7H2vEI/5xpz07zSHB00TpugqhmYtVmMO6518mCuRMoOYFldEBl0g187ufozdaHgWKcYFb61qGiA==",
+ "version": "1.1.12",
+ "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-1.1.12.tgz",
+ "integrity": "sha512-9T9UjW3r0UW5c1Q7GTwllptXwhvYmEzFhzMfZ9H7FQWt+uZePjZPjBP/W1ZEyZ1twGWom5/56TF4lPcqjnDHcg==",
"dev": true,
"dependencies": {
"balanced-match": "^1.0.0",
@@ -1209,9 +1209,9 @@
}
},
"node_modules/eslint-plugin-n/node_modules/brace-expansion": {
- "version": "2.0.1",
- "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.1.tgz",
- "integrity": "sha512-XnAIvQ8eM+kC6aULx6wuQiwVsnzsi9d3WxzV3FpWTGA19F621kwdbsAcFKXgKUHZWsy+mY6iL1sHTxWEFCytDA==",
+ "version": "2.0.2",
+ "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.2.tgz",
+ "integrity": "sha512-Jt0vHyM+jmUBqojB7E1NIYadt0vI0Qxjxd2TErW94wDz+E2LAm5vKMXXwg6ZZBTHPuUlDgQHKXvjGBdfcF1ZDQ==",
"dev": true,
"dependencies": {
"balanced-match": "^1.0.0"
@@ -3967,9 +3967,9 @@
},
"dependencies": {
"brace-expansion": {
- "version": "2.0.1",
- "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.1.tgz",
- "integrity": "sha512-XnAIvQ8eM+kC6aULx6wuQiwVsnzsi9d3WxzV3FpWTGA19F621kwdbsAcFKXgKUHZWsy+mY6iL1sHTxWEFCytDA==",
+ "version": "2.0.2",
+ "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.2.tgz",
+ "integrity": "sha512-Jt0vHyM+jmUBqojB7E1NIYadt0vI0Qxjxd2TErW94wDz+E2LAm5vKMXXwg6ZZBTHPuUlDgQHKXvjGBdfcF1ZDQ==",
"dev": true,
"requires": {
"balanced-match": "^1.0.0"
@@ -4124,9 +4124,9 @@
"dev": true
},
"brace-expansion": {
- "version": "1.1.11",
- "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-1.1.11.tgz",
- "integrity": "sha512-iCuPHDFgrHX7H2vEI/5xpz07zSHB00TpugqhmYtVmMO6518mCuRMoOYFldEBl0g187ufozdaHgWKcYFb61qGiA==",
+ "version": "1.1.12",
+ "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-1.1.12.tgz",
+ "integrity": "sha512-9T9UjW3r0UW5c1Q7GTwllptXwhvYmEzFhzMfZ9H7FQWt+uZePjZPjBP/W1ZEyZ1twGWom5/56TF4lPcqjnDHcg==",
"dev": true,
"requires": {
"balanced-match": "^1.0.0",
@@ -4549,9 +4549,9 @@
},
"dependencies": {
"brace-expansion": {
- "version": "2.0.1",
- "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.1.tgz",
- "integrity": "sha512-XnAIvQ8eM+kC6aULx6wuQiwVsnzsi9d3WxzV3FpWTGA19F621kwdbsAcFKXgKUHZWsy+mY6iL1sHTxWEFCytDA==",
+ "version": "2.0.2",
+ "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.2.tgz",
+ "integrity": "sha512-Jt0vHyM+jmUBqojB7E1NIYadt0vI0Qxjxd2TErW94wDz+E2LAm5vKMXXwg6ZZBTHPuUlDgQHKXvjGBdfcF1ZDQ==",
"dev": true,
"requires": {
"balanced-match": "^1.0.0"
diff --git a/src/Skin.php b/src/Skin.php
index 899edd0..a20a96d 100644
--- a/src/Skin.php
+++ b/src/Skin.php
@@ -31,7 +31,6 @@ use SkinTemplate;
/**
* see https://doc.wikimedia.org/mediawiki-core/master/php/classSkinApi.html
- *
*/
class Skin extends SkinApi {
/**
--
2.47.3
--- end ---