$ date
--- stdout ---
Wed Nov 20 05:45:28 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-StandardDialogs.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
8567099cfcd25f977e46f925efc25823134d6534 refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {
"cross-spawn": {
"name": "cross-spawn",
"severity": "high",
"isDirect": false,
"via": [
{
"source": 1100556,
"name": "cross-spawn",
"dependency": "cross-spawn",
"title": "Regular Expression Denial of Service (ReDoS) in cross-spawn",
"url": "https://github.com/advisories/GHSA-3xgq-45jj-v275",
"severity": "high",
"cwe": [
"CWE-1333"
],
"cvss": {
"score": 7.5,
"vectorString": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H"
},
"range": ">=7.0.0 <7.0.5"
}
],
"effects": [],
"range": "7.0.0 - 7.0.4",
"nodes": [
"node_modules/cross-spawn"
],
"fixAvailable": true
}
},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 1,
"critical": 0,
"total": 1
},
"dependencies": {
"prod": 1,
"dev": 426,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 426
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 22 installs, 0 updates, 0 removals
- Locking composer/installers (v2.3.0)
- Locking composer/semver (3.4.3)
- Locking composer/spdx-licenses (1.5.8)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking mediawiki/mediawiki-codesniffer (v45.0.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.12)
- Locking psr/container (2.0.2)
- Locking squizlabs/php_codesniffer (3.10.3)
- Locking symfony/console (v7.1.8)
- Locking symfony/deprecation-contracts (v3.5.0)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-intl-grapheme (v1.31.0)
- Locking symfony/polyfill-intl-normalizer (v1.31.0)
- Locking symfony/polyfill-mbstring (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking symfony/service-contracts (v3.5.0)
- Locking symfony/string (v7.1.8)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 22 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing composer/installers (v2.3.0): Extracting archive
- Installing squizlabs/php_codesniffer (3.10.3): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.12): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.3): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v45.0.0): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
- Installing symfony/string (v7.1.8): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.0): Extracting archive
- Installing symfony/console (v7.1.8): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/19 [>---------------------------] 0%
19/19 [============================] 100%
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {
"cross-spawn": {
"name": "cross-spawn",
"severity": "high",
"isDirect": false,
"via": [
{
"source": 1100556,
"name": "cross-spawn",
"dependency": "cross-spawn",
"title": "Regular Expression Denial of Service (ReDoS) in cross-spawn",
"url": "https://github.com/advisories/GHSA-3xgq-45jj-v275",
"severity": "high",
"cwe": [
"CWE-1333"
],
"cvss": {
"score": 7.5,
"vectorString": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H"
},
"range": ">=7.0.0 <7.0.5"
}
],
"effects": [],
"range": "7.0.0 - 7.0.4",
"nodes": [
"node_modules/cross-spawn"
],
"fixAvailable": true
}
},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 1,
"critical": 0,
"total": 1
},
"dependencies": {
"prod": 1,
"dev": 426,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 426
}
}
}
--- end ---
Attempting to npm audit fix
$ /usr/bin/npm audit fix --dry-run --only=dev --json
--- stderr ---
npm WARN invalid config only="dev" set in command line options
npm WARN invalid config Must be one of: null, prod, production
--- stdout ---
{
"added": 426,
"removed": 0,
"changed": 0,
"audited": 427,
"funding": 96,
"audit": {
"auditReportVersion": 2,
"vulnerabilities": {
"cross-spawn": {
"name": "cross-spawn",
"severity": "high",
"isDirect": false,
"via": [
{
"source": 1100556,
"name": "cross-spawn",
"dependency": "cross-spawn",
"title": "Regular Expression Denial of Service (ReDoS) in cross-spawn",
"url": "https://github.com/advisories/GHSA-3xgq-45jj-v275",
"severity": "high",
"cwe": [
"CWE-1333"
],
"cvss": {
"score": 7.5,
"vectorString": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H"
},
"range": ">=7.0.0 <7.0.5"
}
],
"effects": [],
"range": "7.0.0 - 7.0.4",
"nodes": [
""
],
"fixAvailable": true
}
},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 1,
"critical": 0,
"total": 1
},
"dependencies": {
"prod": 1,
"dev": 426,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 426
}
}
}
}
--- end ---
{"added": 426, "removed": 0, "changed": 0, "audited": 427, "funding": 96, "audit": {"auditReportVersion": 2, "vulnerabilities": {"cross-spawn": {"name": "cross-spawn", "severity": "high", "isDirect": false, "via": [{"source": 1100556, "name": "cross-spawn", "dependency": "cross-spawn", "title": "Regular Expression Denial of Service (ReDoS) in cross-spawn", "url": "https://github.com/advisories/GHSA-3xgq-45jj-v275", "severity": "high", "cwe": ["CWE-1333"], "cvss": {"score": 7.5, "vectorString": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H"}, "range": ">=7.0.0 <7.0.5"}], "effects": [], "range": "7.0.0 - 7.0.4", "nodes": [""], "fixAvailable": true}}, "metadata": {"vulnerabilities": {"info": 0, "low": 0, "moderate": 0, "high": 1, "critical": 0, "total": 1}, "dependencies": {"prod": 1, "dev": 426, "optional": 0, "peer": 1, "peerOptional": 0, "total": 426}}}}
$ /usr/bin/npm audit fix --only=dev
--- stderr ---
npm WARN invalid config only="dev" set in command line options
npm WARN invalid config Must be one of: null, prod, production
--- stdout ---
added 426 packages, and audited 427 packages in 5s
96 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
--- end ---
Verifying that tests still pass
$ /usr/bin/npm ci
--- stdout ---
added 426 packages, and audited 427 packages in 5s
96 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
--- end ---
$ /usr/bin/npm test
--- stdout ---
> test
> grunt test
Running "eslint:all" (eslint) task
/src/repo/resources/StandardDialogs.ui/BaseDialog.js
35:70 warning 'data' is defined but never used no-unused-vars
85:8 warning Where possible, maintain application state in JS to avoid slower DOM queries no-jquery/no-class-state
102:76 warning 'action' is defined but never used no-unused-vars
115:82 warning 'action' is defined but never used no-unused-vars
/src/repo/resources/StandardDialogs.ui/DeleteDialog.js
13:2 warning Global variable leak, declare the variable if it is intended to be local no-implicit-globals
13:2 warning 'data' is not defined no-undef
14:2 warning 'data' is not defined no-undef
15:2 warning 'data' is not defined no-undef
17:9 warning 'data' is not defined no-undef
125:64 warning 'data' is defined but never used no-unused-vars
/src/repo/resources/StandardDialogs.ui/DuplicateDialog.js
6:27 warning A constructor name should not start with a lowercase letter new-cap
15:2 warning Global variable leak, declare the variable if it is intended to be local no-implicit-globals
15:2 warning 'data' is not defined no-undef
16:2 warning 'data' is not defined no-undef
18:9 warning 'data' is not defined no-undef
22:42 warning 'OOJSPlus' is not defined no-undef
68:1 warning This line has a length of 105. Maximum allowed is 100 max-len
68:5 warning Unexpected var, use let or const instead no-var
72:5 warning Unexpected var, use let or const instead no-var
75:12 warning 'dfdDiscussion' declared on line 68 column 9 is used outside of binding context block-scoped-var
75:27 warning 'dfdSubpages' declared on line 72 column 9 is used outside of binding context block-scoped-var
106:87 warning 'action' is defined but never used no-unused-vars
110:1 warning This line has a length of 106. Maximum allowed is 100 max-len
150:1 warning This line has a length of 114. Maximum allowed is 100 max-len
170:1 warning This line has a length of 106. Maximum allowed is 100 max-len
207:22 warning 'resp' is already declared in the upper scope on line 193 column 14 no-shadow
209:18 warning 'errResp' is not defined no-undef
213:18 warning 'errResp' is not defined no-undef
/src/repo/resources/StandardDialogs.ui/MoveDialog.js
12:2 warning Global variable leak, declare the variable if it is intended to be local no-implicit-globals
12:2 warning 'data' is not defined no-undef
13:2 warning 'data' is not defined no-undef
15:9 warning 'data' is not defined no-undef
19:42 warning 'OOJSPlus' is not defined no-undef
97:58 warning 'data' is defined but never used no-unused-vars
100:1 warning This line has a length of 102. Maximum allowed is 100 max-len
109:82 warning 'action' is defined but never used no-unused-vars
/src/repo/resources/StandardDialogs.ui/NewPageDialog.js
12:2 warning Global variable leak, declare the variable if it is intended to be local no-implicit-globals
12:2 warning 'data' is not defined no-undef
13:2 warning 'data' is not defined no-undef
15:9 warning 'data' is not defined no-undef
23:42 warning 'OOJSPlus' is not defined no-undef
47:85 warning 'action' is defined but never used no-unused-vars
/src/repo/resources/StandardDialogs.ui/NewSubpageDialog.js
12:2 warning Global variable leak, declare the variable if it is intended to be local no-implicit-globals
12:2 warning 'data' is not defined no-undef
13:2 warning 'data' is not defined no-undef
15:9 warning 'data' is not defined no-undef
18:42 warning 'OOJSPlus' is not defined no-undef
42:88 warning 'action' is defined but never used no-unused-vars
/src/repo/resources/StandardDialogs.ui/PageInformationDialog.js
4:1 warning This line has a length of 102. Maximum allowed is 100 max-len
35:34 warning 'page' is already declared in the upper scope on line 24 column 6 no-shadow
42:1 warning This line has a length of 103. Maximum allowed is 100 max-len
58:8 warning Where possible, maintain application state in JS to avoid slower DOM queries no-jquery/no-class-state
68:1 warning This line has a length of 106. Maximum allowed is 100 max-len
/src/repo/resources/StandardDialogs.ui/Pages/BasicInformationPage.js
8:1 warning This line has a length of 102. Maximum allowed is 100 max-len
19:20 warning Expected '!==' and instead saw '!=' eqeqeq
20:4 warning Global variable leak, declare the variable if it is intended to be local no-implicit-globals
20:4 warning 'fieldLayout' is not defined no-undef
21:10 warning jQuery collection names must match the variablePattern no-jquery/variable-pattern
58:4 warning 'fieldLayout' is not defined no-undef
60:24 warning 'fieldLayout' is not defined no-undef
87:8 warning jQuery collection names must match the variablePattern no-jquery/variable-pattern
107:1 warning 'registryPageInformation' is not defined no-undef
/src/repo/resources/StandardDialogs.ui/Pages/HistoryInformationPage.js
8:1 warning This line has a length of 104. Maximum allowed is 100 max-len
20:4 warning Global variable leak, declare the variable if it is intended to be local no-implicit-globals
20:4 warning 'fieldLayout' is not defined no-undef
21:10 warning jQuery collection names must match the variablePattern no-jquery/variable-pattern
39:22 warning 'OOJSPlus' is not defined no-undef
40:1 warning This line has a length of 101. Maximum allowed is 100 max-len
50:4 warning 'fieldLayout' is not defined no-undef
52:24 warning 'fieldLayout' is not defined no-undef
58:8 warning jQuery collection names must match the variablePattern no-jquery/variable-pattern
62:27 warning 'OOJSPlus' is not defined no-undef
63:1 warning This line has a length of 103. Maximum allowed is 100 max-len
99:1 warning 'registryPageInformation' is not defined no-undef
/src/repo/resources/StandardDialogs.ui/Pages/PropertiesInformationPage.js
23:10 warning jQuery collection names must match the variablePattern no-jquery/variable-pattern
92:1 warning This line has a length of 113. Maximum allowed is 100 max-len
135:8 warning jQuery collection names must match the variablePattern no-jquery/variable-pattern
159:8 warning jQuery collection names must match the variablePattern no-jquery/variable-pattern
183:8 warning jQuery collection names must match the variablePattern no-jquery/variable-pattern
207:8 warning jQuery collection names must match the variablePattern no-jquery/variable-pattern
231:8 warning jQuery collection names must match the variablePattern no-jquery/variable-pattern
243:15 warning ES2017 'Object.values' method is forbidden es-x/no-object-values
245:15 warning ES2017 'Object.values' method is forbidden es-x/no-object-values
253:1 warning 'registryPageInformation' is not defined no-undef
/src/repo/resources/StandardDialogs.ui/ProtectDialog.js
12:2 warning Global variable leak, declare the variable if it is intended to be local no-implicit-globals
12:2 warning 'data' is not defined no-undef
13:2 warning 'data' is not defined no-undef
15:9 warning 'data' is not defined no-undef
164:22 warning Expected '!==' and instead saw '!=' eqeqeq
185:1 warning This line has a length of 101. Maximum allowed is 100 max-len
217:2 warning Global variable leak, declare the variable if it is intended to be local no-implicit-globals
217:2 warning 'otherReason' is not defined no-undef
218:59 warning 'otherReason' is not defined no-undef
218:78 warning 'otherReason' is not defined no-undef
/src/repo/resources/StandardDialogs.ui/RefreshDialog.js
12:2 warning Global variable leak, declare the variable if it is intended to be local no-implicit-globals
12:2 warning 'data' is not defined no-undef
13:2 warning 'data' is not defined no-undef
15:9 warning 'data' is not defined no-undef
43:24 warning 'data' is defined but never used no-unused-vars
46:1 warning This line has a length of 102. Maximum allowed is 100 max-len
/src/repo/resources/ext.standardDialogs.allpages.js
13:20 warning 'registryPageInformation' is not defined no-undef
/src/repo/resources/ext.standardDialogs.books.deleteAction.js
3:23 warning Expected '!==' and instead saw '!=' eqeqeq
4:3 warning jQuery collection names must match the variablePattern no-jquery/variable-pattern
/src/repo/resources/ext.standardDialogs.js
88:20 warning 'registryPageInformation' is not defined no-undef
108:4 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
110:4 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
✖ 106 problems (0 errors, 106 warnings)
Running "banana:standarddialogs" (banana) task
>> 1 message directory checked.
Running "stylelint:all" (stylelint) task
>> Linted 1 files without errors
Done.
--- end ---
{"1100556": {"source": 1100556, "name": "cross-spawn", "dependency": "cross-spawn", "title": "Regular Expression Denial of Service (ReDoS) in cross-spawn", "url": "https://github.com/advisories/GHSA-3xgq-45jj-v275", "severity": "high", "cwe": ["CWE-1333"], "cvss": {"score": 7.5, "vectorString": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H"}, "range": ">=7.0.0 <7.0.5"}}
Upgrading n:cross-spawn from 7.0.3 -> 7.0.6
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating cross-spawn to 7.0.6
* https://github.com/advisories/GHSA-3xgq-45jj-v275
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmp7jn6awb1
--- stdout ---
[master 1ec1af9] build: Updating cross-spawn to 7.0.6
1 file changed, 6 insertions(+), 6 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 1ec1af9478edde759a0ec0a86c48134c67220c2b Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Wed, 20 Nov 2024 05:45:54 +0000
Subject: [PATCH] build: Updating cross-spawn to 7.0.6
* https://github.com/advisories/GHSA-3xgq-45jj-v275
Change-Id: Iee688bb2ac4a9b8ad0b7334baaccc062d29815cc
---
package-lock.json | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/package-lock.json b/package-lock.json
index a0cf3b2..2753ad3 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1133,9 +1133,9 @@
}
},
"node_modules/cross-spawn": {
- "version": "7.0.3",
- "resolved": "https://registry.npmjs.org/cross-spawn/-/cross-spawn-7.0.3.tgz",
- "integrity": "sha512-iRDPJKUPVEND7dHPO8rkbOnPpyDygcDFtWjpeWNCgy8WP2rXcxXL8TskReQl6OrB2G7+UJrags1q15Fudc7G6w==",
+ "version": "7.0.6",
+ "resolved": "https://registry.npmjs.org/cross-spawn/-/cross-spawn-7.0.6.tgz",
+ "integrity": "sha512-uV2QOWP2nWzsy2aMp8aRibhi9dlzF5Hgh5SHaB9OiTGEyDTiJJyx0uy51QXdyWbtAHNua4XJzUKca3OzKUd3vA==",
"dev": true,
"dependencies": {
"path-key": "^3.1.0",
@@ -5959,9 +5959,9 @@
}
},
"cross-spawn": {
- "version": "7.0.3",
- "resolved": "https://registry.npmjs.org/cross-spawn/-/cross-spawn-7.0.3.tgz",
- "integrity": "sha512-iRDPJKUPVEND7dHPO8rkbOnPpyDygcDFtWjpeWNCgy8WP2rXcxXL8TskReQl6OrB2G7+UJrags1q15Fudc7G6w==",
+ "version": "7.0.6",
+ "resolved": "https://registry.npmjs.org/cross-spawn/-/cross-spawn-7.0.6.tgz",
+ "integrity": "sha512-uV2QOWP2nWzsy2aMp8aRibhi9dlzF5Hgh5SHaB9OiTGEyDTiJJyx0uy51QXdyWbtAHNua4XJzUKca3OzKUd3vA==",
"dev": true,
"requires": {
"path-key": "^3.1.0",
--
2.39.2
--- end ---